[PATCH linux-next] mfd: omap-usb-host: add module.h and export.h to fix build break

[PATCH linux-next] mfd: omap-usb-host: add module.h and export.h to fix build break

[Anand Gadiyar]

linux-next as of 20110817 fails to build if these two headers
are not included. Including module.h is sufficient for now,
but add export.h for EXPORT_SYMBOL and THIS_MODULE in advance
to avoid a later build break.

Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
---
Noticed this while testing another patch. I see similar
changes to other files in drivers/mfd made by Paul recently.

 drivers/mfd/omap-usb-host.c |    2 ++
 1 file changed, 2 insertions(+)

Index: linux-2.6/drivers/mfd/omap-usb-host.c
===================================================================
--- linux-2.6.orig/drivers/mfd/omap-usb-host.c
+++ linux-2.6/drivers/mfd/omap-usb-host.c
@@ -20,6 +20,8 @@
 #include <linux/types.h>
 #include <linux/slab.h>
 #include <linux/delay.h>
+#include <linux/export.h>
+#include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/clk.h>
 #include <linux/dma-mapping.h>

[PATCH linux-next] mfd: omap-usb-host: add module.h and export.h to fix build break

[Anand Gadiyar]

linux-next as of 20110817 fails to build if these two headers
are not included. Including module.h is sufficient for now,
but add export.h for EXPORT_SYMBOL and THIS_MODULE in advance
to avoid a later build break.

Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
---
Noticed this while testing another patch. I see similar
changes to other files in drivers/mfd made by Paul recently.

 drivers/mfd/omap-usb-host.c |    2 ++
 1 file changed, 2 insertions(+)

Index: linux-2.6/drivers/mfd/omap-usb-host.c
===================================================================
--- linux-2.6.orig/drivers/mfd/omap-usb-host.c
+++ linux-2.6/drivers/mfd/omap-usb-host.c
@@ -20,6 +20,8 @@
 #include <linux/types.h>
 #include <linux/slab.h>
 #include <linux/delay.h>
+#include <linux/export.h>
+#include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/clk.h>
 #include <linux/dma-mapping.h>

Re: [PATCH linux-next] mfd: omap-usb-host: add module.h and export.h to fix build break

[Paul Gortmaker]

On 11-08-19 11:24 AM, Anand Gadiyar wrote:
> linux-next as of 20110817 fails to build if these two headers
> are not included. Including module.h is sufficient for now,
> but add export.h for EXPORT_SYMBOL and THIS_MODULE in advance
> to avoid a later build break.

Thanks -- We won't need to add both, since module.h will source
the export.h itself.    And we can't add export.h to mainline just
yet, since it won't exist there (it is only in linux-next now.)

I'll just add the right one to this file in the existing mtd patch.

Thanks for the report.

Paul.

> 
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> ---
> Noticed this while testing another patch. I see similar
> changes to other files in drivers/mfd made by Paul recently.
> 
>  drivers/mfd/omap-usb-host.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: linux-2.6/drivers/mfd/omap-usb-host.c
> ===================================================================
> --- linux-2.6.orig/drivers/mfd/omap-usb-host.c
> +++ linux-2.6/drivers/mfd/omap-usb-host.c
> @@ -20,6 +20,8 @@
>  #include <linux/types.h>
>  #include <linux/slab.h>
>  #include <linux/delay.h>
> +#include <linux/export.h>
> +#include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/clk.h>
>  #include <linux/dma-mapping.h>

Re: [PATCH linux-next] mfd: omap-usb-host: add module.h and export.h to fix build break

[Paul Gortmaker]

On 11-08-19 11:24 AM, Anand Gadiyar wrote:
> linux-next as of 20110817 fails to build if these two headers
> are not included. Including module.h is sufficient for now,
> but add export.h for EXPORT_SYMBOL and THIS_MODULE in advance
> to avoid a later build break.

Thanks -- We won't need to add both, since module.h will source
the export.h itself.    And we can't add export.h to mainline just
yet, since it won't exist there (it is only in linux-next now.)

I'll just add the right one to this file in the existing mtd patch.

Thanks for the report.

Paul.

> 
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> ---
> Noticed this while testing another patch. I see similar
> changes to other files in drivers/mfd made by Paul recently.
> 
>  drivers/mfd/omap-usb-host.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: linux-2.6/drivers/mfd/omap-usb-host.c
> ===================================================================
> --- linux-2.6.orig/drivers/mfd/omap-usb-host.c
> +++ linux-2.6/drivers/mfd/omap-usb-host.c
> @@ -20,6 +20,8 @@
>  #include <linux/types.h>
>  #include <linux/slab.h>
>  #include <linux/delay.h>
> +#include <linux/export.h>
> +#include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/clk.h>
>  #include <linux/dma-mapping.h>

Re: [PATCH linux-next] mfd: omap-usb-host: add module.h and export.h to fix build break

[Samuel Ortiz]

Hi Anand,

On Fri, Aug 19, 2011 at 08:54:05PM +0530, Anand Gadiyar wrote:
> linux-next as of 20110817 fails to build if these two headers
> are not included. Including module.h is sufficient for now,
> but add export.h for EXPORT_SYMBOL and THIS_MODULE in advance
> to avoid a later build break.
> 
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
I applied a similar patch (without the +#include <linux/export.h>) from Ming
Lei <tom.leiming@gmail.com>.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/