From: Sascha Hauer <s.hauer@pengutronix.de> To: linux-arm-kernel@lists.infradead.org Cc: Chris Ball <cjb@laptop.org>, linux-mmc@vger.kernel.org Subject: Re: [PATCH] mmc mxcmmc: fix falling back to PIO Date: Thu, 25 Aug 2011 11:31:33 +0200 [thread overview] Message-ID: <20110825093133.GA7526@pengutronix.de> (raw) In-Reply-To: <1314263172-18657-1-git-send-email-s.hauer@pengutronix.de> On Thu, Aug 25, 2011 at 11:06:12AM +0200, Sascha Hauer wrote: > When we can't configure the dma channel we want to fall > back to PIO. We do this by setting host->do_dma to zero. > This does not work as do_dma is used to see whether dma > can be used for the current transfer. Instead, we have > to set host->dma to NULL. Sorry, forget this patch. We have to set host->do_dma to 0 also. Will send an updated patch. Sascha > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Chris Ball <cjb@laptop.org> > Cc: linux-mmc@vger.kernel.org > --- > drivers/mmc/host/mxcmmc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c > index 14aa213..b050b2a 100644 > --- a/drivers/mmc/host/mxcmmc.c > +++ b/drivers/mmc/host/mxcmmc.c > @@ -730,7 +730,7 @@ static void mxcmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > dev_err(mmc_dev(host->mmc), > "failed to config DMA channel. Falling back to PIO\n"); > dma_release_channel(host->dma); > - host->do_dma = 0; > + host->dma = NULL; > } > } > > -- > 1.7.5.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] mmc mxcmmc: fix falling back to PIO Date: Thu, 25 Aug 2011 11:31:33 +0200 [thread overview] Message-ID: <20110825093133.GA7526@pengutronix.de> (raw) In-Reply-To: <1314263172-18657-1-git-send-email-s.hauer@pengutronix.de> On Thu, Aug 25, 2011 at 11:06:12AM +0200, Sascha Hauer wrote: > When we can't configure the dma channel we want to fall > back to PIO. We do this by setting host->do_dma to zero. > This does not work as do_dma is used to see whether dma > can be used for the current transfer. Instead, we have > to set host->dma to NULL. Sorry, forget this patch. We have to set host->do_dma to 0 also. Will send an updated patch. Sascha > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Chris Ball <cjb@laptop.org> > Cc: linux-mmc at vger.kernel.org > --- > drivers/mmc/host/mxcmmc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c > index 14aa213..b050b2a 100644 > --- a/drivers/mmc/host/mxcmmc.c > +++ b/drivers/mmc/host/mxcmmc.c > @@ -730,7 +730,7 @@ static void mxcmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > dev_err(mmc_dev(host->mmc), > "failed to config DMA channel. Falling back to PIO\n"); > dma_release_channel(host->dma); > - host->do_dma = 0; > + host->dma = NULL; > } > } > > -- > 1.7.5.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2011-08-25 9:31 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-25 9:06 [PATCH] mmc mxcmmc: fix falling back to PIO Sascha Hauer 2011-08-25 9:06 ` Sascha Hauer 2011-08-25 9:31 ` Sascha Hauer [this message] 2011-08-25 9:31 ` Sascha Hauer 2011-11-11 15:28 Sascha Hauer 2011-11-11 15:28 ` Sascha Hauer 2011-11-11 16:13 ` Chris Ball 2011-11-11 16:13 ` Chris Ball
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110825093133.GA7526@pengutronix.de \ --to=s.hauer@pengutronix.de \ --cc=cjb@laptop.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mmc@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.