From: Tejun Heo <tj@kernel.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: try_to_freeze() called with IRQs disabled on ARM
Date: Thu, 25 Aug 2011 14:17:10 +0200 [thread overview]
Message-ID: <20110825121710.GK3286@htj.dyndns.org> (raw)
In-Reply-To: <20110825121416.GB8883@n2100.arm.linux.org.uk>
Hello, Russell.
On Thu, Aug 25, 2011 at 01:14:16PM +0100, Russell King - ARM Linux wrote:
> was introduced, every other architecture should have been updated for
> that change... So this call in the ARM signal handling code to
> try_to_freeze() should just be deleted as it should've been done five
> years ago.
I agree. I don't think it's necessary there, so for now, let's just
delete that call, but get_signal_to_deliver() expects to be called
with IRQ enabled so it would still be a good idea to turn on/off IRQs
explicitly around it.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: try_to_freeze() called with IRQs disabled on ARM
Date: Thu, 25 Aug 2011 14:17:10 +0200 [thread overview]
Message-ID: <20110825121710.GK3286@htj.dyndns.org> (raw)
In-Reply-To: <20110825121416.GB8883@n2100.arm.linux.org.uk>
Hello, Russell.
On Thu, Aug 25, 2011 at 01:14:16PM +0100, Russell King - ARM Linux wrote:
> was introduced, every other architecture should have been updated for
> that change... So this call in the ARM signal handling code to
> try_to_freeze() should just be deleted as it should've been done five
> years ago.
I agree. I don't think it's necessary there, so for now, let's just
delete that call, but get_signal_to_deliver() expects to be called
with IRQ enabled so it would still be a good idea to turn on/off IRQs
explicitly around it.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-08-25 12:17 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 15:19 try_to_freeze() called with IRQs disabled on ARM Mark Brown
2011-08-23 15:19 ` Mark Brown
2011-08-23 15:43 ` Russell King - ARM Linux
2011-08-23 15:43 ` Russell King - ARM Linux
2011-08-23 22:08 ` Rafael J. Wysocki
2011-08-23 22:08 ` Rafael J. Wysocki
2011-08-23 21:51 ` Rafael J. Wysocki
2011-08-23 21:51 ` Rafael J. Wysocki
2011-08-23 21:53 ` Tejun Heo
2011-08-23 21:53 ` Tejun Heo
2011-08-23 22:00 ` Russell King - ARM Linux
2011-08-23 22:00 ` Russell King - ARM Linux
2011-08-23 22:08 ` Tejun Heo
2011-08-23 22:08 ` Tejun Heo
2011-08-23 22:13 ` Russell King - ARM Linux
2011-08-23 22:13 ` Russell King - ARM Linux
2011-08-23 22:17 ` Tejun Heo
2011-08-23 22:17 ` Tejun Heo
2011-08-23 22:35 ` Tejun Heo
2011-08-23 22:35 ` Tejun Heo
2011-08-24 23:15 ` Rafael J. Wysocki
2011-08-24 23:15 ` Rafael J. Wysocki
2011-08-25 12:14 ` Russell King - ARM Linux
2011-08-25 12:14 ` Russell King - ARM Linux
2011-08-25 12:17 ` Tejun Heo [this message]
2011-08-25 12:17 ` Tejun Heo
2011-08-25 12:25 ` Russell King - ARM Linux
2011-08-25 12:25 ` Russell King - ARM Linux
2011-08-25 12:35 ` Tejun Heo
2011-08-25 12:35 ` Tejun Heo
2011-08-25 13:04 ` Russell King - ARM Linux
2011-08-25 13:04 ` Russell King - ARM Linux
2011-08-25 13:09 ` Tejun Heo
2011-08-25 13:09 ` Tejun Heo
2011-08-25 14:55 ` Russell King - ARM Linux
2011-08-25 14:55 ` Russell King - ARM Linux
2011-08-26 14:44 ` Arnd Bergmann
2011-08-26 14:44 ` Arnd Bergmann
2011-09-01 13:41 ` Ulrich Weigand
2011-09-01 13:41 ` Ulrich Weigand
2011-09-01 14:00 ` Russell King - ARM Linux
2011-09-01 14:00 ` Russell King - ARM Linux
2011-09-02 14:47 ` Ulrich Weigand
2011-09-02 14:47 ` Ulrich Weigand
2011-09-02 17:22 ` Russell King - ARM Linux
2011-09-02 17:22 ` Russell King - ARM Linux
2011-09-02 17:40 ` Ulrich Weigand
2011-09-02 17:40 ` Ulrich Weigand
2011-09-02 17:48 ` Russell King - ARM Linux
2011-09-02 17:48 ` Russell King - ARM Linux
2011-09-16 10:31 ` Martin Schwidefsky
2011-09-16 10:31 ` Martin Schwidefsky
2011-09-27 17:45 ` Ulrich Weigand
2011-09-27 17:45 ` Ulrich Weigand
2011-08-30 20:58 ` Mark Brown
2011-08-30 20:58 ` Mark Brown
2011-08-30 21:10 ` Russell King - ARM Linux
2011-08-30 21:10 ` Russell King - ARM Linux
2012-06-26 16:39 ` Mandeep Singh Baines
2012-06-26 16:39 ` Mandeep Singh Baines
2012-06-26 17:16 ` Russell King - ARM Linux
2012-06-26 17:16 ` Russell King - ARM Linux
2011-08-23 22:13 ` Rafael J. Wysocki
2011-08-23 22:13 ` Rafael J. Wysocki
2011-08-25 11:37 ` Mark Brown
2011-08-25 11:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825121710.GK3286@htj.dyndns.org \
--to=tj@kernel.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.