All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Takahashi <takahash@us.ibm.com>
To: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 4/7 ver2 w/attachment] Changes to pounder's build scripts (Cyril Hrubis)
Date: Thu, 25 Aug 2011 10:26:27 -0700	[thread overview]
Message-ID: <20110825172626.GA6398@us.ibm.com> (raw)
In-Reply-To: <mailman.342816.1314268291.22889.ltp-list@lists.sourceforge.net>

On Thu, 25 Aug 2011 12:14:03, Cyril Hrubis <chrubis@suse.cz> wrote:
> To: Lucy Liang <lgliang@linux.vnet.ibm.com>

Hi Cyril,

Lucy was a summer intern here at IBM, but her internship has ended.  I'll
try to resolve any open issues with her pounder patch submission.  Please
direct any future comments to me.

> > diff --git a/tools/pounder21/build_scripts/ltp b/tools/pounder21/build_scripts/ltp
> > index 68dcdbe..70defe4 100755
> > --- a/tools/pounder21/build_scripts/ltp
> > +++ b/tools/pounder21/build_scripts/ltp
> > @@ -55,23 +55,24 @@ fi
> >  
> >  # NAK the setregid EPERM -> EINVAL patch, because it's
> >  # broken on 2.6!  May be fixed some time after 20050804 release.
> > -if [ ! -e "testcases/kernel/syscalls/setregid/setregid02.c.pounder" ]; then
> > -	echo "Patching some holes in ltp..."
> > -	cp -pRdu testcases/kernel/syscalls/setregid/setregid02.c testcases/kernel/syscalls/setregid/setregid02.c.pounder
> > -	patch -p1 < $POUNDER_SRCDIR/ltp-setregid-fix.patch
> > -	RESULT=$?
> > -	if [ $RESULT -ne 0 ]; then
> > -		echo Patching failed.
> > -		exit 1
> > -	fi
> > -fi
> > +#if [ ! -e "testcases/kernel/syscalls/setregid/setregid02.c.pounder" ]; then
> > +#	echo "Patching some holes in ltp..."
> > +#	cp -pRdu testcases/kernel/syscalls/setregid/setregid02.c testcases/kernel/syscalls/setregid/setregid02.c.pounder
> > +#	patch -p1 < $POUNDER_SRCDIR/ltp-setregid-fix.patch
> > +#	RESULT=$?
> > +#	if [ $RESULT -ne 0 ]; then
> > +#		echo Patching failed.
> > +#		exit 1
> > +#	fi
> > +#fi
> 
> Patching LTP before build from this build script is not really long term
> solution. We should get these patches applied to LTP (as it should have
> been done long time ago) and drop this logic entrirely.

I agree that this smells like a workaround, not a long term solution.

I'll investigate whether the setregid02 patch is still needed or not,
then I'll resubmit this patch.

------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

       reply	other threads:[~2011-08-25 17:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.342816.1314268291.22889.ltp-list@lists.sourceforge.net>
2011-08-25 17:26 ` James Takahashi [this message]
2011-08-26 11:40   ` [LTP] [PATCH 4/7 ver2 w/attachment] Changes to pounder's build scripts (Cyril Hrubis) Cyril Hrubis
     [not found] ` <20110825174602.GB6398@us.ibm.com>
2011-08-26 11:38   ` [LTP] [PATCH 6/7 ver2 w/attachment] Modified pounder install and run scripts Cyril Hrubis
2011-09-08 11:01     ` Cyril Hrubis
     [not found]       ` <20110908225757.GA31906@us.ibm.com>
2011-09-09 12:31         ` Cyril Hrubis
     [not found]           ` <20110909175843.GA4276@us.ibm.com>
     [not found]             ` <20111027172945.GB11634@us.ibm.com>
2011-11-02 17:39               ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110825172626.GA6398@us.ibm.com \
    --to=takahash@us.ibm.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.