Re: [LTP] [PATCH 4/7 ver2 w/attachment] Changes to pounder's build scripts (Cyril Hrubis)

Re: [LTP] [PATCH 4/7 ver2 w/attachment] Changes to pounder's build scripts (Cyril Hrubis)

[James Takahashi]

On Thu, 25 Aug 2011 12:14:03, Cyril Hrubis <chrubis@suse.cz> wrote:
> To: Lucy Liang <lgliang@linux.vnet.ibm.com>

Hi Cyril,

Lucy was a summer intern here at IBM, but her internship has ended.  I'll
try to resolve any open issues with her pounder patch submission.  Please
direct any future comments to me.

> > diff --git a/tools/pounder21/build_scripts/ltp b/tools/pounder21/build_scripts/ltp
> > index 68dcdbe..70defe4 100755
> > --- a/tools/pounder21/build_scripts/ltp
> > +++ b/tools/pounder21/build_scripts/ltp
> > @@ -55,23 +55,24 @@ fi
> >  
> >  # NAK the setregid EPERM -> EINVAL patch, because it's
> >  # broken on 2.6!  May be fixed some time after 20050804 release.
> > -if [ ! -e "testcases/kernel/syscalls/setregid/setregid02.c.pounder" ]; then
> > -	echo "Patching some holes in ltp..."
> > -	cp -pRdu testcases/kernel/syscalls/setregid/setregid02.c testcases/kernel/syscalls/setregid/setregid02.c.pounder
> > -	patch -p1 < $POUNDER_SRCDIR/ltp-setregid-fix.patch
> > -	RESULT=$?
> > -	if [ $RESULT -ne 0 ]; then
> > -		echo Patching failed.
> > -		exit 1
> > -	fi
> > -fi
> > +#if [ ! -e "testcases/kernel/syscalls/setregid/setregid02.c.pounder" ]; then
> > +#	echo "Patching some holes in ltp..."
> > +#	cp -pRdu testcases/kernel/syscalls/setregid/setregid02.c testcases/kernel/syscalls/setregid/setregid02.c.pounder
> > +#	patch -p1 < $POUNDER_SRCDIR/ltp-setregid-fix.patch
> > +#	RESULT=$?
> > +#	if [ $RESULT -ne 0 ]; then
> > +#		echo Patching failed.
> > +#		exit 1
> > +#	fi
> > +#fi
> 
> Patching LTP before build from this build script is not really long term
> solution. We should get these patches applied to LTP (as it should have
> been done long time ago) and drop this logic entrirely.

I agree that this smells like a workaround, not a long term solution.

I'll investigate whether the setregid02 patch is still needed or not,
then I'll resubmit this patch.

------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 6/7 ver2 w/attachment] Modified pounder install and run scripts

[Cyril Hrubis]

Hi!
> > I'm not happy to have tarballs stored in the git for several reasons. Is
> > this really needed? Shouldn't having directories with files serve the
> > same purpose?
> 
> The tarball form makes more sense since we want to select and extract
> only one of the available schedules.

Hmm, but wouldn't copying directory, or even better symlinking it do the
same job?

> These schedule tarballs already exist in the git repository.  Lucy's
> patch merely moved them all into their own subdirectory to improve the
> file organization.  In fact, she even removed one, so now there are
> only 3 instead of 4 :-)

Well, that is exactly the the problem with tarballs, you can't say this
for sure unless you checks by hand.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 4/7 ver2 w/attachment] Changes to pounder's build scripts (Cyril Hrubis)

[Cyril Hrubis]

Hi!
> Lucy was a summer intern here at IBM, but her internship has ended.  I'll
> try to resolve any open issues with her pounder patch submission.  Please
> direct any future comments to me.

Okay.

> > Patching LTP before build from this build script is not really long term
> > solution. We should get these patches applied to LTP (as it should have
> > been done long time ago) and drop this logic entrirely.
> 
> I agree that this smells like a workaround, not a long term solution.
> 
> I'll investigate whether the setregid02 patch is still needed or not,
> then I'll resubmit this patch.

Ideally if these patches are needed, they should be merged into LTP and
dropped from here. (I've found at least two LTP patches there).

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 6/7 ver2 w/attachment] Modified pounder install and run scripts

[Cyril Hrubis]

Hi!
Any update on this? I could probably live with the tarbals, but we
should at least do something about the LTP patches.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Doing More with Less: The Next Generation Virtual Desktop 
What are the key obstacles that have prevented many mid-market businesses
from deploying virtual desktops?   How do next-generation virtual desktops
provide companies an easier-to-deploy, easier-to-manage and more affordable
virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 6/7 ver2 w/attachment] Modified pounder install and run scripts

[Cyril Hrubis]

Hi!
> > Any update on this? I could probably live with the tarbals...
> 
> I'm happy to hear you're feeling flexible about this one.  I started
> fiddling with turning those into subdirs, but found there was being some
> ripple effect into another script which was turning this into a bigger
> job than I currently have time for.  I was going to counter-propose that
> we just leave things as-is for now -- i.e., leave the existing tarballs
> where they currently exist -- but I'd be quite pleased if you'd accept
> moving them to their new home since the new organization makes it
> easier to understand how to use pounder.

I would still rather see this as dirs, but if the change is more than
just untar them and change one script, I could live with the tarballs
for now.

> >  but we
> > should at least do something about the LTP patches.
>  
> I just perused this issue more closely, and realize that the diff is
> already doing what you want.  The existing script patches the setregid02
> subtest, but Lucy's patch comments out those lines.
> 
> I could delete them completely rather than commenting them out, but
> I'd appreciate keeping the comments for now in case I encounter the
> original problem with some older distro. 

Well there are two patches, one that is used to add some include lines
in case of debian distro and actually that one is still in place and
even may be correct. Could you check if this one is correct, int this
case we would just apply it to LTP and drop it from pounder entirely.

PS: the second patch for setregid is not likely to apply now as there
    were some changes in the source code.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Why Cloud-Based Security and Archiving Make Sense
Osterman Research conducted this study that outlines how and why cloud
computing security and archiving is rapidly being adopted across the IT 
space for its ease of implementation, lower cost, and increased 
reliability. Learn more. http://www.accelacomm.com/jaw/sfnl/114/51425301/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 6/7 ver2 w/attachment] Modified pounder install and run scripts

[Cyril Hrubis]

Hi!
> > The main mission of Lucy's patch set is to enable pounder usage for
> > the world.  Being able to run LTP side by side with your own in-house
> > tests and applications is a handy framework, and I'm hoping that Lucy's
> > patch set will help to grow a community of happy pounder users.  If you
> > could defer this issue for now, it might enable others to contribute
> > towards fixing this problem (and perhaps the tarball issue as well).  
> > 
> Hi Cyril,
> 
> Any chance that you can accept these pounder patches?  Even though
> they don't fix everything you'd like, they definitely move pounder
> a quantum leap forward in enabling others to use pounder.

Thanks for the reminder, merged.

And looking forward to future patches for the rest of the issues ;).

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
RSA® Conference 2012
Save $700 by Nov 18
Register now!
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list