From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Maxin B. John" <maxin.john@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]arm: nwfpe: '&pointer[0]' to 'pointer' fix
Date: Thu, 25 Aug 2011 20:15:01 +0100 [thread overview]
Message-ID: <20110825191501.GA4488@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110825191143.GA3149@maxin>
On Thu, Aug 25, 2011 at 10:11:43PM +0300, Maxin B. John wrote:
> '&pointer[0]' to 'pointer' fix in arch/arm/nwfpe/fpa11_cpdt.c
Your reason being?
> #ifdef __ARMEB__
> - get_user(p[0], &pMem[0]); /* sign & exponent */
> + get_user(p[0], pMem); /* sign & exponent */
> get_user(p[1], &pMem[1]);
You may notice the original code has some consistency. Your replacement
is less consistent. If you wish to make this change, it should change to:
get_user(p[0], pMem + 0);
get_user(p[1], pMem + 1);
to maintain consistency.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH]arm: nwfpe: '&pointer[0]' to 'pointer' fix
Date: Thu, 25 Aug 2011 20:15:01 +0100 [thread overview]
Message-ID: <20110825191501.GA4488@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110825191143.GA3149@maxin>
On Thu, Aug 25, 2011 at 10:11:43PM +0300, Maxin B. John wrote:
> '&pointer[0]' to 'pointer' fix in arch/arm/nwfpe/fpa11_cpdt.c
Your reason being?
> #ifdef __ARMEB__
> - get_user(p[0], &pMem[0]); /* sign & exponent */
> + get_user(p[0], pMem); /* sign & exponent */
> get_user(p[1], &pMem[1]);
You may notice the original code has some consistency. Your replacement
is less consistent. If you wish to make this change, it should change to:
get_user(p[0], pMem + 0);
get_user(p[1], pMem + 1);
to maintain consistency.
next prev parent reply other threads:[~2011-08-25 19:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 19:11 [PATCH]arm: nwfpe: '&pointer[0]' to 'pointer' fix Maxin B. John
2011-08-25 19:11 ` Maxin B. John
2011-08-25 19:15 ` Russell King - ARM Linux [this message]
2011-08-25 19:15 ` Russell King - ARM Linux
2011-08-25 20:38 Maxin B. John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825191501.GA4488@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxin.john@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.