All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: "Decker, Schorschi" <schorschi.decker@bankofamerica.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] Guest kernel device compatability auto-detection
Date: Fri, 26 Aug 2011 11:28:18 +0100	[thread overview]
Message-ID: <20110826102818.GG3905@amd.home.annexia.org> (raw)
In-Reply-To: <1314353929.3647.42.camel@lappy>

On Fri, Aug 26, 2011 at 01:18:49PM +0300, Sasha Levin wrote:
> On Fri, 2011-08-26 at 09:04 +0100, Richard W.M. Jones wrote:
> > On Fri, Aug 26, 2011 at 09:22:45AM +0300, Sasha Levin wrote:
> > > On Thu, 2011-08-25 at 16:25 +0000, Decker, Schorschi wrote:
> > > > 2) implement the feature as an agent in the guest OS where the
> > > > hypervisor can only query the guest OS agent, using a standard TCP/IP
> > > > methodology.
> > >
> > > I was planning to implementing it by probing the image before
> > > actually booting it.  This process is completely offline and doesn't
> > > require interaction with the guest. The guest isn't even running at
> > > that point.
> > 
> > There are still plenty of security issues to be concerned about with
> > handling an offline guest.  It is quite possible for such a guest to
> > be booby-trapped in a way that allows an exploit.  I summarised some
> > of the issues I thought about here, but there are likely to be others:
> > 
> > http://libguestfs.org/guestfs.3.html#security
> 
> That was an interesting read.
> 
> Are the concerns still valid if we were going to boot the image anyway
> later on?

Yes.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

WARNING: multiple messages have this Message-ID (diff)
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: kvm <kvm@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"Decker, Schorschi" <schorschi.decker@bankofamerica.com>,
	Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] Guest kernel device compatability auto-detection
Date: Fri, 26 Aug 2011 11:28:18 +0100	[thread overview]
Message-ID: <20110826102818.GG3905@amd.home.annexia.org> (raw)
In-Reply-To: <1314353929.3647.42.camel@lappy>

On Fri, Aug 26, 2011 at 01:18:49PM +0300, Sasha Levin wrote:
> On Fri, 2011-08-26 at 09:04 +0100, Richard W.M. Jones wrote:
> > On Fri, Aug 26, 2011 at 09:22:45AM +0300, Sasha Levin wrote:
> > > On Thu, 2011-08-25 at 16:25 +0000, Decker, Schorschi wrote:
> > > > 2) implement the feature as an agent in the guest OS where the
> > > > hypervisor can only query the guest OS agent, using a standard TCP/IP
> > > > methodology.
> > >
> > > I was planning to implementing it by probing the image before
> > > actually booting it.  This process is completely offline and doesn't
> > > require interaction with the guest. The guest isn't even running at
> > > that point.
> > 
> > There are still plenty of security issues to be concerned about with
> > handling an offline guest.  It is quite possible for such a guest to
> > be booby-trapped in a way that allows an exploit.  I summarised some
> > of the issues I thought about here, but there are likely to be others:
> > 
> > http://libguestfs.org/guestfs.3.html#security
> 
> That was an interesting read.
> 
> Are the concerns still valid if we were going to boot the image anyway
> later on?

Yes.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

  reply	other threads:[~2011-08-26 10:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-25  5:21 Guest kernel device compatability auto-detection Sasha Levin
2011-08-25  5:21 ` [Qemu-devel] " Sasha Levin
2011-08-25  5:33 ` Avi Kivity
2011-08-25  7:32   ` Richard W.M. Jones
2011-08-25  7:32     ` Richard W.M. Jones
2011-08-25  7:40     ` Sasha Levin
2011-08-25  7:40       ` Sasha Levin
2011-08-25  7:48       ` Richard W.M. Jones
2011-08-25 10:01         ` Richard W.M. Jones
2011-08-25 16:25           ` Decker, Schorschi
2011-08-25 16:25             ` [Qemu-devel] " Decker, Schorschi
2011-08-26  6:22             ` Sasha Levin
2011-08-26  6:22               ` Sasha Levin
2011-08-26  8:04               ` Richard W.M. Jones
2011-08-26  8:04                 ` [Qemu-devel] " Richard W.M. Jones
2011-08-26 10:18                 ` Sasha Levin
2011-08-26 10:18                   ` Sasha Levin
2011-08-26 10:28                   ` Richard W.M. Jones [this message]
2011-08-26 10:28                     ` Richard W.M. Jones
2011-08-25 21:48 ` Anthony Liguori
2011-08-25 21:48   ` [Qemu-devel] " Anthony Liguori
2011-08-26  6:08   ` Sasha Levin
2011-08-26  6:08     ` [Qemu-devel] " Sasha Levin
2011-08-26  8:43     ` Richard W.M. Jones
2011-08-26  8:43       ` Richard W.M. Jones
2011-08-26  8:40   ` Richard W.M. Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110826102818.GG3905@amd.home.annexia.org \
    --to=rjones@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=schorschi.decker@bankofamerica.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.