* [PATCH] Staging: comedi: fix printk warning issue in cb_pcidas64.c
[not found] <[PATCH]Staging: comedi:fix printk issue in cb_pcidas64.c>
@ 2011-08-26 13:08 ` Ravishankar
2011-08-26 13:25 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ravishankar @ 2011-08-26 13:08 UTC (permalink / raw)
To: gregkh, wfp5p; +Cc: devel, linux-kernel, Ravishankar, Ravishankar
From: Ravishankar <ravi.shankar@greenturtles.in>
This is a patch to the cb_pcidas64.c file that fixes up a printk warning found by the checkpatch.pl tool
Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 22 ++++++++--------------
1 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index 1e32419..37a0402 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -1739,7 +1739,7 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
uint32_t local_range, local_decode;
int retval;
- printk("comedi%d: cb_pcidas64\n", dev->minor);
+ pr_info("comedi%d: cb_pcidas64\n", dev->minor);
/*
* Allocate the private structure area.
@@ -1776,17 +1776,15 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
}
if (dev->board_ptr == NULL) {
- printk
- ("No supported ComputerBoards/MeasurementComputing card found\n");
+ pr_warn("No supported ComputerBoards/MeasurementComputing card found\n");
return -EIO;
}
- printk("Found %s on bus %i, slot %i\n", board(dev)->name,
- pcidev->bus->number, PCI_SLOT(pcidev->devfn));
+ pr_info("Found %s on bus %i, slot %i\n", board(dev)->name,
+ pcidev->bus->number, PCI_SLOT(pcidev->devfn));
if (comedi_pci_enable(pcidev, driver_cb_pcidas.driver_name)) {
- printk(KERN_WARNING
- " failed to enable PCI device and request regions\n");
+ pr_warn(" failed to enable PCI device and request regions\n");
return -EIO;
}
pci_set_master(pcidev);
@@ -1813,10 +1811,8 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
pci_resource_len(pcidev, DIO_COUNTER_BADDRINDEX));
if (!priv(dev)->plx9080_iobase || !priv(dev)->main_iobase
- || !priv(dev)->dio_counter_iobase) {
- printk(" failed to remap io memory\n");
+ || !priv(dev)->dio_counter_iobase)
return -ENOMEM;
- }
DEBUG_PRINT(" plx9080 remapped to 0x%p\n", priv(dev)->plx9080_iobase);
DEBUG_PRINT(" main remapped to 0x%p\n", priv(dev)->main_iobase);
@@ -1850,17 +1846,15 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
priv(dev)->hw_revision =
hw_revision(dev, readw(priv(dev)->main_iobase + HW_STATUS_REG));
- printk(" stc hardware revision %i\n", priv(dev)->hw_revision);
init_plx9080(dev);
init_stc_registers(dev);
/* get irq */
if (request_irq(pcidev->irq, handle_interrupt, IRQF_SHARED,
"cb_pcidas64", dev)) {
- printk(" unable to allocate irq %u\n", pcidev->irq);
+ pr_warn(" unable to allocate irq %u\n", pcidev->irq);
return -EINVAL;
}
dev->irq = pcidev->irq;
- printk(" irq %u\n", dev->irq);
retval = setup_subdevices(dev);
if (retval < 0)
@@ -1882,7 +1876,7 @@ static int detach(struct comedi_device *dev)
{
unsigned int i;
- printk("comedi%d: cb_pcidas: remove\n", dev->minor);
+ pr_info("comedi%d: cb_pcidas: remove\n", dev->minor);
if (dev->irq)
free_irq(dev->irq, dev);
--
1.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: comedi: fix printk warning issue in cb_pcidas64.c
2011-08-26 13:08 ` [PATCH] Staging: comedi: fix printk warning issue in cb_pcidas64.c Ravishankar
@ 2011-08-26 13:25 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2011-08-26 13:25 UTC (permalink / raw)
To: Ravishankar; +Cc: wfp5p, devel, linux-kernel, Ravishankar
On Fri, Aug 26, 2011 at 06:38:52PM +0530, Ravishankar wrote:
> From: Ravishankar <ravi.shankar@greenturtles.in>
>
> This is a patch to the cb_pcidas64.c file that fixes up a printk warning found by the checkpatch.pl tool
Your line is way too long, please wrap it properly.
>
> Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
I need a full name (first/last) and emails that match each other (your
from and signed-off-by: do not).
Also, how many patches are in this series, just 1? Please tell me how
many patches you are sending like the documentation says to.
You sent a second one as well, please redo that in this manner as well.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-26 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <[PATCH]Staging: comedi:fix printk issue in cb_pcidas64.c>
2011-08-26 13:08 ` [PATCH] Staging: comedi: fix printk warning issue in cb_pcidas64.c Ravishankar
2011-08-26 13:25 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.