From: Josh Triplett <josh@joshtriplett.org>
To: Chris Forbes <chrisf@ijw.co.nz>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 1/3] evaluate: warn on identical exprs around '&&'
Date: Sat, 27 Aug 2011 20:36:32 -0700 [thread overview]
Message-ID: <20110828033632.GD20823@leaf> (raw)
In-Reply-To: <CAH3ygc01LpeDEY3tmy+ntGH_EC=S7f9AOackWo8dL=5YP6GKkg@mail.gmail.com>
On Sun, Aug 28, 2011 at 02:57:36PM +1200, Chris Forbes wrote:
> > Also, how does your patch handle expressions like this: *x++ && *x++
> > Or this: f() && f()
>
> Those cases will both warn. Do I need to be looking for potential side
> effects, and considering these expressions "probably correct" in those
> cases?
Those expressions can certainly make sense in correct code, unlike cases
with identical side-effect-free expressions; that doesn't make such
expressions a good idea, though. You might want to check for
side-effect-free code (I think Sparse already has a mechanism to test
for that), and split that into a separate warning option. Whether that
option should stay on by default or not, I don't know; that will take
running it over some real codebases and evaluating the benefit.
- Josh Triplett
next prev parent reply other threads:[~2011-08-28 3:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-27 22:26 [PATCH 1/3] evaluate: warn on identical exprs around '&&' Chris Forbes
2011-08-27 22:26 ` [PATCH 2/3] evaluate: warn on identical exprs around '||' Chris Forbes
2011-08-27 22:26 ` [PATCH 3/3] evaluate: warn on identical exprs on ?: Chris Forbes
2011-08-28 2:46 ` Josh Triplett
2011-08-28 2:51 ` Chris Forbes
2011-08-28 2:50 ` [PATCH 1/3] evaluate: warn on identical exprs around '&&' Josh Triplett
2011-08-28 2:53 ` Chris Forbes
2011-08-28 3:33 ` Josh Triplett
2011-08-28 2:57 ` Chris Forbes
2011-08-28 3:36 ` Josh Triplett [this message]
2011-08-31 0:24 ` Christopher Li
2011-08-28 3:14 Chris Forbes
2011-08-29 10:01 ` Jonathan Neuschäfer
2011-08-29 10:25 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110828033632.GD20823@leaf \
--to=josh@joshtriplett.org \
--cc=chrisf@ijw.co.nz \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.