Re: [PATCH 3/3] evaluate: warn on identical exprs on ?:

[Chris Forbes <chrisf@ijw.co.nz>]

Thanks Josh -- that is a bit messy, the change to that guard does need
pushed down into the first patch. I'll fix that, any other things to
change before I resubmit?

-- Chris

On Sun, Aug 28, 2011 at 2:46 PM, Josh Triplett <josh@joshtriplett.org> wrote:
> On Sun, Aug 28, 2011 at 10:26:55AM +1200, Chris Forbes wrote:
>> Adds a warning when identical expressions are found on both the true and false branches of ?:. This is another common copy-paste error.
>>
>> Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
>> ---
>>  evaluate.c                                 |    8 +++++++-
>>  validation/check_identical_exprs_on_cond.c |   13 +++++++++++++
>>  2 files changed, 20 insertions(+), 1 deletions(-)
>>  create mode 100644 validation/check_identical_exprs_on_cond.c
>>
>> diff --git a/evaluate.c b/evaluate.c
>> index 11de7aa..c339e63 100644
>> --- a/evaluate.c
>> +++ b/evaluate.c
>> @@ -898,7 +898,7 @@ static int expr_list_equiv(struct expression_list *lhs,
>>  int expr_equiv(struct expression *lhs, struct expression *rhs)
>>  {
>>       /* recursively determine if lhs ~ rhs. */
>> -     if (!lhs ^ !rhs) return 0;
>> +     if (!lhs || !rhs) return 0;
>
> You introduced this earlier in the same patch series.  This looks like
> it needs some patch cleanup.
>
> - Josh Triplett
>
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html