All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][Trivial] CIFS: Don't free volume_info->UNC until we are entirely done with it.
@ 2011-08-27 16:58 ` Jesper Juhl
  0 siblings, 0 replies; 4+ messages in thread
From: Jesper Juhl @ 2011-08-27 16:58 UTC (permalink / raw)
  To: Steve French
  Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA,
	samba-technical-w/Ol4Ecudpl8XjKLYN78aQ,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	trivial-DgEjT+Ai2ygdnm+yROfE0A

In cleanup_volume_info_contents() we kfree(volume_info->UNC); and then 
proceed to use that variable on the very next line.
This causes (at least) Coverity Prevent to complain about use-after-free 
of that variable (and I guess other checkers may do that as well).
There's not any /real/ problem here since we are just using the value of 
the pointer, not actually dereferencing it, but it's still trivial to 
silence the tool, so why not?
To me at least it also just seems nicer to defer freeing the variable 
until we are entirely done with it in all respects.

Signed-off-by: Jesper Juhl <jj-IYz4IdjRLj0sV2N9l4h3zg@public.gmane.org>
---
 fs/cifs/connect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 633c246..9bb4b10 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -2877,9 +2877,9 @@ cleanup_volume_info_contents(struct smb_vol *volume_info)
 {
 	kfree(volume_info->username);
 	kzfree(volume_info->password);
-	kfree(volume_info->UNC);
 	if (volume_info->UNCip != volume_info->UNC + 2)
 		kfree(volume_info->UNCip);
+	kfree(volume_info->UNC);
 	kfree(volume_info->domainname);
 	kfree(volume_info->iocharset);
 	kfree(volume_info->prepath);
-- 
1.7.6.1


-- 
Jesper Juhl <jj-IYz4IdjRLj0sV2N9l4h3zg@public.gmane.org>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH][Trivial] CIFS: Don't free volume_info->UNC until we are entirely done with it.
@ 2011-08-27 16:58 ` Jesper Juhl
  0 siblings, 0 replies; 4+ messages in thread
From: Jesper Juhl @ 2011-08-27 16:58 UTC (permalink / raw)
  To: Steve French; +Cc: linux-cifs, samba-technical, linux-kernel, trivial

In cleanup_volume_info_contents() we kfree(volume_info->UNC); and then 
proceed to use that variable on the very next line.
This causes (at least) Coverity Prevent to complain about use-after-free 
of that variable (and I guess other checkers may do that as well).
There's not any /real/ problem here since we are just using the value of 
the pointer, not actually dereferencing it, but it's still trivial to 
silence the tool, so why not?
To me at least it also just seems nicer to defer freeing the variable 
until we are entirely done with it in all respects.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 fs/cifs/connect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 633c246..9bb4b10 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -2877,9 +2877,9 @@ cleanup_volume_info_contents(struct smb_vol *volume_info)
 {
 	kfree(volume_info->username);
 	kzfree(volume_info->password);
-	kfree(volume_info->UNC);
 	if (volume_info->UNCip != volume_info->UNC + 2)
 		kfree(volume_info->UNCip);
+	kfree(volume_info->UNC);
 	kfree(volume_info->domainname);
 	kfree(volume_info->iocharset);
 	kfree(volume_info->prepath);
-- 
1.7.6.1


-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH][Trivial] CIFS: Don't free volume_info->UNC until we are entirely done with it.
  2011-08-27 16:58 ` Jesper Juhl
@ 2011-08-29 15:40     ` Jeff Layton
  -1 siblings, 0 replies; 4+ messages in thread
From: Jeff Layton @ 2011-08-29 15:40 UTC (permalink / raw)
  To: Jesper Juhl
  Cc: Steve French, linux-cifs-u79uwXL29TY76Z2rM5mHXA,
	samba-technical-w/Ol4Ecudpl8XjKLYN78aQ,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	trivial-DgEjT+Ai2ygdnm+yROfE0A

On Sat, 27 Aug 2011 18:58:34 +0200 (CEST)
Jesper Juhl <jj-IYz4IdjRLj0sV2N9l4h3zg@public.gmane.org> wrote:

> In cleanup_volume_info_contents() we kfree(volume_info->UNC); and then 
> proceed to use that variable on the very next line.
> This causes (at least) Coverity Prevent to complain about use-after-free 
> of that variable (and I guess other checkers may do that as well).
> There's not any /real/ problem here since we are just using the value of 
> the pointer, not actually dereferencing it, but it's still trivial to 
> silence the tool, so why not?
> To me at least it also just seems nicer to defer freeing the variable 
> until we are entirely done with it in all respects.
> 
> Signed-off-by: Jesper Juhl <jj-IYz4IdjRLj0sV2N9l4h3zg@public.gmane.org>
> ---
>  fs/cifs/connect.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 633c246..9bb4b10 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -2877,9 +2877,9 @@ cleanup_volume_info_contents(struct smb_vol *volume_info)
>  {
>  	kfree(volume_info->username);
>  	kzfree(volume_info->password);
> -	kfree(volume_info->UNC);
>  	if (volume_info->UNCip != volume_info->UNC + 2)
>  		kfree(volume_info->UNCip);
> +	kfree(volume_info->UNC);
>  	kfree(volume_info->domainname);
>  	kfree(volume_info->iocharset);
>  	kfree(volume_info->prepath);

Seems reasonable for silencing the checker...

Reviewed-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH][Trivial] CIFS: Don't free volume_info->UNC until we are entirely done with it.
@ 2011-08-29 15:40     ` Jeff Layton
  0 siblings, 0 replies; 4+ messages in thread
From: Jeff Layton @ 2011-08-29 15:40 UTC (permalink / raw)
  To: Jesper Juhl
  Cc: Steve French, linux-cifs, samba-technical, linux-kernel, trivial

On Sat, 27 Aug 2011 18:58:34 +0200 (CEST)
Jesper Juhl <jj@chaosbits.net> wrote:

> In cleanup_volume_info_contents() we kfree(volume_info->UNC); and then 
> proceed to use that variable on the very next line.
> This causes (at least) Coverity Prevent to complain about use-after-free 
> of that variable (and I guess other checkers may do that as well).
> There's not any /real/ problem here since we are just using the value of 
> the pointer, not actually dereferencing it, but it's still trivial to 
> silence the tool, so why not?
> To me at least it also just seems nicer to defer freeing the variable 
> until we are entirely done with it in all respects.
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
>  fs/cifs/connect.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 633c246..9bb4b10 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -2877,9 +2877,9 @@ cleanup_volume_info_contents(struct smb_vol *volume_info)
>  {
>  	kfree(volume_info->username);
>  	kzfree(volume_info->password);
> -	kfree(volume_info->UNC);
>  	if (volume_info->UNCip != volume_info->UNC + 2)
>  		kfree(volume_info->UNCip);
> +	kfree(volume_info->UNC);
>  	kfree(volume_info->domainname);
>  	kfree(volume_info->iocharset);
>  	kfree(volume_info->prepath);

Seems reasonable for silencing the checker...

Reviewed-by: Jeff Layton <jlayton@redhat.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-29 15:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-27 16:58 [PATCH][Trivial] CIFS: Don't free volume_info->UNC until we are entirely done with it Jesper Juhl
2011-08-27 16:58 ` Jesper Juhl
     [not found] ` <alpine.LNX.2.00.1108271851470.27813-h2p7t3/P30RzeRGmFJ5qR7ZzlVVXadcDXqFh9Ls21Oc@public.gmane.org>
2011-08-29 15:40   ` Jeff Layton
2011-08-29 15:40     ` Jeff Layton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.