* [PATCH] autoconf: fix help message for --enable-cifsidmap
@ 2011-08-23 13:03 Jeff Layton
[not found] ` <1314104603-3941-1-git-send-email-jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Layton @ 2011-08-23 13:03 UTC (permalink / raw)
To: linux-cifs-u79uwXL29TY76Z2rM5mHXA
Cc: pipping-N9AOi2cAC9ZBDgjK7y7TUQ, shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w
It currently says "no" is the default, but it should be "yes".
Reported-by: Elias Pipping <pipping-N9AOi2cAC9ZBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
---
configure.ac | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 780abe7..6a9ad75 100644
--- a/configure.ac
+++ b/configure.ac
@@ -24,7 +24,7 @@ AC_ARG_ENABLE(cifscreds,
AC_ARG_ENABLE(cifsidmap,
[AC_HELP_STRING([--enable-cifsidmap],
- [Create cifs.idmap binary @<:@default=no@:>@])],
+ [Create cifs.idmap binary @<:@default=yes@:>@])],
enable_cifsidmap=$enableval,
enable_cifsidmap="maybe")
--
1.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] autoconf: fix help message for --enable-cifsidmap
[not found] ` <1314104603-3941-1-git-send-email-jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
@ 2011-08-23 16:21 ` Luk Claes
[not found] ` <20110823182106.163416ro6niegbci-e9H6qYbevPUmCttN7JqJIg@public.gmane.org>
2011-08-29 16:50 ` Jeff Layton
1 sibling, 1 reply; 5+ messages in thread
From: Luk Claes @ 2011-08-23 16:21 UTC (permalink / raw)
To: Jeff Layton
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA,
pipping-N9AOi2cAC9ZBDgjK7y7TUQ,
shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w
Hi Jeff
Hmm, I thought it's auto as default which would only be yes if the
needed headers and libraries are installed?
Cheers
Luk
Quoting "Jeff Layton" <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>:
> It currently says "no" is the default, but it should be "yes".
>
> Reported-by: Elias Pipping <pipping-N9AOi2cAC9ZBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> ---
> configure.ac | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 780abe7..6a9ad75 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -24,7 +24,7 @@ AC_ARG_ENABLE(cifscreds,
>
> AC_ARG_ENABLE(cifsidmap,
> [AC_HELP_STRING([--enable-cifsidmap],
> - [Create cifs.idmap binary @<:@default=no@:>@])],
> + [Create cifs.idmap binary @<:@default=yes@:>@])],
> enable_cifsidmap=$enableval,
> enable_cifsidmap="maybe")
>
> --
> 1.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
Luk Claes e-mail: Luk.Claes-Uy3+E7BMiTU@public.gmane.org
Directie ICT Afdeling ICT-Infrastructuur Groep Systemen
Universiteit Gent tel: +32 9 264 96 35 fax: +32 9 264 4994
Krijgslaan 281, gebouw S9, 9000 Gent, Belgie www.UGent.be
-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] autoconf: fix help message for --enable-cifsidmap
[not found] ` <20110823182106.163416ro6niegbci-e9H6qYbevPUmCttN7JqJIg@public.gmane.org>
@ 2011-08-23 16:38 ` Shirish Pargaonkar
2011-08-23 16:41 ` Jeff Layton
1 sibling, 0 replies; 5+ messages in thread
From: Shirish Pargaonkar @ 2011-08-23 16:38 UTC (permalink / raw)
To: Luk Claes
Cc: Jeff Layton, linux-cifs-u79uwXL29TY76Z2rM5mHXA,
pipping-N9AOi2cAC9ZBDgjK7y7TUQ
On Tue, Aug 23, 2011 at 11:21 AM, Luk Claes <Luk.Claes-Cru1EgDzd7c@public.gmane.org> wrote:
> Hi Jeff
>
> Hmm, I thought it's auto as default which would only be yes if the needed
> headers and libraries are installed?
>
> Cheers
>
> Luk
>
> Quoting "Jeff Layton" <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>:
>
>> It currently says "no" is the default, but it should be "yes".
>>
>> Reported-by: Elias Pipping <pipping-N9AOi2cAC9ZBDgjK7y7TUQ@public.gmane.org>
>> Signed-off-by: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
>> ---
>> configure.ac | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 780abe7..6a9ad75 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -24,7 +24,7 @@ AC_ARG_ENABLE(cifscreds,
>>
>> AC_ARG_ENABLE(cifsidmap,
>> [AC_HELP_STRING([--enable-cifsidmap],
>> - [Create cifs.idmap binary @<:@default=no@:>@])],
>> + [Create cifs.idmap binary @<:@default=yes@:>@])],
>> enable_cifsidmap=$enableval,
>> enable_cifsidmap="maybe")
>>
>> --
>> 1.7.6
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
>
> -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
> Luk Claes e-mail: Luk.Claes-Uy3+E7BMiTU@public.gmane.org
> Directie ICT Afdeling ICT-Infrastructuur Groep Systemen
> Universiteit Gent tel: +32 9 264 96 35 fax: +32 9 264 4994
> Krijgslaan 281, gebouw S9, 9000 Gent, Belgie www.UGent.be
> -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>
>
I think yes would also mean auto (automatic) because you build
cifs.idmap automatically if this configure option is not specified?
That is the default and that is what configure --help is telling!
Regards,
Shirish
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] autoconf: fix help message for --enable-cifsidmap
[not found] ` <20110823182106.163416ro6niegbci-e9H6qYbevPUmCttN7JqJIg@public.gmane.org>
2011-08-23 16:38 ` Shirish Pargaonkar
@ 2011-08-23 16:41 ` Jeff Layton
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Layton @ 2011-08-23 16:41 UTC (permalink / raw)
To: Luk Claes
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA,
pipping-N9AOi2cAC9ZBDgjK7y7TUQ,
shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w
On Tue, 23 Aug 2011 18:21:06 +0200
"Luk Claes" <Luk.Claes-Uy3+E7BMiTU@public.gmane.org> wrote:
> Hi Jeff
>
> Hmm, I thought it's auto as default which would only be yes if the
> needed headers and libraries are installed?
>
> Cheers
>
> Luk
>
Point of semantics I guess :)
I figured the default was "yes", but if the necessary stuff wasn't
present then it would be autodisabled. That's how cifs.upcall works
too. If "default=auto" is more illustrative of this situation then I'll
respin the patch and fix the cifs.upcall help text too.
> Quoting "Jeff Layton" <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>:
>
> > It currently says "no" is the default, but it should be "yes".
> >
> > Reported-by: Elias Pipping <pipping-N9AOi2cAC9ZBDgjK7y7TUQ@public.gmane.org>
> > Signed-off-by: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> > ---
> > configure.ac | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 780abe7..6a9ad75 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -24,7 +24,7 @@ AC_ARG_ENABLE(cifscreds,
> >
> > AC_ARG_ENABLE(cifsidmap,
> > [AC_HELP_STRING([--enable-cifsidmap],
> > - [Create cifs.idmap binary @<:@default=no@:>@])],
> > + [Create cifs.idmap binary @<:@default=yes@:>@])],
> > enable_cifsidmap=$enableval,
> > enable_cifsidmap="maybe")
> >
> > --
> > 1.7.6
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
>
>
> -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
> Luk Claes e-mail: Luk.Claes-Uy3+E7BMiTU@public.gmane.org
> Directie ICT Afdeling ICT-Infrastructuur Groep Systemen
> Universiteit Gent tel: +32 9 264 96 35 fax: +32 9 264 4994
> Krijgslaan 281, gebouw S9, 9000 Gent, Belgie www.UGent.be
> -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] autoconf: fix help message for --enable-cifsidmap
[not found] ` <1314104603-3941-1-git-send-email-jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
2011-08-23 16:21 ` Luk Claes
@ 2011-08-29 16:50 ` Jeff Layton
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Layton @ 2011-08-29 16:50 UTC (permalink / raw)
To: Jeff Layton
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA,
pipping-N9AOi2cAC9ZBDgjK7y7TUQ,
shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w
On Tue, 23 Aug 2011 09:03:23 -0400
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote:
> It currently says "no" is the default, but it should be "yes".
>
> Reported-by: Elias Pipping <pipping-N9AOi2cAC9ZBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> ---
> configure.ac | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 780abe7..6a9ad75 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -24,7 +24,7 @@ AC_ARG_ENABLE(cifscreds,
>
> AC_ARG_ENABLE(cifsidmap,
> [AC_HELP_STRING([--enable-cifsidmap],
> - [Create cifs.idmap binary @<:@default=no@:>@])],
> + [Create cifs.idmap binary @<:@default=yes@:>@])],
> enable_cifsidmap=$enableval,
> enable_cifsidmap="maybe")
>
committed...
--
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-29 16:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-23 13:03 [PATCH] autoconf: fix help message for --enable-cifsidmap Jeff Layton
[not found] ` <1314104603-3941-1-git-send-email-jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
2011-08-23 16:21 ` Luk Claes
[not found] ` <20110823182106.163416ro6niegbci-e9H6qYbevPUmCttN7JqJIg@public.gmane.org>
2011-08-23 16:38 ` Shirish Pargaonkar
2011-08-23 16:41 ` Jeff Layton
2011-08-29 16:50 ` Jeff Layton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.