* [PATCH v2] ARM: ux500: send cpufreq notification for all cpus
@ 2011-08-25 6:31 ` Vincent Guittot
0 siblings, 0 replies; 6+ messages in thread
From: Vincent Guittot @ 2011-08-25 6:31 UTC (permalink / raw)
To: linux-arm-kernel
The same clock is used for all cpus so we must notify the frequency change
for each one in order to update the configuration of all twd clockevents.
change since V1:
* use policy->cpus instead of cpu_online_mask
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
drivers/cpufreq/db8500-cpufreq.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/db8500-cpufreq.c b/drivers/cpufreq/db8500-cpufreq.c
index 0d8dd1c..b893f9b 100644
--- a/drivers/cpufreq/db8500-cpufreq.c
+++ b/drivers/cpufreq/db8500-cpufreq.c
@@ -76,13 +76,13 @@ static int db8500_cpufreq_target(struct cpufreq_policy *policy,
freqs.old = policy->cur;
freqs.new = freq_table[idx].frequency;
- freqs.cpu = policy->cpu;
if (freqs.old == freqs.new)
return 0;
/* pre-change notification */
- cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE);
+ for_each_cpu(freqs.cpu, policy->cpus)
+ cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE);
/* request the PRCM unit for opp change */
if (prcmu_set_arm_opp(idx2opp[idx])) {
@@ -91,7 +91,8 @@ static int db8500_cpufreq_target(struct cpufreq_policy *policy,
}
/* post change notification */
- cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE);
+ for_each_cpu(freqs.cpu, policy->cpus)
+ cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE);
return 0;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: ux500: send cpufreq notification for all cpus
@ 2011-08-25 6:31 ` Vincent Guittot
0 siblings, 0 replies; 6+ messages in thread
From: Vincent Guittot @ 2011-08-25 6:31 UTC (permalink / raw)
To: linus.walleij, cpufreq, linux-arm-kernel, linaro-dev
Cc: Vincent Guittot, patches
The same clock is used for all cpus so we must notify the frequency change
for each one in order to update the configuration of all twd clockevents.
change since V1:
* use policy->cpus instead of cpu_online_mask
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
drivers/cpufreq/db8500-cpufreq.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/db8500-cpufreq.c b/drivers/cpufreq/db8500-cpufreq.c
index 0d8dd1c..b893f9b 100644
--- a/drivers/cpufreq/db8500-cpufreq.c
+++ b/drivers/cpufreq/db8500-cpufreq.c
@@ -76,13 +76,13 @@ static int db8500_cpufreq_target(struct cpufreq_policy *policy,
freqs.old = policy->cur;
freqs.new = freq_table[idx].frequency;
- freqs.cpu = policy->cpu;
if (freqs.old == freqs.new)
return 0;
/* pre-change notification */
- cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE);
+ for_each_cpu(freqs.cpu, policy->cpus)
+ cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE);
/* request the PRCM unit for opp change */
if (prcmu_set_arm_opp(idx2opp[idx])) {
@@ -91,7 +91,8 @@ static int db8500_cpufreq_target(struct cpufreq_policy *policy,
}
/* post change notification */
- cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE);
+ for_each_cpu(freqs.cpu, policy->cpus)
+ cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE);
return 0;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: ux500: send cpufreq notification for all cpus
2011-08-25 6:31 ` Vincent Guittot
@ 2011-08-29 9:44 ` Linus Walleij
-1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2011-08-29 9:44 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 25, 2011 at 8:31 AM, Vincent Guittot
<vincent.guittot@linaro.org> wrote:
> The same clock is used for all cpus so we must notify the frequency change
> for each one in order to update the configuration of all twd clockevents.
>
> change since V1:
> * use policy->cpus instead of cpu_online_mask
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Dave, are you picking this up?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ARM: ux500: send cpufreq notification for all cpus
@ 2011-08-29 9:44 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2011-08-29 9:44 UTC (permalink / raw)
To: Vincent Guittot, Dave Jones
Cc: cpufreq, linux-arm-kernel, linaro-dev, patches
On Thu, Aug 25, 2011 at 8:31 AM, Vincent Guittot
<vincent.guittot@linaro.org> wrote:
> The same clock is used for all cpus so we must notify the frequency change
> for each one in order to update the configuration of all twd clockevents.
>
> change since V1:
> * use policy->cpus instead of cpu_online_mask
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Dave, are you picking this up?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: ux500: send cpufreq notification for all cpus
2011-08-29 9:44 ` Linus Walleij
@ 2011-08-29 15:28 ` Dave Jones
-1 siblings, 0 replies; 6+ messages in thread
From: Dave Jones @ 2011-08-29 15:28 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 29, 2011 at 11:44:31AM +0200, Linus Walleij wrote:
> On Thu, Aug 25, 2011 at 8:31 AM, Vincent Guittot
> <vincent.guittot@linaro.org> wrote:
>
> > The same clock is used for all cpus so we must notify the frequency change
> > for each one in order to update the configuration of all twd clockevents.
> >
> > change since V1:
> > * use policy->cpus instead of cpu_online_mask
> >
> > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Dave, are you picking this up?
yeah, I have it queued. I'll get to it today.
thanks,
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ARM: ux500: send cpufreq notification for all cpus
@ 2011-08-29 15:28 ` Dave Jones
0 siblings, 0 replies; 6+ messages in thread
From: Dave Jones @ 2011-08-29 15:28 UTC (permalink / raw)
To: Linus Walleij
Cc: Vincent Guittot, cpufreq, linux-arm-kernel, linaro-dev, patches
On Mon, Aug 29, 2011 at 11:44:31AM +0200, Linus Walleij wrote:
> On Thu, Aug 25, 2011 at 8:31 AM, Vincent Guittot
> <vincent.guittot@linaro.org> wrote:
>
> > The same clock is used for all cpus so we must notify the frequency change
> > for each one in order to update the configuration of all twd clockevents.
> >
> > change since V1:
> > * use policy->cpus instead of cpu_online_mask
> >
> > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Dave, are you picking this up?
yeah, I have it queued. I'll get to it today.
thanks,
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-08-29 15:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-25 6:31 [PATCH v2] ARM: ux500: send cpufreq notification for all cpus Vincent Guittot
2011-08-25 6:31 ` Vincent Guittot
2011-08-29 9:44 ` Linus Walleij
2011-08-29 9:44 ` Linus Walleij
2011-08-29 15:28 ` Dave Jones
2011-08-29 15:28 ` Dave Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.