All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] s5p-mmc: Fix ambiguous setting of data transfer width
Date: Thu, 01 Sep 2011 07:51:05 +0200	[thread overview]
Message-ID: <20110901055105.E1847166C886@gemini.denx.de> (raw)
In-Reply-To: <CALrBrZ3H+k8bu-1OwF5C5BNHuphj_J8jXXV2xgu6jPO5gmJELg@mail.gmail.com>

Dear Minkyu Kang,

In message <CALrBrZ3H+k8bu-1OwF5C5BNHuphj_J8jXXV2xgu6jPO5gmJELg@mail.gmail.com> you wrote:
> 
> > I know these were like this before, but those numbers are awfully
> > magical. You should really define constants for them.
> 
> We decided to use comments instead of defines.

And now we ask you to fix this, because we don;t want such magic
constants.  So please go on and change this.

Thanks.

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
About the use of language: it is impossible to sharpen a pencil  with
a  blunt  ax.  It is equally vain to try to do it with ten blunt axes
instead.                                           -- Edsger Dijkstra

  reply	other threads:[~2011-09-01  5:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30 10:55 [U-Boot] [PATCH] s5p-mmc: Fix ambiguous setting of data transfer width Chander Kashyap
2011-08-31  8:33 ` Jaehoon Chung
2011-09-01  1:23 ` Andy Fleming
2011-09-01  2:26   ` Minkyu Kang
2011-09-01  5:51     ` Wolfgang Denk [this message]
2011-09-02  8:09       ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110901055105.E1847166C886@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.