All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ath6kl: Do not enable Probe Request reporting by default
@ 2011-09-01  8:33 Jouni Malinen
  2011-09-01  9:19 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Jouni Malinen @ 2011-09-01  8:33 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless

Probe Request reporting will be needed for P2P and WPS, but some
firmware builds do not seem to like this when P2P is not enabled.
Since we do not yet enable P2P, the safest option here is to just
remove this call for now and bring it back as a more dynamic version
once ath6kl starts advertising support for P2P.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath6kl/init.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
index f348357..96953be 100644
--- a/drivers/net/wireless/ath/ath6kl/init.c
+++ b/drivers/net/wireless/ath/ath6kl/init.c
@@ -473,13 +473,6 @@ static int ath6kl_target_config_wlan_params(struct ath6kl *ar)
 			   ret);
 	}
 
-	/* Enable Probe Request reporting for P2P */
-	ret = ath6kl_wmi_probe_report_req_cmd(ar->wmi, true);
-	if (ret) {
-		ath6kl_dbg(ATH6KL_DBG_TRC, "failed to enable Probe Request "
-			   "reporting (%d)\n", ret);
-	}
-
 	return status;
 }
 
-- 
1.7.4.1


-- 
Jouni Malinen                                            PGP id EFC895FA

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ath6kl: Do not enable Probe Request reporting by default
  2011-09-01  8:33 [PATCH] ath6kl: Do not enable Probe Request reporting by default Jouni Malinen
@ 2011-09-01  9:19 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2011-09-01  9:19 UTC (permalink / raw)
  To: Jouni Malinen; +Cc: linux-wireless

On 09/01/2011 11:33 AM, Jouni Malinen wrote:
> Probe Request reporting will be needed for P2P and WPS, but some
> firmware builds do not seem to like this when P2P is not enabled.
> Since we do not yet enable P2P, the safest option here is to just
> remove this call for now and bring it back as a more dynamic version
> once ath6kl starts advertising support for P2P.

Thanks, applied to my local ath6kl.git.

Kalle

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-09-01  9:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-01  8:33 [PATCH] ath6kl: Do not enable Probe Request reporting by default Jouni Malinen
2011-09-01  9:19 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.