From: "John W. Linville" <linville@tuxdriver.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Jim Gettys <jg@freedesktop.org>,
Andrew McGregor <andrewmcgr@gmail.com>,
Adrian Chadd <adrian@freebsd.org>,
Tom Herbert <therbert@google.com>,
Dave Taht <dave.taht@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Matt Smith <smithm@qca.qualcomm.com>,
Kevin Hayes <hayes@qca.qualcomm.com>,
Derek Smithies <derek@indranet.co.nz>,
netdev@vger.kernel.org
Subject: Re: BQL crap and wireless
Date: Thu, 1 Sep 2011 10:13:05 -0400 [thread overview]
Message-ID: <20110901141304.GA2580@tuxdriver.com> (raw)
In-Reply-To: <CAB=NE6Wj4BxSjZmTOg9EFMcJ+H0RBZE4q8+6DB3x8qP=r42yNQ@mail.gmail.com>
On Wed, Aug 31, 2011 at 01:50:48PM -0700, Luis R. Rodriguez wrote:
> On Wed, Aug 31, 2011 at 6:28 AM, Jim Gettys <jg@freedesktop.org> wrote:
> > such as wireless, or even possibly modern broadband with
> > PowerBoost, classic RED or similar algorithms that do not take the
> > buffer drain rate cannot possibly hack it properly.
>
> Understood, just curious if anyone has tried a Minstrel approach.
FWIW, eBDP and the related algorithms from Tianji Li's paper are
philosophically similar to minstrel. They depend on measuring recent
conditions and modifying the current queue length accordingly.
http://www.hamilton.ie/tianji_li/buffersizing.pdf
The hack I added in debloat-testing is based on my understanding
of eBDP. It timestamps the SKBs when they are handed to the driver
for Tx and then checks the timestamp when the SKB is orphaned. It is
a bit crude and is an abuse of the skb_orphan API. Also while it
accounts for the 802.11e queues separately, it doesn't account for
802.11n aggregation. Still, it seems to improve latency w/o hugely
impacting throughput in at least some environments -- YMMV!
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: "Luis R. Rodriguez" <mcgrof-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jim Gettys <jg-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org>,
Andrew McGregor
<andrewmcgr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Adrian Chadd <adrian-h+KGxgPPiopAfugRpC6u6w@public.gmane.org>,
Tom Herbert <therbert-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Dave Taht <dave.taht-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-wireless
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Matt Smith <smithm-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>,
Kevin Hayes <hayes-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>,
Derek Smithies <derek-Rd3uoDiDeHXJKwlM9GxbOw@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: BQL crap and wireless
Date: Thu, 1 Sep 2011 10:13:05 -0400 [thread overview]
Message-ID: <20110901141304.GA2580@tuxdriver.com> (raw)
In-Reply-To: <CAB=NE6Wj4BxSjZmTOg9EFMcJ+H0RBZE4q8+6DB3x8qP=r42yNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, Aug 31, 2011 at 01:50:48PM -0700, Luis R. Rodriguez wrote:
> On Wed, Aug 31, 2011 at 6:28 AM, Jim Gettys <jg-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org> wrote:
> > such as wireless, or even possibly modern broadband with
> > PowerBoost, classic RED or similar algorithms that do not take the
> > buffer drain rate cannot possibly hack it properly.
>
> Understood, just curious if anyone has tried a Minstrel approach.
FWIW, eBDP and the related algorithms from Tianji Li's paper are
philosophically similar to minstrel. They depend on measuring recent
conditions and modifying the current queue length accordingly.
http://www.hamilton.ie/tianji_li/buffersizing.pdf
The hack I added in debloat-testing is based on my understanding
of eBDP. It timestamps the SKBs when they are handed to the driver
for Tx and then checks the timestamp when the SKB is orphaned. It is
a bit crude and is an abuse of the skb_orphan API. Also while it
accounts for the 802.11e queues separately, it doesn't account for
802.11n aggregation. Still, it seems to improve latency w/o hugely
impacting throughput in at least some environments -- YMMV!
John
--
John W. Linville Someday the world will need a hero, and you
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-09-01 14:15 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 23:27 BQL crap and wireless Luis R. Rodriguez
2011-08-26 23:27 ` Luis R. Rodriguez
2011-08-29 21:02 ` Luis R. Rodriguez
2011-08-29 21:02 ` Luis R. Rodriguez
2011-08-29 21:10 ` Luis R. Rodriguez
2011-08-29 22:45 ` Dave Taht
2011-08-29 22:54 ` Luis R. Rodriguez
2011-08-29 22:54 ` Luis R. Rodriguez
2011-08-29 23:10 ` Dave Taht
2011-08-29 23:10 ` Dave Taht
2011-08-29 23:15 ` Luis R. Rodriguez
2011-08-29 23:18 ` Andrew McGregor
2011-08-29 23:18 ` Andrew McGregor
2011-08-30 0:24 ` Dave Taht
2011-08-30 1:22 ` Jim Gettys
2011-08-30 1:22 ` Jim Gettys
2011-08-30 1:44 ` Adrian Chadd
2011-08-30 1:48 ` Adrian Chadd
2011-08-30 1:59 ` Andrew McGregor
2011-08-30 1:59 ` Andrew McGregor
2011-08-30 2:12 ` Jim Gettys
2011-08-30 3:34 ` Tom Herbert
2011-08-30 3:42 ` Adrian Chadd
2011-08-30 3:42 ` Adrian Chadd
2011-08-30 4:23 ` Andrew McGregor
2011-08-30 4:23 ` Andrew McGregor
2011-08-30 13:58 ` Jim Gettys
2011-08-30 13:58 ` Jim Gettys
2011-08-30 21:47 ` Andrew McGregor
2011-08-30 21:47 ` Andrew McGregor
2011-08-31 13:28 ` Jim Gettys
2011-08-31 20:50 ` Luis R. Rodriguez
2011-08-31 20:50 ` Luis R. Rodriguez
2011-09-01 2:44 ` Adrian Chadd
2011-09-01 14:13 ` John W. Linville [this message]
2011-09-01 14:13 ` John W. Linville
2011-09-01 15:08 ` Jim Gettys
2011-09-01 15:08 ` Jim Gettys
2011-09-02 22:03 ` Luis R. Rodriguez
2011-09-02 22:03 ` Luis R. Rodriguez
[not found] ` <4E5FA74D.5000705@freedesktop.org>
2011-09-02 21:59 ` Luis R. Rodriguez
2011-09-02 21:59 ` Luis R. Rodriguez
2011-09-03 3:01 ` Jim Gettys
2011-09-03 3:01 ` Jim Gettys
2011-08-30 1:08 ` Dave Taht
2011-08-30 1:08 ` Dave Taht
2011-08-31 19:48 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110901141304.GA2580@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=adrian@freebsd.org \
--cc=andrewmcgr@gmail.com \
--cc=dave.taht@gmail.com \
--cc=derek@indranet.co.nz \
--cc=hayes@qca.qualcomm.com \
--cc=jg@freedesktop.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=smithm@qca.qualcomm.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.