[PATCH] i2c: remove deprecated callbacks

[PATCH] i2c: remove deprecated callbacks

[WANG Cong]

i2c_driver.attach_adapter and i2c_driver.detach_adapter are deprecated
and scheduled to be removed in Sep 2011.

Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

---
diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index c4a6e14..89a9695 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -486,15 +486,6 @@ Files:	include/linux/netfilter_ipv4/ipt_addrtype.h
 
 ----------------------------
 
-What:	i2c_driver.attach_adapter
-	i2c_driver.detach_adapter
-When:	September 2011
-Why:	These legacy callbacks should no longer be used as i2c-core offers
-	a variety of preferable alternative ways to instantiate I2C devices.
-Who:	Jean Delvare <khali@linux-fr.org>
-
-----------------------------
-
 What:	Support for UVCIOC_CTRL_ADD in the uvcvideo driver
 When:	3.2
 Why:	The information passed to the driver by this ioctl is now queried
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 131079a..c833c53 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -44,8 +44,8 @@
 
 
 /* core_lock protects i2c_adapter_idr, and guarantees
-   that device detection, deletion of detected devices, and attach_adapter
-   and detach_adapter calls are serialized */
+   that device detection, deletion of detected devices
+   calls are serialized */
 static DEFINE_MUTEX(core_lock);
 static DEFINE_IDR(i2c_adapter_idr);
 
@@ -795,15 +795,6 @@ static int i2c_do_add_adapter(struct i2c_driver *driver,
 	/* Detect supported devices on that bus, and instantiate them */
 	i2c_detect(adap, driver);
 
-	/* Let legacy drivers scan this bus for matching devices */
-	if (driver->attach_adapter) {
-		dev_warn(&adap->dev, "%s: attach_adapter method is deprecated\n",
-			 driver->driver.name);
-		dev_warn(&adap->dev, "Please use another way to instantiate "
-			 "your i2c_client\n");
-		/* We ignore the return code; if it fails, too bad */
-		driver->attach_adapter(adap);
-	}
 	return 0;
 }
 
@@ -975,7 +966,6 @@ static int i2c_do_del_adapter(struct i2c_driver *driver,
 			      struct i2c_adapter *adapter)
 {
 	struct i2c_client *client, *_n;
-	int res;
 
 	/* Remove the devices we created ourselves as the result of hardware
 	 * probing (using a driver's detect method) */
@@ -988,15 +978,7 @@ static int i2c_do_del_adapter(struct i2c_driver *driver,
 		}
 	}
 
-	if (!driver->detach_adapter)
-		return 0;
-	dev_warn(&adapter->dev, "%s: detach_adapter method is deprecated\n",
-		 driver->driver.name);
-	res = driver->detach_adapter(adapter);
-	if (res)
-		dev_err(&adapter->dev, "detach_adapter failed (%d) "
-			"for driver [%s]\n", res, driver->driver.name);
-	return res;
+	return 0;
 }
 
 static int __unregister_client(struct device *dev, void *dummy)
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index a6c652e..25c2c87 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -142,13 +142,6 @@ extern s32 i2c_smbus_write_i2c_block_data(const struct i2c_client *client,
 struct i2c_driver {
 	unsigned int class;
 
-	/* Notifies the driver that a new bus has appeared or is about to be
-	 * removed. You should avoid using this, it will be removed in a
-	 * near future.
-	 */
-	int (*attach_adapter)(struct i2c_adapter *) __deprecated;
-	int (*detach_adapter)(struct i2c_adapter *) __deprecated;
-
 	/* Standard driver model interfaces */
 	int (*probe)(struct i2c_client *, const struct i2c_device_id *);
 	int (*remove)(struct i2c_client *);

[PATCH] i2c: remove deprecated callbacks

[WANG Cong]

i2c_driver.attach_adapter and i2c_driver.detach_adapter are deprecated
and scheduled to be removed in Sep 2011.

Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Signed-off-by: WANG Cong <xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

---
diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index c4a6e14..89a9695 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -486,15 +486,6 @@ Files:	include/linux/netfilter_ipv4/ipt_addrtype.h
 
 ----------------------------
 
-What:	i2c_driver.attach_adapter
-	i2c_driver.detach_adapter
-When:	September 2011
-Why:	These legacy callbacks should no longer be used as i2c-core offers
-	a variety of preferable alternative ways to instantiate I2C devices.
-Who:	Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
-
-----------------------------
-
 What:	Support for UVCIOC_CTRL_ADD in the uvcvideo driver
 When:	3.2
 Why:	The information passed to the driver by this ioctl is now queried
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 131079a..c833c53 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -44,8 +44,8 @@
 
 
 /* core_lock protects i2c_adapter_idr, and guarantees
-   that device detection, deletion of detected devices, and attach_adapter
-   and detach_adapter calls are serialized */
+   that device detection, deletion of detected devices
+   calls are serialized */
 static DEFINE_MUTEX(core_lock);
 static DEFINE_IDR(i2c_adapter_idr);
 
@@ -795,15 +795,6 @@ static int i2c_do_add_adapter(struct i2c_driver *driver,
 	/* Detect supported devices on that bus, and instantiate them */
 	i2c_detect(adap, driver);
 
-	/* Let legacy drivers scan this bus for matching devices */
-	if (driver->attach_adapter) {
-		dev_warn(&adap->dev, "%s: attach_adapter method is deprecated\n",
-			 driver->driver.name);
-		dev_warn(&adap->dev, "Please use another way to instantiate "
-			 "your i2c_client\n");
-		/* We ignore the return code; if it fails, too bad */
-		driver->attach_adapter(adap);
-	}
 	return 0;
 }
 
@@ -975,7 +966,6 @@ static int i2c_do_del_adapter(struct i2c_driver *driver,
 			      struct i2c_adapter *adapter)
 {
 	struct i2c_client *client, *_n;
-	int res;
 
 	/* Remove the devices we created ourselves as the result of hardware
 	 * probing (using a driver's detect method) */
@@ -988,15 +978,7 @@ static int i2c_do_del_adapter(struct i2c_driver *driver,
 		}
 	}
 
-	if (!driver->detach_adapter)
-		return 0;
-	dev_warn(&adapter->dev, "%s: detach_adapter method is deprecated\n",
-		 driver->driver.name);
-	res = driver->detach_adapter(adapter);
-	if (res)
-		dev_err(&adapter->dev, "detach_adapter failed (%d) "
-			"for driver [%s]\n", res, driver->driver.name);
-	return res;
+	return 0;
 }
 
 static int __unregister_client(struct device *dev, void *dummy)
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index a6c652e..25c2c87 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -142,13 +142,6 @@ extern s32 i2c_smbus_write_i2c_block_data(const struct i2c_client *client,
 struct i2c_driver {
 	unsigned int class;
 
-	/* Notifies the driver that a new bus has appeared or is about to be
-	 * removed. You should avoid using this, it will be removed in a
-	 * near future.
-	 */
-	int (*attach_adapter)(struct i2c_adapter *) __deprecated;
-	int (*detach_adapter)(struct i2c_adapter *) __deprecated;
-
 	/* Standard driver model interfaces */
 	int (*probe)(struct i2c_client *, const struct i2c_device_id *);
 	int (*remove)(struct i2c_client *);

Re: [PATCH] i2c: remove deprecated callbacks

[Jean Delvare]

Hi Cong,

On Thu,  1 Sep 2011 12:40:27 +0800, WANG Cong wrote:
> i2c_driver.attach_adapter and i2c_driver.detach_adapter are deprecated
> and scheduled to be removed in Sep 2011.
> 
> Cc: Jean Delvare <khali@linux-fr.org>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

I'm not sure what you are trying to achieve here.

I am obviously aware of these functions being deprecated, I am the one
who added the entry in feature-removal-schedule.txt. And as a matter of
fact, I have a patch ready for months now.

I could understand you sending a patch if the entry had expired long
ago, but this isn't the case: it is marked for September 2011 and you
send a patch on September 1st. Hardly a coincidence. While there
certainly is a benefit in people reading feature-removal-schedule.txt
and trying to clean it up by closing old (presumably forgotten)
entries, this doesn't apply here.

Furthermore, you didn't even check if the deprecated callbacks were
still in use. It turns out that there are 9 drivers still using one of
them (6 macintosh drivers and 3 sound drivers) so plain removing it
will cause build breakages. We obviously don't want to do that, so I am
not going to apply your patch (nor mine) for now.

I know that Benjamin Herrenschmidt is working on converting (some of)
the macintosh drivers. I don't have any news for some time though. Ben,
are you done with the conversion by now? It would be great to get it
merged in kernel 3.2.

Cong, do you have a specific interest in these callbacks being removed?

If you want to help, then instead of sending a patch which I already
have and virtually everybody could have written, please get the
remaining 3 drivers converted to the current i2c binding model:
  sound/ppc/keywest.c
  sound/aoa/codecs/onyx.c
  sound/aoa/codecs/tas.c
THAT would be helpful. At the moment, it only looks like you are trying
to get your name on a trivial patch, i.e. getting credit for work you
didn't really do.

> 
> ---
> diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
> index c4a6e14..89a9695 100644
> --- a/Documentation/feature-removal-schedule.txt
> +++ b/Documentation/feature-removal-schedule.txt
> @@ -486,15 +486,6 @@ Files:	include/linux/netfilter_ipv4/ipt_addrtype.h
>  
>  ----------------------------
>  
> -What:	i2c_driver.attach_adapter
> -	i2c_driver.detach_adapter
> -When:	September 2011
> -Why:	These legacy callbacks should no longer be used as i2c-core offers
> -	a variety of preferable alternative ways to instantiate I2C devices.
> -Who:	Jean Delvare <khali@linux-fr.org>
> -
> -----------------------------
> -
> (...)

-- 
Jean Delvare

Re: [PATCH] i2c: remove deprecated callbacks

[Américo Wang]

On Thu, Sep 1, 2011 at 4:52 PM, Jean Delvare <khali@linux-fr.org> wrote:
> Hi Cong,
>
> On Thu,  1 Sep 2011 12:40:27 +0800, WANG Cong wrote:
>> i2c_driver.attach_adapter and i2c_driver.detach_adapter are deprecated
>> and scheduled to be removed in Sep 2011.
>>
>> Cc: Jean Delvare <khali@linux-fr.org>
>> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> I'm not sure what you are trying to achieve here.

I just want to make feature-removal-schedule.txt working. :)

>
> I am obviously aware of these functions being deprecated, I am the one
> who added the entry in feature-removal-schedule.txt. And as a matter of
> fact, I have a patch ready for months now.
>
> I could understand you sending a patch if the entry had expired long
> ago, but this isn't the case: it is marked for September 2011 and you
> send a patch on September 1st. Hardly a coincidence. While there
> certainly is a benefit in people reading feature-removal-schedule.txt
> and trying to clean it up by closing old (presumably forgotten)
> entries, this doesn't apply here.
>
> Furthermore, you didn't even check if the deprecated callbacks were
> still in use. It turns out that there are 9 drivers still using one of
> them (6 macintosh drivers and 3 sound drivers) so plain removing it
> will cause build breakages. We obviously don't want to do that, so I am
> not going to apply your patch (nor mine) for now.

Hmm, sorry that I didn't know this, maybe we can defer the removal
of these callbacks?

>
> I know that Benjamin Herrenschmidt is working on converting (some of)
> the macintosh drivers. I don't have any news for some time though. Ben,
> are you done with the conversion by now? It would be great to get it
> merged in kernel 3.2.
>
> Cong, do you have a specific interest in these callbacks being removed?
>
> If you want to help, then instead of sending a patch which I already
> have and virtually everybody could have written, please get the
> remaining 3 drivers converted to the current i2c binding model:
>  sound/ppc/keywest.c
>  sound/aoa/codecs/onyx.c
>  sound/aoa/codecs/tas.c

Sure, if I can... so how do we convert them? Any examples?

Thanks!

Re: [PATCH] i2c: remove deprecated callbacks

[Jean Delvare]

On Thu, 1 Sep 2011 17:12:00 +0800, Américo Wang wrote:
> On Thu, Sep 1, 2011 at 4:52 PM, Jean Delvare <khali@linux-fr.org> wrote:
> > Furthermore, you didn't even check if the deprecated callbacks were
> > still in use. It turns out that there are 9 drivers still using one of
> > them (6 macintosh drivers and 3 sound drivers) so plain removing it
> > will cause build breakages. We obviously don't want to do that, so I am
> > not going to apply your patch (nor mine) for now.
> 
> Hmm, sorry that I didn't know this, maybe we can defer the removal
> of these callbacks?

We have to, obviously. And given that this is 50% of the patch, there's
little point in applying the rest now.

> > (...)
> > If you want to help, then instead of sending a patch which I already
> > have and virtually everybody could have written, please get the
> > remaining 3 drivers converted to the current i2c binding model:
> >  sound/ppc/keywest.c
> >  sound/aoa/codecs/onyx.c
> >  sound/aoa/codecs/tas.c
> 
> Sure, if I can... so how do we convert them? Any examples?

If it was trivial, someone would have done it already... I converted
most drivers a couple years ago, but the remaining ones only run on
systems I don't have and converting them properly would take intimate
knowledge of the systems in question and preferably actual hardware for
testing.

You can read the possible replacements for the current deprecated
implementations:
  Documentation/i2c/instantiating-devices

At the moment I am essentially waiting to see when Ben is headed, as
hopefully the sound drivers can follow the same path. If you want to
help Ben with code review or testing (if you can) this would be great.

-- 
Jean Delvare

Re: [PATCH] i2c: remove deprecated callbacks

[Benjamin Herrenschmidt]

On Thu, 2011-09-01 at 10:52 +0200, Jean Delvare wrote:
> Hi Cong,
> 
> On Thu,  1 Sep 2011 12:40:27 +0800, WANG Cong wrote:
> > i2c_driver.attach_adapter and i2c_driver.detach_adapter are deprecated
> > and scheduled to be removed in Sep 2011.
> > 
> > Cc: Jean Delvare <khali@linux-fr.org>
> > Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
> 
> I'm not sure what you are trying to achieve here.
> 
> I am obviously aware of these functions being deprecated, I am the one
> who added the entry in feature-removal-schedule.txt. And as a matter of
> fact, I have a patch ready for months now.
> 
> I could understand you sending a patch if the entry had expired long
> ago, but this isn't the case: it is marked for September 2011 and you
> send a patch on September 1st. Hardly a coincidence. While there
> certainly is a benefit in people reading feature-removal-schedule.txt
> and trying to clean it up by closing old (presumably forgotten)
> entries, this doesn't apply here.

Unfortunately I'm not finished converting the Mac drivers...

> Furthermore, you didn't even check if the deprecated callbacks were
> still in use. It turns out that there are 9 drivers still using one of
> them (6 macintosh drivers and 3 sound drivers) so plain removing it
> will cause build breakages. We obviously don't want to do that, so I am
> not going to apply your patch (nor mine) for now.
> 
> I know that Benjamin Herrenschmidt is working on converting (some of)
> the macintosh drivers. I don't have any news for some time though. Ben,
> are you done with the conversion by now? It would be great to get it
> merged in kernel 3.2.

I'm just bogged down by too many things, including quite a bit of travel
lately. I have some mostly untested patches converting part of windfarm
(not all of it yet), and therm_adt746x and a patch to add the generic
code to register i2c devices from device-tree properly on powermacs.

I'm missing a couple more drivers & bits of windfarm and therm_pm72
which I'd like to use the opportunity to convert into a windfarm module.

Then there's some sound drivers etc...

I am travelling again tomorrow for 2 weeks, and after that a month in
europe, tho I'll have 10 days in the middle where I _might_ be able to
make progress on that. Else it will have to wait for november.
 
> Cong, do you have a specific interest in these callbacks being removed?
> 
> If you want to help, then instead of sending a patch which I already
> have and virtually everybody could have written, please get the
> remaining 3 drivers converted to the current i2c binding model:
>   sound/ppc/keywest.c
>   sound/aoa/codecs/onyx.c
>   sound/aoa/codecs/tas.c
> THAT would be helpful. At the moment, it only looks like you are trying
> to get your name on a trivial patch, i.e. getting credit for work you
> didn't really do.

Cheers,
Ben.

> > 
> > ---
> > diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
> > index c4a6e14..89a9695 100644
> > --- a/Documentation/feature-removal-schedule.txt
> > +++ b/Documentation/feature-removal-schedule.txt
> > @@ -486,15 +486,6 @@ Files:	include/linux/netfilter_ipv4/ipt_addrtype.h
> >  
> >  ----------------------------
> >  
> > -What:	i2c_driver.attach_adapter
> > -	i2c_driver.detach_adapter
> > -When:	September 2011
> > -Why:	These legacy callbacks should no longer be used as i2c-core offers
> > -	a variety of preferable alternative ways to instantiate I2C devices.
> > -Who:	Jean Delvare <khali@linux-fr.org>
> > -
> > -----------------------------
> > -
> > (...)
> 

Re: [PATCH] i2c: remove deprecated callbacks

[Benjamin Herrenschmidt]

On Fri, 2011-09-02 at 09:24 +1000, Benjamin Herrenschmidt wrote:


 .../...

> I'm just bogged down by too many things, including quite a bit of travel
> lately. I have some mostly untested patches converting part of windfarm
> (not all of it yet), and therm_adt746x and a patch to add the generic
> code to register i2c devices from device-tree properly on powermacs.
> 
> I'm missing a couple more drivers & bits of windfarm and therm_pm72
> which I'd like to use the opportunity to convert into a windfarm module.

I'll push out my WIP to a branch on powerpc.git on k.org when hera is
back online so those who want can help.

Cheers,
Ben.

> Then there's some sound drivers etc...
> 
> I am travelling again tomorrow for 2 weeks, and after that a month in
> europe, tho I'll have 10 days in the middle where I _might_ be able to
> make progress on that. Else it will have to wait for november.
>  
> > Cong, do you have a specific interest in these callbacks being removed?
> > 
> > If you want to help, then instead of sending a patch which I already
> > have and virtually everybody could have written, please get the
> > remaining 3 drivers converted to the current i2c binding model:
> >   sound/ppc/keywest.c
> >   sound/aoa/codecs/onyx.c
> >   sound/aoa/codecs/tas.c
> > THAT would be helpful. At the moment, it only looks like you are trying
> > to get your name on a trivial patch, i.e. getting credit for work you
> > didn't really do.
> 
> Cheers,
> Ben.
> 
> > > 
> > > ---
> > > diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
> > > index c4a6e14..89a9695 100644
> > > --- a/Documentation/feature-removal-schedule.txt
> > > +++ b/Documentation/feature-removal-schedule.txt
> > > @@ -486,15 +486,6 @@ Files:	include/linux/netfilter_ipv4/ipt_addrtype.h
> > >  
> > >  ----------------------------
> > >  
> > > -What:	i2c_driver.attach_adapter
> > > -	i2c_driver.detach_adapter
> > > -When:	September 2011
> > > -Why:	These legacy callbacks should no longer be used as i2c-core offers
> > > -	a variety of preferable alternative ways to instantiate I2C devices.
> > > -Who:	Jean Delvare <khali@linux-fr.org>
> > > -
> > > -----------------------------
> > > -
> > > (...)
> > 
> 

Re: [PATCH] i2c: remove deprecated callbacks

[Benjamin Herrenschmidt]

On Fri, 2011-09-02 at 09:24 +1000, Benjamin Herrenschmidt wrote:


 .../...

> I'm just bogged down by too many things, including quite a bit of travel
> lately. I have some mostly untested patches converting part of windfarm
> (not all of it yet), and therm_adt746x and a patch to add the generic
> code to register i2c devices from device-tree properly on powermacs.
> 
> I'm missing a couple more drivers & bits of windfarm and therm_pm72
> which I'd like to use the opportunity to convert into a windfarm module.

I'll push out my WIP to a branch on powerpc.git on k.org when hera is
back online so those who want can help.

Cheers,
Ben.

> Then there's some sound drivers etc...
> 
> I am travelling again tomorrow for 2 weeks, and after that a month in
> europe, tho I'll have 10 days in the middle where I _might_ be able to
> make progress on that. Else it will have to wait for november.
>  
> > Cong, do you have a specific interest in these callbacks being removed?
> > 
> > If you want to help, then instead of sending a patch which I already
> > have and virtually everybody could have written, please get the
> > remaining 3 drivers converted to the current i2c binding model:
> >   sound/ppc/keywest.c
> >   sound/aoa/codecs/onyx.c
> >   sound/aoa/codecs/tas.c
> > THAT would be helpful. At the moment, it only looks like you are trying
> > to get your name on a trivial patch, i.e. getting credit for work you
> > didn't really do.
> 
> Cheers,
> Ben.
> 
> > > 
> > > ---
> > > diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
> > > index c4a6e14..89a9695 100644
> > > --- a/Documentation/feature-removal-schedule.txt
> > > +++ b/Documentation/feature-removal-schedule.txt
> > > @@ -486,15 +486,6 @@ Files:	include/linux/netfilter_ipv4/ipt_addrtype.h
> > >  
> > >  ----------------------------
> > >  
> > > -What:	i2c_driver.attach_adapter
> > > -	i2c_driver.detach_adapter
> > > -When:	September 2011
> > > -Why:	These legacy callbacks should no longer be used as i2c-core offers
> > > -	a variety of preferable alternative ways to instantiate I2C devices.
> > > -Who:	Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> > > -
> > > -----------------------------
> > > -
> > > (...)
> > 
> 

Re: [PATCH] i2c: remove deprecated callbacks

[Jean Delvare]

On Fri, 02 Sep 2011 09:24:18 +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2011-09-01 at 10:52 +0200, Jean Delvare wrote:
> > Furthermore, you didn't even check if the deprecated callbacks were
> > still in use. It turns out that there are 9 drivers still using one of
> > them (6 macintosh drivers and 3 sound drivers) so plain removing it
> > will cause build breakages. We obviously don't want to do that, so I am
> > not going to apply your patch (nor mine) for now.
> > 
> > I know that Benjamin Herrenschmidt is working on converting (some of)
> > the macintosh drivers. I don't have any news for some time though. Ben,
> > are you done with the conversion by now? It would be great to get it
> > merged in kernel 3.2.
> 
> I'm just bogged down by too many things, including quite a bit of travel
> lately. I have some mostly untested patches converting part of windfarm
> (not all of it yet), and therm_adt746x and a patch to add the generic
> code to register i2c devices from device-tree properly on powermacs.
> 
> I'm missing a couple more drivers & bits of windfarm and therm_pm72
> which I'd like to use the opportunity to convert into a windfarm module.
> 
> Then there's some sound drivers etc...
> 
> I am travelling again tomorrow for 2 weeks, and after that a month in
> europe, tho I'll have 10 days in the middle where I _might_ be able to
> make progress on that. Else it will have to wait for november.

Thanks for the update, Ben. November is totally fine with me, the i2c
subsystem conversion started 5 years ago or so, we can wait a couple
additional months ;) I definitely prefer that you take the time to do
it properly and we can apply the same for the remaining drivers.

If you want, we may be able to spend half an hour face to face in
Prague in October to check what you've done and if there are blocking
issues remaining.

-- 
Jean Delvare

Re: [PATCH] i2c: remove deprecated callbacks

[Benjamin Herrenschmidt]

On Fri, 2011-09-02 at 08:28 +0200, Jean Delvare wrote:
> Thanks for the update, Ben. November is totally fine with me, the i2c
> subsystem conversion started 5 years ago or so, we can wait a couple
> additional months ;) I definitely prefer that you take the time to do
> it properly and we can apply the same for the remaining drivers.
> 
> If you want, we may be able to spend half an hour face to face in
> Prague in October to check what you've done and if there are blocking
> issues remaining.

Sure, will be good to meet !

Cheers,
Ben.

Re: [PATCH] i2c: remove deprecated callbacks

[Benjamin Herrenschmidt]

On Fri, 2011-09-02 at 08:28 +0200, Jean Delvare wrote:
> Thanks for the update, Ben. November is totally fine with me, the i2c
> subsystem conversion started 5 years ago or so, we can wait a couple
> additional months ;) I definitely prefer that you take the time to do
> it properly and we can apply the same for the remaining drivers.
> 
> If you want, we may be able to spend half an hour face to face in
> Prague in October to check what you've done and if there are blocking
> issues remaining.

Sure, will be good to meet !

Cheers,
Ben.