All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Dave Airlie <airlied@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
	Bernie Thompson <bernie@plugable.com>,
	Martin Decky <martin@decky.cz>
Subject: Re: [PATCH 2/2] vt: dirty hack
Date: Sat, 3 Sep 2011 11:25:42 +0100	[thread overview]
Message-ID: <20110903112542.5d3cbfcc@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1315013361-3191-3-git-send-email-FlorianSchandinat@gmx.de>

On Sat,  3 Sep 2011 01:29:21 +0000
Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:

All of the vt stuff wants doing properly not as hacks.

I think the fundamental change you need is to instroduce some sort of
vc->group pointer and vc group object that holds all the globals in the
vt layer for each group (ie move fg_console, console_blanked etc).

That can be done in steps, and once done you can then start to use
vc->group-> within the fbcon driver and possibly also have a per fb
group data attached to vc->group->fb or similar.

Hacks are fine for early prototyping but doing it right means thinking
about the data structures you ultimately need so that existing systems
work, multi-monitor continues to work and you can do proper multi-console
stuff.

I'm all for it happening done right, and some things like being able to
attach an fb console to arbitary GEM objects would allow very nice
integration of the console into things like Wayland.

Alan

WARNING: multiple messages have this Message-ID (diff)
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Dave Airlie <airlied@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
	Bernie Thompson <bernie@plugable.com>,
	Martin Decky <martin@decky.cz>
Subject: Re: [PATCH 2/2] vt: dirty hack
Date: Sat, 03 Sep 2011 10:25:42 +0000	[thread overview]
Message-ID: <20110903112542.5d3cbfcc@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1315013361-3191-3-git-send-email-FlorianSchandinat@gmx.de>

On Sat,  3 Sep 2011 01:29:21 +0000
Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:

All of the vt stuff wants doing properly not as hacks.

I think the fundamental change you need is to instroduce some sort of
vc->group pointer and vc group object that holds all the globals in the
vt layer for each group (ie move fg_console, console_blanked etc).

That can be done in steps, and once done you can then start to use
vc->group-> within the fbcon driver and possibly also have a per fb
group data attached to vc->group->fb or similar.

Hacks are fine for early prototyping but doing it right means thinking
about the data structures you ultimately need so that existing systems
work, multi-monitor continues to work and you can do proper multi-console
stuff.

I'm all for it happening done right, and some things like being able to
attach an fb console to arbitary GEM objects would allow very nice
integration of the console into things like Wayland.

Alan

  reply	other threads:[~2011-09-03 10:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-03  1:29 [RFC v2] allow multiple concurrent visible displays Florian Tobias Schandinat
2011-09-03  1:29 ` Florian Tobias Schandinat
2011-09-03  1:29 ` [PATCH 1/2] fbdev: allow multiple concurrent visible consoles Florian Tobias Schandinat
2011-09-03  1:29   ` Florian Tobias Schandinat
2011-09-03  1:29 ` [PATCH 2/2] vt: dirty hack Florian Tobias Schandinat
2011-09-03  1:29   ` Florian Tobias Schandinat
2011-09-03 10:25   ` Alan Cox [this message]
2011-09-03 10:25     ` Alan Cox
2011-09-03 16:36     ` Florian Tobias Schandinat
2011-09-03 16:36       ` Florian Tobias Schandinat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110903112542.5d3cbfcc@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=FlorianSchandinat@gmx.de \
    --cc=airlied@redhat.com \
    --cc=arnd@arndb.de \
    --cc=bernie@plugable.com \
    --cc=gregkh@suse.de \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@decky.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.