From: Christoph Hellwig <hch@infradead.org>
To: Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc: Chaitanya Kulkarni <chaitanyakulkarni15@gmail.com>,
xfs@oss.sgi.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Assume yes when test device is not partitioned
Date: Sat, 3 Sep 2011 13:14:37 -0400 [thread overview]
Message-ID: <20110903171437.GA2755@infradead.org> (raw)
In-Reply-To: <1315038723-2009-1-git-send-email-prasadjoshi.linux@gmail.com>
On Sat, Sep 03, 2011 at 02:02:03PM +0530, Prasad Joshi wrote:
> The patch also replaces hard coded mkfs path with MKFS_PROG variable.
Which has nothing to do with the subject of this patch, so do it
separately, with a proper rationale for it.
>+++ b/common.rc
> @@ -314,7 +314,7 @@ _scratch_mkfs()
> $MKFS_BTRFS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
> ;;
> *)
> - /sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV
> + yes | $MKFS_PROG -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV
Please do this for extN only as the braindamage is in mke2fs, not
generic mkfs.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc: linux-ext4@vger.kernel.org,
Chaitanya Kulkarni <chaitanyakulkarni15@gmail.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH] Assume yes when test device is not partitioned
Date: Sat, 3 Sep 2011 13:14:37 -0400 [thread overview]
Message-ID: <20110903171437.GA2755@infradead.org> (raw)
In-Reply-To: <1315038723-2009-1-git-send-email-prasadjoshi.linux@gmail.com>
On Sat, Sep 03, 2011 at 02:02:03PM +0530, Prasad Joshi wrote:
> The patch also replaces hard coded mkfs path with MKFS_PROG variable.
Which has nothing to do with the subject of this patch, so do it
separately, with a proper rationale for it.
>+++ b/common.rc
> @@ -314,7 +314,7 @@ _scratch_mkfs()
> $MKFS_BTRFS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
> ;;
> *)
> - /sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV
> + yes | $MKFS_PROG -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV
Please do this for extN only as the braindamage is in mke2fs, not
generic mkfs.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-03 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 8:32 [PATCH] Assume yes when test device is not partitioned Prasad Joshi
2011-09-03 8:32 ` Prasad Joshi
2011-09-03 17:14 ` Christoph Hellwig [this message]
2011-09-03 17:14 ` Christoph Hellwig
2011-09-03 17:52 ` Ted Ts'o
2011-09-03 17:52 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110903171437.GA2755@infradead.org \
--to=hch@infradead.org \
--cc=chaitanyakulkarni15@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=prasadjoshi.linux@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.