* Re: [lm-sensors] [PATCH v2] hwmon: (pmbus) Fix low limit
@ 2011-09-11 16:29 Jean Delvare
0 siblings, 0 replies; only message in thread
From: Jean Delvare @ 2011-09-11 16:29 UTC (permalink / raw)
To: lm-sensors
On Sun, 11 Sep 2011 07:36:33 -0700, Guenter Roeck wrote:
> Temperature alarms are detected by checking the alarm bit and comparing
> temperature limits against the current temperature. For low limits, this
> comparison needs to be reversed (temp < limit instead of temp > limit).
> This was not taken into account, resulting in wrong alarms if a temperature
> fell below a low limit.
>
> Fix by adding a low limit flag in the limit data structure. When creating the
> sensor entry, the order of registers to compare is now reversed for low limits.
>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> v2: One of the tagged alarms wasn't a low limit.
>
> drivers/hwmon/pmbus/pmbus_core.c | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
> (...)
Acked-by: Jean Delvare <khali@linux-fr.org>
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-09-11 16:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-11 16:29 [lm-sensors] [PATCH v2] hwmon: (pmbus) Fix low limit Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.