All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
	coreteam@netfilter.org, linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org,
	Linux Containers <containers@lists.osdl.org>
Subject: Re: [PATCH] Fix repeatable Oops on container destroy with conntrack
Date: Mon, 12 Sep 2011 10:25:24 +0300	[thread overview]
Message-ID: <20110912072524.GA2996@p183.telecom.by> (raw)
In-Reply-To: <2184C0CE5A5EDC94CDDA5053@Ximines.local>

On Sat, Sep 10, 2011 at 07:48:43PM +0100, Alex Bligh wrote:
> --- a/net/netfilter/nf_conntrack_netlink.c
> +++ b/net/netfilter/nf_conntrack_netlink.c
> @@ -570,6 +570,11 @@ ctnetlink_conntrack_event(unsigned int events, struct nf_ct_event *item)
>  		return 0;
> 
>  	net = nf_ct_net(ct);
> +
> +	/* container deinit, netlink may have died before death_by_timeout */
> +	if (!net->nfnl)
> +		return 0;
> +
>  	if (!item->report && !nfnetlink_has_listeners(net, group))
>  		return 0;

If this is correct fix, ->nfnl check should be folded into
nfnetlink_has_listeners(), otherwise expectations aren't covered.

  reply	other threads:[~2011-09-12  7:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-10 18:48 [PATCH] Fix repeatable Oops on container destroy with conntrack Alex Bligh
2011-09-10 18:48 ` Alex Bligh
2011-09-10 18:48 ` Alex Bligh
2011-09-12  7:25 ` Alexey Dobriyan [this message]
2011-09-12  9:37   ` Pablo Neira Ayuso
2011-09-12 10:32     ` Alex Bligh
2011-09-12 18:33       ` Pablo Neira Ayuso
2011-09-12 19:06         ` Alex Bligh
2011-09-13 20:44           ` Alex Bligh
2011-09-13 20:44             ` Alex Bligh
2011-09-14  1:35             ` Pablo Neira Ayuso
2011-09-14  8:01               ` Alex Bligh
2011-09-28 21:08                 ` Pablo Neira Ayuso
2011-09-30 15:54                   ` Alex Bligh
  -- strict thread matches above, loose matches on Subject: below --
2011-09-10 18:48 Alex Bligh
2011-09-10 18:48 Alex Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110912072524.GA2996@p183.telecom.by \
    --to=adobriyan@gmail.com \
    --cc=alex@alex.org.uk \
    --cc=containers@lists.linux-foundation.org \
    --cc=containers@lists.osdl.org \
    --cc=coreteam@netfilter.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.