All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alex Bligh <alex@alex.org.uk>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
	coreteam@netfilter.org, linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org,
	Linux Containers <containers@lists.osdl.org>
Subject: Re: [PATCH] Fix repeatable Oops on container destroy with conntrack
Date: Wed, 14 Sep 2011 03:35:00 +0200	[thread overview]
Message-ID: <20110914013500.GB17051@1984> (raw)
In-Reply-To: <7631498AC7E7C0EAD641AC7D@nimrod.local>

On Tue, Sep 13, 2011 at 09:44:38PM +0100, Alex Bligh wrote:
> Alexey / Pablo,
> 
> --On 12 September 2011 20:06:25 +0100 Alex Bligh <alex@alex.org.uk> wrote:
> 
> >Pablo,
> >
> >--On 12 September 2011 20:33:57 +0200 Pablo Neira Ayuso
> ><pablo@netfilter.org> wrote:
> >
> >>Yes, this is what Alexey was pointing out in the previous email and
> >>why he suggested to move it to nfnetlink_has_listeners (to cover the
> >>expectation case).
> >>
> >>But you're right, we cannot move it to nfnetlink_has_listeners because
> >>of the item->report case. Please, include the expectation part and
> >>resend the patch.
> >
> >Thanks - see below
> 
> Is this new version OK? I am happy to adjust if not.

Hm, I still think that this is a workaround.

The nice fix should move nf_conntrack_event_cb in
nf_conntrack_ecache.c to the net container structure.

Alexey?

> I think we ought to get /something/ in, because without anything it's
> very simple to cause an oops and a resultant machine hang.

Sure, I'm all for fixing it :-).

  reply	other threads:[~2011-09-14  1:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-10 18:48 [PATCH] Fix repeatable Oops on container destroy with conntrack Alex Bligh
2011-09-10 18:48 ` Alex Bligh
2011-09-10 18:48 ` Alex Bligh
2011-09-12  7:25 ` Alexey Dobriyan
2011-09-12  9:37   ` Pablo Neira Ayuso
2011-09-12 10:32     ` Alex Bligh
2011-09-12 18:33       ` Pablo Neira Ayuso
2011-09-12 19:06         ` Alex Bligh
2011-09-13 20:44           ` Alex Bligh
2011-09-13 20:44             ` Alex Bligh
2011-09-14  1:35             ` Pablo Neira Ayuso [this message]
2011-09-14  8:01               ` Alex Bligh
2011-09-28 21:08                 ` Pablo Neira Ayuso
2011-09-30 15:54                   ` Alex Bligh
  -- strict thread matches above, loose matches on Subject: below --
2011-09-10 18:48 Alex Bligh
2011-09-10 18:48 Alex Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110914013500.GB17051@1984 \
    --to=pablo@netfilter.org \
    --cc=adobriyan@gmail.com \
    --cc=alex@alex.org.uk \
    --cc=containers@lists.linux-foundation.org \
    --cc=containers@lists.osdl.org \
    --cc=coreteam@netfilter.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.