* [PATCH] ath9k_hw: Do full chip reset on 11A channels
@ 2011-09-13 15:18 Rajkumar Manoharan
2011-09-13 16:01 ` Paul Stewart
0 siblings, 1 reply; 5+ messages in thread
From: Rajkumar Manoharan @ 2011-09-13 15:18 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Rajkumar Manoharan
AR9003 seems to have issues sometimes with fast channel change
in 5GHz and this case is handled specifically for AR9002 by doing
a full reset. So let's do a full reset for 5GHz channles for all
chipsets.
Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath9k/hw.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index 308847d..622bfc9 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -1504,7 +1504,7 @@ int ath9k_hw_reset(struct ath_hw *ah, struct ath9k_channel *chan,
(chan->channel != ah->curchan->channel) &&
((chan->channelFlags & CHANNEL_ALL) ==
(ah->curchan->channelFlags & CHANNEL_ALL)) &&
- (!AR_SREV_9280(ah) || AR_DEVID_7010(ah))) {
+ !IS_CHAN_5GHZ(chan)) {
if (ath9k_hw_channel_change(ah, chan)) {
ath9k_hw_loadnf(ah, ah->curchan);
--
1.7.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ath9k_hw: Do full chip reset on 11A channels
2011-09-13 15:18 [PATCH] ath9k_hw: Do full chip reset on 11A channels Rajkumar Manoharan
@ 2011-09-13 16:01 ` Paul Stewart
2011-09-13 17:13 ` Rajkumar Manoharan
0 siblings, 1 reply; 5+ messages in thread
From: Paul Stewart @ 2011-09-13 16:01 UTC (permalink / raw)
To: Rajkumar Manoharan; +Cc: linville, linux-wireless
On Tue, Sep 13, 2011 at 8:18 AM, Rajkumar Manoharan
<rmanohar@qca.qualcomm.com> wrote:
> AR9003 seems to have issues sometimes with fast channel change
> in 5GHz and this case is handled specifically for AR9002 by doing
> a full reset. So let's do a full reset for 5GHz channles for all
> chipsets.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath9k/hw.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
> index 308847d..622bfc9 100644
> --- a/drivers/net/wireless/ath/ath9k/hw.c
> +++ b/drivers/net/wireless/ath/ath9k/hw.c
> @@ -1504,7 +1504,7 @@ int ath9k_hw_reset(struct ath_hw *ah, struct ath9k_channel *chan,
> (chan->channel != ah->curchan->channel) &&
> ((chan->channelFlags & CHANNEL_ALL) ==
> (ah->curchan->channelFlags & CHANNEL_ALL)) &&
> - (!AR_SREV_9280(ah) || AR_DEVID_7010(ah))) {
> + !IS_CHAN_5GHZ(chan)) {
I'm not sure I understand. Are you asserting that AR9002 does not
need a full reset for channel change in 2GHz? The code before your
change would fall through for AR_SREV_9280(ah) && !AR_DEVID_7010(ah)
whether in 2HGz or 5GHz, but that case gets removed with your change.
Is that intentional?
>
> if (ath9k_hw_channel_change(ah, chan)) {
> ath9k_hw_loadnf(ah, ah->curchan);
> --
> 1.7.6.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ath9k_hw: Do full chip reset on 11A channels
2011-09-13 16:01 ` Paul Stewart
@ 2011-09-13 17:13 ` Rajkumar Manoharan
2011-09-13 17:38 ` Paul Stewart
0 siblings, 1 reply; 5+ messages in thread
From: Rajkumar Manoharan @ 2011-09-13 17:13 UTC (permalink / raw)
To: Paul Stewart; +Cc: linville, linux-wireless
On Tue, Sep 13, 2011 at 09:01:29AM -0700, Paul Stewart wrote:
> On Tue, Sep 13, 2011 at 8:18 AM, Rajkumar Manoharan
> <rmanohar@qca.qualcomm.com> wrote:
> > AR9003 seems to have issues sometimes with fast channel change
> > in 5GHz and this case is handled specifically for AR9002 by doing
> > a full reset. So let's do a full reset for 5GHz channles for all
> > chipsets.
> >
> > Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
> > ---
> > drivers/net/wireless/ath/ath9k/hw.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
> > index 308847d..622bfc9 100644
> > --- a/drivers/net/wireless/ath/ath9k/hw.c
> > +++ b/drivers/net/wireless/ath/ath9k/hw.c
> > @@ -1504,7 +1504,7 @@ int ath9k_hw_reset(struct ath_hw *ah, struct ath9k_channel *chan,
> > (chan->channel != ah->curchan->channel) &&
> > ((chan->channelFlags & CHANNEL_ALL) ==
> > (ah->curchan->channelFlags & CHANNEL_ALL)) &&
> > - (!AR_SREV_9280(ah) || AR_DEVID_7010(ah))) {
> > + !IS_CHAN_5GHZ(chan)) {
>
> I'm not sure I understand. Are you asserting that AR9002 does not
> need a full reset for channel change in 2GHz? The code before your
> change would fall through for AR_SREV_9280(ah) && !AR_DEVID_7010(ah)
> whether in 2HGz or 5GHz, but that case gets removed with your change.
> Is that intentional?
>
Yes. Fast channel change is completely supported on 2GHz band. And also
if you look at the log history, the fast channel change was initially
disabled in 5GHz alone for AR9280 chips. AR7010 chip is the usb version of
AR9280. Instead of adding chip specific checks, the fastcc is disabled for
5GHz.
--
Rajkumar
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ath9k_hw: Do full chip reset on 11A channels
2011-09-13 17:13 ` Rajkumar Manoharan
@ 2011-09-13 17:38 ` Paul Stewart
2011-09-14 6:43 ` Rajkumar Manoharan
0 siblings, 1 reply; 5+ messages in thread
From: Paul Stewart @ 2011-09-13 17:38 UTC (permalink / raw)
To: Rajkumar Manoharan; +Cc: linville, linux-wireless
On Tue, Sep 13, 2011 at 10:13 AM, Rajkumar Manoharan
<rmanohar@qca.qualcomm.com> wrote:
> On Tue, Sep 13, 2011 at 09:01:29AM -0700, Paul Stewart wrote:
>> On Tue, Sep 13, 2011 at 8:18 AM, Rajkumar Manoharan
>> <rmanohar@qca.qualcomm.com> wrote:
>> > AR9003 seems to have issues sometimes with fast channel change
>> > in 5GHz and this case is handled specifically for AR9002 by doing
>> > a full reset. So let's do a full reset for 5GHz channles for all
>> > chipsets.
>> >
>> > Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
>> > ---
>> > drivers/net/wireless/ath/ath9k/hw.c | 2 +-
>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
>> > index 308847d..622bfc9 100644
>> > --- a/drivers/net/wireless/ath/ath9k/hw.c
>> > +++ b/drivers/net/wireless/ath/ath9k/hw.c
>> > @@ -1504,7 +1504,7 @@ int ath9k_hw_reset(struct ath_hw *ah, struct ath9k_channel *chan,
>> > (chan->channel != ah->curchan->channel) &&
>> > ((chan->channelFlags & CHANNEL_ALL) ==
>> > (ah->curchan->channelFlags & CHANNEL_ALL)) &&
>> > - (!AR_SREV_9280(ah) || AR_DEVID_7010(ah))) {
>> > + !IS_CHAN_5GHZ(chan)) {
>>
>> I'm not sure I understand. Are you asserting that AR9002 does not
>> need a full reset for channel change in 2GHz? The code before your
>> change would fall through for AR_SREV_9280(ah) && !AR_DEVID_7010(ah)
>> whether in 2HGz or 5GHz, but that case gets removed with your change.
>> Is that intentional?
>>
> Yes. Fast channel change is completely supported on 2GHz band. And also
> if you look at the log history, the fast channel change was initially
> disabled in 5GHz alone for AR9280 chips. AR7010 chip is the usb version of
> AR9280. Instead of adding chip specific checks, the fastcc is disabled for
> 5GHz.
I might not be finding the right part of the history. I do see things
like 0a475cc6a0ac8e38ac3587cff87026551800b7fe: Vasanthakumar
Thiagarajan <vasanth@atheros.com> "ath9k: Do a full reset for AR9280;
AR9280 requires a full reset during channel change and HW reset.
Currently, a fast channel change is done. This patch fixes this bug."
This patch disabled fast-channel-change for the 9280 AND 2GHz channels
(what I assume 5MHZ_SPACED to be filtering). I still see no point in
history where 9280 was enabled for fast channel change in 2Ghz.
>
> --
> Rajkumar
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ath9k_hw: Do full chip reset on 11A channels
2011-09-13 17:38 ` Paul Stewart
@ 2011-09-14 6:43 ` Rajkumar Manoharan
0 siblings, 0 replies; 5+ messages in thread
From: Rajkumar Manoharan @ 2011-09-14 6:43 UTC (permalink / raw)
To: Paul Stewart; +Cc: linville, linux-wireless
On Tue, Sep 13, 2011 at 10:38:16AM -0700, Paul Stewart wrote:
> On Tue, Sep 13, 2011 at 10:13 AM, Rajkumar Manoharan
> <rmanohar@qca.qualcomm.com> wrote:
> > On Tue, Sep 13, 2011 at 09:01:29AM -0700, Paul Stewart wrote:
> >> On Tue, Sep 13, 2011 at 8:18 AM, Rajkumar Manoharan
> >> <rmanohar@qca.qualcomm.com> wrote:
> >> > AR9003 seems to have issues sometimes with fast channel change
> >> > in 5GHz and this case is handled specifically for AR9002 by doing
> >> > a full reset. So let's do a full reset for 5GHz channles for all
> >> > chipsets.
> >>
> >> I'm not sure I understand. Are you asserting that AR9002 does not
> >> need a full reset for channel change in 2GHz? The code before your
> >> change would fall through for AR_SREV_9280(ah) && !AR_DEVID_7010(ah)
> >> whether in 2HGz or 5GHz, but that case gets removed with your change.
> >> Is that intentional?
> >>
> > Yes. Fast channel change is completely supported on 2GHz band. And also
> > if you look at the log history, the fast channel change was initially
> > disabled in 5GHz alone for AR9280 chips. AR7010 chip is the usb version of
> > AR9280. Instead of adding chip specific checks, the fastcc is disabled for
> > 5GHz.
>
> I might not be finding the right part of the history. I do see things
> like 0a475cc6a0ac8e38ac3587cff87026551800b7fe: Vasanthakumar
> Thiagarajan <vasanth@atheros.com> "ath9k: Do a full reset for AR9280;
> AR9280 requires a full reset during channel change and HW reset.
> Currently, a fast channel change is done. This patch fixes this bug."
> This patch disabled fast-channel-change for the 9280 AND 2GHz channels
> (what I assume 5MHZ_SPACED to be filtering). I still see no point in
> history where 9280 was enabled for fast channel change in 2Ghz.
>
True. Let me check on this. Meanwhile I will send v2 patch to disable fastcc
on 11A for AR9380 alone.
--
Rajkumar
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-09-14 6:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-13 15:18 [PATCH] ath9k_hw: Do full chip reset on 11A channels Rajkumar Manoharan
2011-09-13 16:01 ` Paul Stewart
2011-09-13 17:13 ` Rajkumar Manoharan
2011-09-13 17:38 ` Paul Stewart
2011-09-14 6:43 ` Rajkumar Manoharan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.