All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm: omap: Fix build error in ispccdc.c
@ 2011-09-06 14:02 ` Joerg Roedel
  0 siblings, 0 replies; 11+ messages in thread
From: Joerg Roedel @ 2011-09-06 14:02 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Joerg Roedel, Laurent Pinchart, linux-media, linux-omap,
	linux-arm-kernel, linux-kernel

The following build error occurs with 3.1-rc5:

  CC      drivers/media/video/omap3isp/ispccdc.o
/home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c: In function 'ccdc_lsc_config':
/home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
/home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:6: warning: assignment makes pointer from integer without a cast [enabled by default]

This patch adds the missing 'linux/slab.h' include to fix the problem.

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org
Cc: linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 drivers/media/video/omap3isp/ispccdc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/omap3isp/ispccdc.c b/drivers/media/video/omap3isp/ispccdc.c
index 9d3459d..80796eb 100644
--- a/drivers/media/video/omap3isp/ispccdc.c
+++ b/drivers/media/video/omap3isp/ispccdc.c
@@ -31,6 +31,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/mm.h>
 #include <linux/sched.h>
+#include <linux/slab.h>
 #include <media/v4l2-event.h>
 
 #include "isp.h"
-- 
1.7.4.1



^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [PATCH] arm: omap: Fix build error in ispccdc.c
@ 2011-09-06 14:02 ` Joerg Roedel
  0 siblings, 0 replies; 11+ messages in thread
From: Joerg Roedel @ 2011-09-06 14:02 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Joerg Roedel, Laurent Pinchart, linux-media, linux-omap,
	linux-arm-kernel, linux-kernel

The following build error occurs with 3.1-rc5:

  CC      drivers/media/video/omap3isp/ispccdc.o
/home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c: In function 'ccdc_lsc_config':
/home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
/home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:6: warning: assignment makes pointer from integer without a cast [enabled by default]

This patch adds the missing 'linux/slab.h' include to fix the problem.

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org
Cc: linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 drivers/media/video/omap3isp/ispccdc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/omap3isp/ispccdc.c b/drivers/media/video/omap3isp/ispccdc.c
index 9d3459d..80796eb 100644
--- a/drivers/media/video/omap3isp/ispccdc.c
+++ b/drivers/media/video/omap3isp/ispccdc.c
@@ -31,6 +31,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/mm.h>
 #include <linux/sched.h>
+#include <linux/slab.h>
 #include <media/v4l2-event.h>
 
 #include "isp.h"
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [PATCH] arm: omap: Fix build error in ispccdc.c
@ 2011-09-06 14:02 ` Joerg Roedel
  0 siblings, 0 replies; 11+ messages in thread
From: Joerg Roedel @ 2011-09-06 14:02 UTC (permalink / raw)
  To: linux-arm-kernel

The following build error occurs with 3.1-rc5:

  CC      drivers/media/video/omap3isp/ispccdc.o
/home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c: In function 'ccdc_lsc_config':
/home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
/home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:6: warning: assignment makes pointer from integer without a cast [enabled by default]

This patch adds the missing 'linux/slab.h' include to fix the problem.

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media at vger.kernel.org
Cc: linux-omap at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 drivers/media/video/omap3isp/ispccdc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/omap3isp/ispccdc.c b/drivers/media/video/omap3isp/ispccdc.c
index 9d3459d..80796eb 100644
--- a/drivers/media/video/omap3isp/ispccdc.c
+++ b/drivers/media/video/omap3isp/ispccdc.c
@@ -31,6 +31,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/mm.h>
 #include <linux/sched.h>
+#include <linux/slab.h>
 #include <media/v4l2-event.h>
 
 #include "isp.h"
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PATCH] arm: omap: Fix build error in ispccdc.c
  2011-09-06 14:02 ` Joerg Roedel
@ 2011-09-06 15:06   ` Laurent Pinchart
  -1 siblings, 0 replies; 11+ messages in thread
From: Laurent Pinchart @ 2011-09-06 15:06 UTC (permalink / raw)
  To: Joerg Roedel
  Cc: Mauro Carvalho Chehab, linux-media, linux-omap, linux-arm-kernel,
	linux-kernel

Hi Joerg,

On Tuesday 06 September 2011 16:02:15 Joerg Roedel wrote:
> The following build error occurs with 3.1-rc5:
>
>   CC      drivers/media/video/omap3isp/ispccdc.o
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c: In
> function 'ccdc_lsc_config':
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:42
> 7:2: error: implicit declaration of function 'kzalloc'
> [-Werror=implicit-function-declaration]
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:42
> 7:6: warning: assignment makes pointer from integer without a cast [enabled
> by default]
> 
> This patch adds the missing 'linux/slab.h' include to fix the problem.

Thanks for the patch.

> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linux-media@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Mauro, can you please pick this patch and push it to v3.1 ?

> ---
>  drivers/media/video/omap3isp/ispccdc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/omap3isp/ispccdc.c
> b/drivers/media/video/omap3isp/ispccdc.c index 9d3459d..80796eb 100644
> --- a/drivers/media/video/omap3isp/ispccdc.c
> +++ b/drivers/media/video/omap3isp/ispccdc.c
> @@ -31,6 +31,7 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/mm.h>
>  #include <linux/sched.h>
> +#include <linux/slab.h>
>  #include <media/v4l2-event.h>
> 
>  #include "isp.h"

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH] arm: omap: Fix build error in ispccdc.c
@ 2011-09-06 15:06   ` Laurent Pinchart
  0 siblings, 0 replies; 11+ messages in thread
From: Laurent Pinchart @ 2011-09-06 15:06 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Joerg,

On Tuesday 06 September 2011 16:02:15 Joerg Roedel wrote:
> The following build error occurs with 3.1-rc5:
>
>   CC      drivers/media/video/omap3isp/ispccdc.o
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c: In
> function 'ccdc_lsc_config':
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:42
> 7:2: error: implicit declaration of function 'kzalloc'
> [-Werror=implicit-function-declaration]
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:42
> 7:6: warning: assignment makes pointer from integer without a cast [enabled
> by default]
> 
> This patch adds the missing 'linux/slab.h' include to fix the problem.

Thanks for the patch.

> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linux-media at vger.kernel.org
> Cc: linux-omap at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Mauro, can you please pick this patch and push it to v3.1 ?

> ---
>  drivers/media/video/omap3isp/ispccdc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/omap3isp/ispccdc.c
> b/drivers/media/video/omap3isp/ispccdc.c index 9d3459d..80796eb 100644
> --- a/drivers/media/video/omap3isp/ispccdc.c
> +++ b/drivers/media/video/omap3isp/ispccdc.c
> @@ -31,6 +31,7 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/mm.h>
>  #include <linux/sched.h>
> +#include <linux/slab.h>
>  #include <media/v4l2-event.h>
> 
>  #include "isp.h"

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] arm: omap: Fix build error in ispccdc.c
  2011-09-06 14:02 ` Joerg Roedel
  (?)
@ 2011-09-14 15:33   ` Roedel, Joerg
  -1 siblings, 0 replies; 11+ messages in thread
From: Roedel, Joerg @ 2011-09-14 15:33 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Laurent Pinchart, linux-media, linux-omap, linux-arm-kernel,
	linux-kernel

Ping?

On Tue, Sep 06, 2011 at 10:02:15AM -0400, Joerg Roedel wrote:
> The following build error occurs with 3.1-rc5:
> 
>   CC      drivers/media/video/omap3isp/ispccdc.o
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c: In function 'ccdc_lsc_config':
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:6: warning: assignment makes pointer from integer without a cast [enabled by default]
> 
> This patch adds the missing 'linux/slab.h' include to fix the problem.
> 
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linux-media@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
>  drivers/media/video/omap3isp/ispccdc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/omap3isp/ispccdc.c b/drivers/media/video/omap3isp/ispccdc.c
> index 9d3459d..80796eb 100644
> --- a/drivers/media/video/omap3isp/ispccdc.c
> +++ b/drivers/media/video/omap3isp/ispccdc.c
> @@ -31,6 +31,7 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/mm.h>
>  #include <linux/sched.h>
> +#include <linux/slab.h>
>  #include <media/v4l2-event.h>
>  
>  #include "isp.h"
> -- 
> 1.7.4.1

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632


^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] arm: omap: Fix build error in ispccdc.c
@ 2011-09-14 15:33   ` Roedel, Joerg
  0 siblings, 0 replies; 11+ messages in thread
From: Roedel, Joerg @ 2011-09-14 15:33 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Laurent Pinchart, linux-media, linux-omap, linux-arm-kernel,
	linux-kernel

Ping?

On Tue, Sep 06, 2011 at 10:02:15AM -0400, Joerg Roedel wrote:
> The following build error occurs with 3.1-rc5:
> 
>   CC      drivers/media/video/omap3isp/ispccdc.o
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c: In function 'ccdc_lsc_config':
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:6: warning: assignment makes pointer from integer without a cast [enabled by default]
> 
> This patch adds the missing 'linux/slab.h' include to fix the problem.
> 
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linux-media@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
>  drivers/media/video/omap3isp/ispccdc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/omap3isp/ispccdc.c b/drivers/media/video/omap3isp/ispccdc.c
> index 9d3459d..80796eb 100644
> --- a/drivers/media/video/omap3isp/ispccdc.c
> +++ b/drivers/media/video/omap3isp/ispccdc.c
> @@ -31,6 +31,7 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/mm.h>
>  #include <linux/sched.h>
> +#include <linux/slab.h>
>  #include <media/v4l2-event.h>
>  
>  #include "isp.h"
> -- 
> 1.7.4.1

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632


^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH] arm: omap: Fix build error in ispccdc.c
@ 2011-09-14 15:33   ` Roedel, Joerg
  0 siblings, 0 replies; 11+ messages in thread
From: Roedel, Joerg @ 2011-09-14 15:33 UTC (permalink / raw)
  To: linux-arm-kernel

Ping?

On Tue, Sep 06, 2011 at 10:02:15AM -0400, Joerg Roedel wrote:
> The following build error occurs with 3.1-rc5:
> 
>   CC      drivers/media/video/omap3isp/ispccdc.o
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c: In function 'ccdc_lsc_config':
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
> /home/data/repos/linux.trees.git/drivers/media/video/omap3isp/ispccdc.c:427:6: warning: assignment makes pointer from integer without a cast [enabled by default]
> 
> This patch adds the missing 'linux/slab.h' include to fix the problem.
> 
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linux-media at vger.kernel.org
> Cc: linux-omap at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
>  drivers/media/video/omap3isp/ispccdc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/omap3isp/ispccdc.c b/drivers/media/video/omap3isp/ispccdc.c
> index 9d3459d..80796eb 100644
> --- a/drivers/media/video/omap3isp/ispccdc.c
> +++ b/drivers/media/video/omap3isp/ispccdc.c
> @@ -31,6 +31,7 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/mm.h>
>  #include <linux/sched.h>
> +#include <linux/slab.h>
>  #include <media/v4l2-event.h>
>  
>  #include "isp.h"
> -- 
> 1.7.4.1

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] arm: omap: Fix build error in ispccdc.c
  2011-09-14 15:33   ` Roedel, Joerg
  (?)
@ 2011-09-14 15:46     ` Laurent Pinchart
  -1 siblings, 0 replies; 11+ messages in thread
From: Laurent Pinchart @ 2011-09-14 15:46 UTC (permalink / raw)
  To: Roedel, Joerg
  Cc: Mauro Carvalho Chehab, linux-media, linux-omap, linux-arm-kernel,
	linux-kernel

Mauro,

On Wednesday 14 September 2011 17:33:03 Roedel, Joerg wrote:
> Ping?

I've acked the patch on September the 6th and asked in the e-mail if you could 
pick it and push it to v3.1. Is there anything else I need to do ?

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] arm: omap: Fix build error in ispccdc.c
@ 2011-09-14 15:46     ` Laurent Pinchart
  0 siblings, 0 replies; 11+ messages in thread
From: Laurent Pinchart @ 2011-09-14 15:46 UTC (permalink / raw)
  To: Roedel, Joerg
  Cc: Mauro Carvalho Chehab, linux-media, linux-omap, linux-arm-kernel,
	linux-kernel

Mauro,

On Wednesday 14 September 2011 17:33:03 Roedel, Joerg wrote:
> Ping?

I've acked the patch on September the 6th and asked in the e-mail if you could 
pick it and push it to v3.1. Is there anything else I need to do ?

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH] arm: omap: Fix build error in ispccdc.c
@ 2011-09-14 15:46     ` Laurent Pinchart
  0 siblings, 0 replies; 11+ messages in thread
From: Laurent Pinchart @ 2011-09-14 15:46 UTC (permalink / raw)
  To: linux-arm-kernel

Mauro,

On Wednesday 14 September 2011 17:33:03 Roedel, Joerg wrote:
> Ping?

I've acked the patch on September the 6th and asked in the e-mail if you could 
pick it and push it to v3.1. Is there anything else I need to do ?

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2011-09-14 15:47 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-06 14:02 [PATCH] arm: omap: Fix build error in ispccdc.c Joerg Roedel
2011-09-06 14:02 ` Joerg Roedel
2011-09-06 14:02 ` Joerg Roedel
2011-09-06 15:06 ` Laurent Pinchart
2011-09-06 15:06   ` Laurent Pinchart
2011-09-14 15:33 ` Roedel, Joerg
2011-09-14 15:33   ` Roedel, Joerg
2011-09-14 15:33   ` Roedel, Joerg
2011-09-14 15:46   ` Laurent Pinchart
2011-09-14 15:46     ` Laurent Pinchart
2011-09-14 15:46     ` Laurent Pinchart

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.