[PATCH 0/3] Series short description

[PATCH 0/3] Series short description

[Lukasz Orlowski]

The following series implements...

---

Lukasz Orlowski (3):
      Create: Allow to create two volumes of different sizes within one container
      Create: Unnecessary prompt about device being busy
      Create: Incorrect message when creating a volume with explicit md dev name


 Create.c      |   26 +++++++++++++++-----------
 super-intel.c |   16 +++++++++++++---
 2 files changed, 28 insertions(+), 14 deletions(-)

-- 
Signature
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
z siedziba w Gdansku
ul. Slowackiego 173
80-298 Gdansk

Sad Rejonowy Gdansk Polnoc w Gdansku, 
VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, 
numer KRS 101882

NIP 957-07-52-316
Kapital zakladowy 200.000 zl

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

[PATCH 1/3] Create: Allow to create two volumes of different sizes within one container

[Lukasz Orlowski]

Allows to create RAID 5 volume on 3 disks and then RAID 1 volume on 2
disks withing the same container.

Signed-off-by: Lukasz Orlowski <lukasz.orlowski@intel.com>
---
 super-intel.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/super-intel.c b/super-intel.c
index a78d723..616853b 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -5041,6 +5041,12 @@ static int validate_geometry_imsm_volume(struct supertype *st, int level,
 	if (!super)
 		return 0;
 
+	if (mpb->num_raid_devs > 0 && mpb->num_disks != raiddisks) {
+		fprintf(stderr, Name ": the option-rom requires all "
+			"member disks to be a member of all volumes.\n");
+		return 0;
+	}
+
 	if (!validate_geometry_imsm_orom(super, level, layout, raiddisks, chunk, verbose)) {
 		fprintf(stderr, Name ": RAID gemetry validation failed. "
 			"Cannot proceed with the action(s).\n");

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
z siedziba w Gdansku
ul. Slowackiego 173
80-298 Gdansk

Sad Rejonowy Gdansk Polnoc w Gdansku, 
VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, 
numer KRS 101882

NIP 957-07-52-316
Kapital zakladowy 200.000 zl

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

[PATCH 2/3] Create: Unnecessary prompt about device being busy

[Lukasz Orlowski]

Should the geometry validation fail, mdadm exits with error code 2 if the
style of metadata is not explicitly set to imsm. Prior to that however it
attempts to exclusively open a device block file. If it succeeds it says
that the device is not suitable for any kind of array, otherwise it just
says that the device is busy. The file opened is not closed afterwards.

Signed-off-by: Lukasz Orlowski <lukasz.orlowski@intel.com>
---
 Create.c |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/Create.c b/Create.c
index 8d88aa1..47e5fc8 100644
--- a/Create.c
+++ b/Create.c
@@ -346,15 +346,15 @@ int Create(struct supertype *st, char *mddev,
 
 			if (!st) {
 				int dfd = open(dname, O_RDONLY|O_EXCL);
-				if (dfd < 0) {
-					fprintf(stderr, Name ": cannot open %s: %s\n",
-						dname, strerror(errno));
-					exit(2);
+				if (dfd >= 0) {
+					fprintf(stderr,
+						Name ": device %s not suitable"
+						" for any style of array\n",
+						dname);
+					close(dfd);
 				}
-				fprintf(stderr, Name ": device %s not suitable "
-					"for any style of array\n",
-					dname);
-				exit(2);
+				fail = 1;
+				break;
 			}
 			if (st->ss != &super0 ||
 			    st->minor_version != 90)
@@ -443,7 +443,7 @@ int Create(struct supertype *st, char *mddev,
 			close(fd);
 		}
 	}
-	if (raiddisks + sparedisks > st->max_devs) {
+	if (st && raiddisks + sparedisks > st->max_devs) {
 		fprintf(stderr, Name ": Too many devices:"
 			" %s metadata only supports %d\n",
 			st->ss->name, st->max_devs);

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
z siedziba w Gdansku
ul. Slowackiego 173
80-298 Gdansk

Sad Rejonowy Gdansk Polnoc w Gdansku, 
VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, 
numer KRS 101882

NIP 957-07-52-316
Kapital zakladowy 200.000 zl

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

[PATCH 3/3] Create: Incorrect message when creating a volume with explicit md dev name

[Lukasz Orlowski]

Appears when one attempts to create RAID 1 volume on 2 disks within a
container with an existing RAID 5 volume on 3 disks and specifies the
md device explicitly (e.g. /dev/md127). Instead of saying that such volume
cannot be created it says that the devices have insufficient size.

Signed-off-by: Lukasz Orlowski <lukasz.orlowski@intel.com>
---
 Create.c      |    8 ++++++--
 super-intel.c |   10 +++++++---
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/Create.c b/Create.c
index 47e5fc8..baadd9f 100644
--- a/Create.c
+++ b/Create.c
@@ -262,9 +262,13 @@ int Create(struct supertype *st, char *mddev,
 	if (size && chunk && chunk != UnSet)
 		size &= ~(unsigned long long)(chunk - 1);
 	newsize = size * 2;
-	if (st && ! st->ss->validate_geometry(st, level, layout, raiddisks,
-					      &chunk, size*2, NULL, &newsize, verbose>=0))
+	if (st && !
+		st->ss->validate_geometry(
+				st, level, layout, raiddisks, &chunk,
+				size*2, NULL, &newsize, verbose >= 0)) {
+		fprintf(stderr, Name ": create aborted.\n");
 		return 1;
+	}
 
 	if (chunk && chunk != UnSet) {
 		newsize &= ~(unsigned long long)(chunk*2 - 1);
diff --git a/super-intel.c b/super-intel.c
index 616853b..51874ae 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -5223,9 +5223,13 @@ static int reserve_space(struct supertype *st, int raiddisks,
 		/* chunk is in K */
 		minsize = chunk * 2;
 
-	if (cnt < raiddisks ||
-	    (super->orom && used && used != raiddisks) ||
-	    maxsize < minsize ||
+	if (cnt < raiddisks || (super->orom && used && used != raiddisks)) {
+		fprintf(stderr, Name ": the option-rom requires all "
+			"member disks to be a member of all volumes.\n");
+		return 0;
+	}
+
+	if (maxsize < minsize ||
 	    maxsize == 0) {
 		fprintf(stderr, Name ": not enough devices with space to create array.\n");
 		return 0; /* No enough free spaces large enough */

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
z siedziba w Gdansku
ul. Slowackiego 173
80-298 Gdansk

Sad Rejonowy Gdansk Polnoc w Gdansku, 
VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, 
numer KRS 101882

NIP 957-07-52-316
Kapital zakladowy 200.000 zl

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: [PATCH 1/3] Create: Allow to create two volumes of different sizes within one container

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1858 bytes --]

On Mon, 19 Sep 2011 18:52:31 +0200 Lukasz Orlowski
<lukasz.orlowski@intel.com> wrote:

> Allows to create RAID 5 volume on 3 disks and then RAID 1 volume on 2
> disks withing the same container.
> 
> Signed-off-by: Lukasz Orlowski <lukasz.orlowski@intel.com>
> ---
>  super-intel.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/super-intel.c b/super-intel.c
> index a78d723..616853b 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -5041,6 +5041,12 @@ static int validate_geometry_imsm_volume(struct supertype *st, int level,
>  	if (!super)
>  		return 0;
>  
> +	if (mpb->num_raid_devs > 0 && mpb->num_disks != raiddisks) {
> +		fprintf(stderr, Name ": the option-rom requires all "
> +			"member disks to be a member of all volumes.\n");
> +		return 0;
> +	}
> +
>  	if (!validate_geometry_imsm_orom(super, level, layout, raiddisks, chunk, verbose)) {
>  		fprintf(stderr, Name ": RAID gemetry validation failed. "
>  			"Cannot proceed with the action(s).\n");
> 

This patch doesn't make sense.

Firstly the description seems backwards.  The purpose of this patch seems to
disallow the creation of two volumes with different numbers of devices, but
the description seems to say that it allows it.  But that is a small point.

->num_disks is the number of devices in the container including spares.  This
patch would allow the first array in a container to have fewer devices than
the container with the rest being spares.  However the second array would have
to have the same number of devices as the container - even if this is more
than the first array.

Presumably what you really want to do is:
  if num_raid_devs > 0, then find the relevant imsm_map, and then check if
     map->num_members == raiddisks
  and fail if they are not equal.

??

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: [PATCH 2/3] Create: Unnecessary prompt about device being busy

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 2824 bytes --]

On Mon, 19 Sep 2011 18:52:38 +0200 Lukasz Orlowski
<lukasz.orlowski@intel.com> wrote:

> Should the geometry validation fail, mdadm exits with error code 2 if the
> style of metadata is not explicitly set to imsm. Prior to that however it
> attempts to exclusively open a device block file. If it succeeds it says
> that the device is not suitable for any kind of array, otherwise it just
> says that the device is busy. The file opened is not closed afterwards.
> 
> Signed-off-by: Lukasz Orlowski <lukasz.orlowski@intel.com>

I'm confused.  What exactly is the problem here?

If geometry validation fails, we need to exit because there is nothing useful
we can do.
We simply check if the problem is that the device is already in use, or if it
is an unusable device and report that.  Then exit.
Seeing we are about the exit there is point closing the file.

What is the scenario when you get incorrect behaviour?

NeilBrown


> ---
>  Create.c |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/Create.c b/Create.c
> index 8d88aa1..47e5fc8 100644
> --- a/Create.c
> +++ b/Create.c
> @@ -346,15 +346,15 @@ int Create(struct supertype *st, char *mddev,
>  
>  			if (!st) {
>  				int dfd = open(dname, O_RDONLY|O_EXCL);
> -				if (dfd < 0) {
> -					fprintf(stderr, Name ": cannot open %s: %s\n",
> -						dname, strerror(errno));
> -					exit(2);
> +				if (dfd >= 0) {
> +					fprintf(stderr,
> +						Name ": device %s not suitable"
> +						" for any style of array\n",
> +						dname);
> +					close(dfd);
>  				}
> -				fprintf(stderr, Name ": device %s not suitable "
> -					"for any style of array\n",
> -					dname);
> -				exit(2);
> +				fail = 1;
> +				break;
>  			}
>  			if (st->ss != &super0 ||
>  			    st->minor_version != 90)
> @@ -443,7 +443,7 @@ int Create(struct supertype *st, char *mddev,
>  			close(fd);
>  		}
>  	}
> -	if (raiddisks + sparedisks > st->max_devs) {
> +	if (st && raiddisks + sparedisks > st->max_devs) {
>  		fprintf(stderr, Name ": Too many devices:"
>  			" %s metadata only supports %d\n",
>  			st->ss->name, st->max_devs);
> 
> ---------------------------------------------------------------------
> Intel Technology Poland sp. z o.o.
> z siedziba w Gdansku
> ul. Slowackiego 173
> 80-298 Gdansk
> 
> Sad Rejonowy Gdansk Polnoc w Gdansku, 
> VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, 
> numer KRS 101882
> 
> NIP 957-07-52-316
> Kapital zakladowy 200.000 zl
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: [PATCH 3/3] Create: Incorrect message when creating a volume with explicit md dev name

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 3003 bytes --]

On Mon, 19 Sep 2011 18:52:45 +0200 Lukasz Orlowski
<lukasz.orlowski@intel.com> wrote:

> Appears when one attempts to create RAID 1 volume on 2 disks within a
> container with an existing RAID 5 volume on 3 disks and specifies the
> md device explicitly (e.g. /dev/md127). Instead of saying that such volume
> cannot be created it says that the devices have insufficient size.

I cannot reproduce this and I don't really understand what problem you are
trying to solve (seems to be happening a lot today :-(  )

Could you give me a simple list of commands that produce undesirable results?

Thanks,
NeilBrown



> 
> Signed-off-by: Lukasz Orlowski <lukasz.orlowski@intel.com>
> ---
>  Create.c      |    8 ++++++--
>  super-intel.c |   10 +++++++---
>  2 files changed, 13 insertions(+), 5 deletions(-)
> 
> diff --git a/Create.c b/Create.c
> index 47e5fc8..baadd9f 100644
> --- a/Create.c
> +++ b/Create.c
> @@ -262,9 +262,13 @@ int Create(struct supertype *st, char *mddev,
>  	if (size && chunk && chunk != UnSet)
>  		size &= ~(unsigned long long)(chunk - 1);
>  	newsize = size * 2;
> -	if (st && ! st->ss->validate_geometry(st, level, layout, raiddisks,
> -					      &chunk, size*2, NULL, &newsize, verbose>=0))
> +	if (st && !
> +		st->ss->validate_geometry(
> +				st, level, layout, raiddisks, &chunk,
> +				size*2, NULL, &newsize, verbose >= 0)) {
> +		fprintf(stderr, Name ": create aborted.\n");
>  		return 1;
> +	}
>  
>  	if (chunk && chunk != UnSet) {
>  		newsize &= ~(unsigned long long)(chunk*2 - 1);
> diff --git a/super-intel.c b/super-intel.c
> index 616853b..51874ae 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -5223,9 +5223,13 @@ static int reserve_space(struct supertype *st, int raiddisks,
>  		/* chunk is in K */
>  		minsize = chunk * 2;
>  
> -	if (cnt < raiddisks ||
> -	    (super->orom && used && used != raiddisks) ||
> -	    maxsize < minsize ||
> +	if (cnt < raiddisks || (super->orom && used && used != raiddisks)) {
> +		fprintf(stderr, Name ": the option-rom requires all "
> +			"member disks to be a member of all volumes.\n");
> +		return 0;
> +	}
> +
> +	if (maxsize < minsize ||
>  	    maxsize == 0) {
>  		fprintf(stderr, Name ": not enough devices with space to create array.\n");
>  		return 0; /* No enough free spaces large enough */
> 
> ---------------------------------------------------------------------
> Intel Technology Poland sp. z o.o.
> z siedziba w Gdansku
> ul. Slowackiego 173
> 80-298 Gdansk
> 
> Sad Rejonowy Gdansk Polnoc w Gdansku, 
> VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, 
> numer KRS 101882
> 
> NIP 957-07-52-316
> Kapital zakladowy 200.000 zl
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: [PATCH 1/3] Create: Allow to create two volumes of different sizes within one container

[Dan Williams]

[-- Attachment #1: Type: text/plain, Size: 2266 bytes --]

On Tue, Sep 20, 2011 at 8:31 PM, NeilBrown <neilb@suse.de> wrote:
> On Mon, 19 Sep 2011 18:52:31 +0200 Lukasz Orlowski
> <lukasz.orlowski@intel.com> wrote:
>
>> Allows to create RAID 5 volume on 3 disks and then RAID 1 volume on 2
>> disks withing the same container.
>>
>> Signed-off-by: Lukasz Orlowski <lukasz.orlowski@intel.com>
>> ---
>>  super-intel.c |    6 ++++++
>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/super-intel.c b/super-intel.c
>> index a78d723..616853b 100644
>> --- a/super-intel.c
>> +++ b/super-intel.c
>> @@ -5041,6 +5041,12 @@ static int validate_geometry_imsm_volume(struct supertype *st, int level,
>>       if (!super)
>>               return 0;
>>
>> +     if (mpb->num_raid_devs > 0 && mpb->num_disks != raiddisks) {
>> +             fprintf(stderr, Name ": the option-rom requires all "
>> +                     "member disks to be a member of all volumes.\n");
>> +             return 0;
>> +     }
>> +
>>       if (!validate_geometry_imsm_orom(super, level, layout, raiddisks, chunk, verbose)) {
>>               fprintf(stderr, Name ": RAID gemetry validation failed. "
>>                       "Cannot proceed with the action(s).\n");
>>
>
> This patch doesn't make sense.
>
> Firstly the description seems backwards.  The purpose of this patch seems to
> disallow the creation of two volumes with different numbers of devices, but
> the description seems to say that it allows it.  But that is a small point.
>
> ->num_disks is the number of devices in the container including spares.  This
> patch would allow the first array in a container to have fewer devices than
> the container with the rest being spares.  However the second array would have
> to have the same number of devices as the container - even if this is more
> than the first array.
>
> Presumably what you really want to do is:
>  if num_raid_devs > 0, then find the relevant imsm_map, and then check if
>     map->num_members == raiddisks
>  and fail if they are not equal.
>

Yeah, the changelog is backwards, and this breaks tests/08imsm-overlap
because it does not honor IMSM_NO_PLATFORM.  How about the attached?

Lukasz, please copy me on patch submissions.

Thanks,
Dan

[-- Attachment #2: fix-member-disks.patch --]
[-- Type: application/octet-stream, Size: 1832 bytes --]

imsm: fix array membership enforcement

From: Dan Williams <dan.j.williams@intel.com>

Commit e7cb06c8 "Create: Allow to create two volumes of different sizes
within one container" fixed enforcement of the "all member disks must be
a member of all arrays" constraint by adding support for the case where
a smaller array is being created in a container with a larger array.

However, it broke tests/08imsm-overlap, and the test should be moved
next to the existing code that prevents new spares from being activated
prematurely.

Cc: Lukasz Orlowski <lukasz.orlowski@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 super-intel.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/super-intel.c b/super-intel.c
index 07d47b5..9885b98 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -5122,12 +5122,6 @@ static int validate_geometry_imsm_volume(struct supertype *st, int level,
 	if (!super)
 		return 0;
 
-	if (mpb->num_raid_devs > 0 && mpb->num_disks != raiddisks) {
-		fprintf(stderr, Name ": the option-rom requires all "
-			"member disks to be a member of all volumes.\n");
-		return 0;
-	}
-
 	if (!validate_geometry_imsm_orom(super, level, layout, raiddisks, chunk, verbose)) {
 		fprintf(stderr, Name ": RAID gemetry validation failed. "
 			"Cannot proceed with the action(s).\n");
@@ -5206,6 +5200,11 @@ static int validate_geometry_imsm_volume(struct supertype *st, int level,
 		fprintf(stderr, Name ": The option-rom requires all member"
 			" disks to be a member of all volumes\n");
 		return 0;
+	} else if (super->orom && mpb->num_raid_devs > 0 &&
+		   mpb->num_disks != raiddisks) {
+		fprintf(stderr, Name ": The option-rom requires all member"
+			" disks to be a member of all volumes\n");
+		return 0;
 	}
 
 	/* retrieve the largest free space block */

Re: [PATCH 1/3] Create: Allow to create two volumes of different sizes within one container

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 2814 bytes --]

On Tue, 20 Sep 2011 23:31:03 -0700 Dan Williams <dan.j.williams@intel.com>
wrote:

> On Tue, Sep 20, 2011 at 8:31 PM, NeilBrown <neilb@suse.de> wrote:
> > On Mon, 19 Sep 2011 18:52:31 +0200 Lukasz Orlowski
> > <lukasz.orlowski@intel.com> wrote:
> >
> >> Allows to create RAID 5 volume on 3 disks and then RAID 1 volume on 2
> >> disks withing the same container.
> >>
> >> Signed-off-by: Lukasz Orlowski <lukasz.orlowski@intel.com>
> >> ---
> >>  super-intel.c |    6 ++++++
> >>  1 files changed, 6 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/super-intel.c b/super-intel.c
> >> index a78d723..616853b 100644
> >> --- a/super-intel.c
> >> +++ b/super-intel.c
> >> @@ -5041,6 +5041,12 @@ static int validate_geometry_imsm_volume(struct supertype *st, int level,
> >>       if (!super)
> >>               return 0;
> >>
> >> +     if (mpb->num_raid_devs > 0 && mpb->num_disks != raiddisks) {
> >> +             fprintf(stderr, Name ": the option-rom requires all "
> >> +                     "member disks to be a member of all volumes.\n");
> >> +             return 0;
> >> +     }
> >> +
> >>       if (!validate_geometry_imsm_orom(super, level, layout, raiddisks, chunk, verbose)) {
> >>               fprintf(stderr, Name ": RAID gemetry validation failed. "
> >>                       "Cannot proceed with the action(s).\n");
> >>
> >
> > This patch doesn't make sense.
> >
> > Firstly the description seems backwards.  The purpose of this patch seems to
> > disallow the creation of two volumes with different numbers of devices, but
> > the description seems to say that it allows it.  But that is a small point.
> >
> > ->num_disks is the number of devices in the container including spares.  This
> > patch would allow the first array in a container to have fewer devices than
> > the container with the rest being spares.  However the second array would have
> > to have the same number of devices as the container - even if this is more
> > than the first array.
> >
> > Presumably what you really want to do is:
> >  if num_raid_devs > 0, then find the relevant imsm_map, and then check if
> >     map->num_members == raiddisks
> >  and fail if they are not equal.
> >
> 
> Yeah, the changelog is backwards, and this breaks tests/08imsm-overlap
> because it does not honor IMSM_NO_PLATFORM.  How about the attached?

Better (though text/plain attachments are preferred over
application/octet-stream....)

However there still seems to be confusion over num_disks versus num_members.

You compare num_disks to raiddisks but my understanding is that num_disks can
include spares while raiddisks definitely doesn't.  Am I confused or are you?

NeilBrown


> 
> Lukasz, please copy me on patch submissions.
> 
> Thanks,
> Dan


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: [PATCH 1/3] Create: Allow to create two volumes of different sizes within one container

[Dan Williams]

[ reviving old thread given the recent patch from Adam [1]]

On Tue, Sep 20, 2011 at 11:55 PM, NeilBrown <neilb@suse.de> wrote:
>> Yeah, the changelog is backwards, and this breaks tests/08imsm-overlap
>> because it does not honor IMSM_NO_PLATFORM.  How about the attached?
>
> Better (though text/plain attachments are preferred over
> application/octet-stream....)

Yeah, gmail picked that unfortunately... need to get my evolution
setup going again.

> However there still seems to be confusion over num_disks versus num_members.
>
> You compare num_disks to raiddisks but my understanding is that num_disks can
> include spares while raiddisks definitely doesn't.  Am I confused or are you?

Unfortunately the metadata has no knowledge of how many spares there
should be.  num_disks is always the current container membership as
and spare disks have a metadata record with num_disks == 1.

[1]: http://marc.info/?l=linux-raid&m=132387896006974&w=2
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/3] Series short description

[Leonid Yegoshin]

The following series implements...

---

Leonid Yegoshin (3):
      MIPS: rearrange PTE bits into fixed positions
      MIPS: PTE bit positions slightly changed to prepare a more simple swap/file presentation
      MIPS: bugfix of PTE formats for swap and file entries


 arch/mips/include/asm/pgtable-32.h   |  107 ++++++++-----------
 arch/mips/include/asm/pgtable-64.h   |   25 +++-
 arch/mips/include/asm/pgtable-bits.h |  189 ++++++++++++++++++++++++++++++----
 3 files changed, 232 insertions(+), 89 deletions(-)

-- 
Signature

[PATCH 0/3] Series short description

[Leonid Yegoshin]

The following series implements...

---

Leonid Yegoshin (3):
      MIPS: rearrange PTE bits into fixed positions
      MIPS: PTE bit positions slightly changed to prepare a more simple swap/file presentation
      MIPS: bugfix of PTE formats for swap and file entries


 arch/mips/include/asm/pgtable-32.h   |  107 ++++++++-----------
 arch/mips/include/asm/pgtable-64.h   |   25 +++-
 arch/mips/include/asm/pgtable-bits.h |  189 ++++++++++++++++++++++++++++++----
 3 files changed, 232 insertions(+), 89 deletions(-)

-- 
Signature

Re: [PATCH 0/3] Series short description

[David Härdeman]

On Wed, Mar 26, 2014 at 12:39:23AM +0100, David Härdeman wrote:
>The following series implements...

Nothing...sorry, I'll send the real patchset soon :)

[PATCH 0/3] Series short description

[David Härdeman]

The following series implements...

---

David Härdeman (3):
      bt8xx: fixup RC5 decoding
      rc-core: improve ir-kbd-i2c get_key functions
      rc-core: document the protocol type


 drivers/media/i2c/ir-kbd-i2c.c              |   91 +++++++++++-----------
 drivers/media/pci/bt8xx/bttv-input.c        |   78 ++++++++++---------
 drivers/media/pci/bt8xx/bttvp.h             |    2 
 drivers/media/pci/cx88/cx88-input.c         |   34 ++++++--
 drivers/media/pci/dm1105/dm1105.c           |    3 -
 drivers/media/pci/ivtv/ivtv-i2c.c           |    9 +-
 drivers/media/pci/saa7134/saa7134-input.c   |   82 ++++++++++++--------
 drivers/media/pci/ttpci/budget-ci.c         |    8 +-
 drivers/media/rc/img-ir/img-ir-hw.c         |    8 +-
 drivers/media/rc/img-ir/img-ir-hw.h         |    3 -
 drivers/media/rc/img-ir/img-ir-jvc.c        |    4 +
 drivers/media/rc/img-ir/img-ir-nec.c        |    4 +
 drivers/media/rc/img-ir/img-ir-sanyo.c      |    4 +
 drivers/media/rc/img-ir/img-ir-sharp.c      |    4 +
 drivers/media/rc/img-ir/img-ir-sony.c       |   12 ++-
 drivers/media/rc/ir-jvc-decoder.c           |    2 
 drivers/media/rc/ir-nec-decoder.c           |    2 
 drivers/media/rc/ir-rc5-decoder.c           |    5 +
 drivers/media/rc/ir-rc5-sz-decoder.c        |    2 
 drivers/media/rc/ir-rc6-decoder.c           |   37 +++++++--
 drivers/media/rc/ir-sanyo-decoder.c         |    2 
 drivers/media/rc/ir-sharp-decoder.c         |    2 
 drivers/media/rc/ir-sony-decoder.c          |    6 +
 drivers/media/rc/keymaps/rc-nebula.c        |  112 ++++++++++++++-------------
 drivers/media/rc/rc-main.c                  |   32 +++++---
 drivers/media/usb/cx231xx/cx231xx-input.c   |   20 ++---
 drivers/media/usb/dvb-usb-v2/af9015.c       |   18 +++-
 drivers/media/usb/dvb-usb-v2/af9035.c       |    9 +-
 drivers/media/usb/dvb-usb-v2/anysee.c       |    3 -
 drivers/media/usb/dvb-usb-v2/az6007.c       |   25 +++---
 drivers/media/usb/dvb-usb-v2/lmedm04.c      |    9 +-
 drivers/media/usb/dvb-usb-v2/rtl28xxu.c     |   12 +--
 drivers/media/usb/dvb-usb/dib0700_core.c    |   16 ++--
 drivers/media/usb/dvb-usb/dib0700_devices.c |   24 +++---
 drivers/media/usb/dvb-usb/dw2102.c          |    7 +-
 drivers/media/usb/dvb-usb/m920x.c           |    2 
 drivers/media/usb/dvb-usb/pctv452e.c        |    8 +-
 drivers/media/usb/dvb-usb/ttusb2.c          |    6 +
 drivers/media/usb/em28xx/em28xx-input.c     |   98 ++++++++++++++----------
 drivers/media/usb/tm6000/tm6000-input.c     |   51 ++++++++----
 include/media/ir-kbd-i2c.h                  |    6 +
 include/media/rc-core.h                     |    6 +
 include/media/rc-map.h                      |   10 ++
 43 files changed, 512 insertions(+), 366 deletions(-)

-- 
Signature

[PATCH 0/3] Series short description

[Dave Jiang]

The following series address issues with the ioatdma driver. The first
patch fixes a potential ring size overflow. The next two patches put
in alignment requirement for silicon errata on the ioatdma hardware related to
M2M ops and impacts NETDMA. The last patch will probably need to be
ack'd by David Miller as it touches the network subsystem.
---

Dave Jiang (3):
      netdma: adding alignment check for NETDMA ops
      ioatdma: DMA copy alignment needed to address IOAT DMA silicon errata
      ioat: ring size variables need to be 32bit to avoid overflow


 drivers/dma/dmaengine.c   |   14 ++++++++++++++
 drivers/dma/ioat/dma_v2.c |    4 ++--
 drivers/dma/ioat/dma_v2.h |    4 ++--
 drivers/dma/ioat/dma_v3.c |   41 +++++++++++++++++++++++++++++++++++++++++
 include/linux/dmaengine.h |    1 +
 net/ipv4/tcp.c            |    4 ++--
 net/ipv4/tcp_input.c      |    2 +-
 net/ipv4/tcp_ipv4.c       |    2 +-
 net/ipv6/tcp_ipv6.c       |    2 +-
 9 files changed, 65 insertions(+), 9 deletions(-)

-- 

[PATCH 0/3] Series short description

[Balbir Singh]

The following series implements page cache control,
this is a split out version of patch 1 of version 3 of the
page cache optimization patches posted earlier at
http://www.mail-archive.com/kvm@vger.kernel.org/msg43654.html

Christoph Lamater recommended splitting out patch 1, which
is what this series does

Detailed Description
====================
This patch implements unmapped page cache control via preferred
page cache reclaim. The current patch hooks into kswapd and reclaims
page cache if the user has requested for unmapped page control.
This is useful in the following scenario

- In a virtualized environment with cache=writethrough, we see
  double caching - (one in the host and one in the guest). As
  we try to scale guests, cache usage across the system grows.
  The goal of this patch is to reclaim page cache when Linux is running
  as a guest and get the host to hold the page cache and manage it.
  There might be temporary duplication, but in the long run, memory
  in the guests would be used for mapped pages.
- The option is controlled via a boot option and the administrator
  can selectively turn it on, on a need to use basis.

A lot of the code is borrowed from zone_reclaim_mode logic for
__zone_reclaim(). One might argue that the with ballooning and
KSM this feature is not very useful, but even with ballooning,
we need extra logic to balloon multiple VM machines and it is hard
to figure out the correct amount of memory to balloon. With these
patches applied, each guest has a sufficient amount of free memory
available, that can be easily seen and reclaimed by the balloon driver.
The additional memory in the guest can be reused for additional
applications or used to start additional guests/balance memory in
the host.

KSM currently does not de-duplicate host and guest page cache. The goal
of this patch is to help automatically balance unmapped page cache when
instructed to do so.

There are some magic numbers in use in the code, UNMAPPED_PAGE_RATIO
and the number of pages to reclaim when unmapped_page_control argument
is supplied. These numbers were chosen to avoid aggressiveness in
reaping page cache ever so frequently, at the same time providing control.

The sysctl for min_unmapped_ratio provides further control from
within the guest on the amount of unmapped pages to reclaim.



For a single VM - running kernbench

Enabled

Optimal load -j 8 run number 1...
Optimal load -j 8 run number 2...
Optimal load -j 8 run number 3...
Optimal load -j 8 run number 4...
Optimal load -j 8 run number 5...
Average Optimal load -j 8 Run (std deviation):
Elapsed Time 273.726 (1.2683)
User Time 190.014 (0.589941)
System Time 298.758 (1.72574)
Percent CPU 178 (0)
Context Switches 119953 (865.74)
Sleeps 38758 (795.074)

Disabled

Optimal load -j 8 run number 1...
Optimal load -j 8 run number 2...
Optimal load -j 8 run number 3...
Optimal load -j 8 run number 4...
Optimal load -j 8 run number 5...
Average Optimal load -j 8 Run (std deviation):
Elapsed Time 272.672 (0.453178)
User Time 189.7 (0.718157)
System Time 296.77 (0.845606)
Percent CPU 178 (0)
Context Switches 118822 (277.434)
Sleeps 37542.8 (545.922)

More data on the test results with the earlier patch is
at http://www.mail-archive.com/kvm@vger.kernel.org/msg43655.html

---

Balbir Singh (3):
      Move zone_reclaim() outside of CONFIG_NUMA
      Refactor zone_reclaim, move reusable functionality outside
      Provide control over unmapped pages


 include/linux/mmzone.h |    4 +-
 include/linux/swap.h   |    5 +-
 mm/page_alloc.c        |    7 ++-
 mm/vmscan.c            |  109 +++++++++++++++++++++++++++++++++++++++++-------
 4 files changed, 104 insertions(+), 21 deletions(-)

-- 
Balbir

[PATCH 0/3] Series short description

[Balbir Singh]

The following series implements page cache control,
this is a split out version of patch 1 of version 3 of the
page cache optimization patches posted earlier at
http://www.mail-archive.com/kvm@vger.kernel.org/msg43654.html

Christoph Lamater recommended splitting out patch 1, which
is what this series does

Detailed Description
====================
This patch implements unmapped page cache control via preferred
page cache reclaim. The current patch hooks into kswapd and reclaims
page cache if the user has requested for unmapped page control.
This is useful in the following scenario

- In a virtualized environment with cache=writethrough, we see
  double caching - (one in the host and one in the guest). As
  we try to scale guests, cache usage across the system grows.
  The goal of this patch is to reclaim page cache when Linux is running
  as a guest and get the host to hold the page cache and manage it.
  There might be temporary duplication, but in the long run, memory
  in the guests would be used for mapped pages.
- The option is controlled via a boot option and the administrator
  can selectively turn it on, on a need to use basis.

A lot of the code is borrowed from zone_reclaim_mode logic for
__zone_reclaim(). One might argue that the with ballooning and
KSM this feature is not very useful, but even with ballooning,
we need extra logic to balloon multiple VM machines and it is hard
to figure out the correct amount of memory to balloon. With these
patches applied, each guest has a sufficient amount of free memory
available, that can be easily seen and reclaimed by the balloon driver.
The additional memory in the guest can be reused for additional
applications or used to start additional guests/balance memory in
the host.

KSM currently does not de-duplicate host and guest page cache. The goal
of this patch is to help automatically balance unmapped page cache when
instructed to do so.

There are some magic numbers in use in the code, UNMAPPED_PAGE_RATIO
and the number of pages to reclaim when unmapped_page_control argument
is supplied. These numbers were chosen to avoid aggressiveness in
reaping page cache ever so frequently, at the same time providing control.

The sysctl for min_unmapped_ratio provides further control from
within the guest on the amount of unmapped pages to reclaim.



For a single VM - running kernbench

Enabled

Optimal load -j 8 run number 1...
Optimal load -j 8 run number 2...
Optimal load -j 8 run number 3...
Optimal load -j 8 run number 4...
Optimal load -j 8 run number 5...
Average Optimal load -j 8 Run (std deviation):
Elapsed Time 273.726 (1.2683)
User Time 190.014 (0.589941)
System Time 298.758 (1.72574)
Percent CPU 178 (0)
Context Switches 119953 (865.74)
Sleeps 38758 (795.074)

Disabled

Optimal load -j 8 run number 1...
Optimal load -j 8 run number 2...
Optimal load -j 8 run number 3...
Optimal load -j 8 run number 4...
Optimal load -j 8 run number 5...
Average Optimal load -j 8 Run (std deviation):
Elapsed Time 272.672 (0.453178)
User Time 189.7 (0.718157)
System Time 296.77 (0.845606)
Percent CPU 178 (0)
Context Switches 118822 (277.434)
Sleeps 37542.8 (545.922)

More data on the test results with the earlier patch is
at http://www.mail-archive.com/kvm@vger.kernel.org/msg43655.html

---

Balbir Singh (3):
      Move zone_reclaim() outside of CONFIG_NUMA
      Refactor zone_reclaim, move reusable functionality outside
      Provide control over unmapped pages


 include/linux/mmzone.h |    4 +-
 include/linux/swap.h   |    5 +-
 mm/page_alloc.c        |    7 ++-
 mm/vmscan.c            |  109 +++++++++++++++++++++++++++++++++++++++++-------
 4 files changed, 104 insertions(+), 21 deletions(-)

-- 
Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

[PATCH 0/3] Series short description

[Ben Blum]

The following series implements...

---

Ben Blum (3):
      Quick vmalloc vs kmalloc fix to the case where array size > KMALLOC_MAX_SIZE
      Ensures correct concurrent opening/reading of pidlists across pid namespaces
      Adds a read-only "procs" file similar to "tasks" that shows only unique tgids


 include/linux/cgroup.h |   46 +++++-
 kernel/cgroup.c        |  378 ++++++++++++++++++++++++++++++++++--------------
 2 files changed, 309 insertions(+), 115 deletions(-)

[PATCH 0/3] Series short description

[Ben Blum]

The following series implements...

---

Ben Blum (3):
      Quick vmalloc vs kmalloc fix to the case where array size > KMALLOC_MAX_SIZE
      Ensures correct concurrent opening/reading of pidlists across pid namespaces
      Adds a read-only "procs" file similar to "tasks" that shows only unique tgids


 include/linux/cgroup.h |   46 +++++-
 kernel/cgroup.c        |  378 ++++++++++++++++++++++++++++++++++--------------
 2 files changed, 309 insertions(+), 115 deletions(-)

Re: [PATCH 0/3] Series short description

[Grant Likely]

On Thu, Apr 2, 2009 at 1:57 AM, David Miller <davem@davemloft.net> wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
> Date: Wed, 01 Apr 2009 00:16:46 -0600
>
>> Here are the fec_mpc52xx patches which should be picked up for 2.6.29.
>> Patch #1 fixes a dma related BUG_ON() discovered after the merge window
>> opened.  #2 & #3 were original a single patch posted prior to the merge
>> window, but not having a s-o-b line from the original author held them up.
>> In the end I rewrote it from scratch as two patches just so I can get
>> them merged.  #2 makes the driver use net_device_ops, and #3 fixes a NULL
>> dereference.
>>
>> I've tested these patches on several MPC5200 platforms.
>
> All applied, thanks Grant.

Thanks David!

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: [PATCH 0/3] Series short description

[Grant Likely]

On Thu, Apr 2, 2009 at 1:57 AM, David Miller <davem@davemloft.net> wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
> Date: Wed, 01 Apr 2009 00:16:46 -0600
>
>> Here are the fec_mpc52xx patches which should be picked up for 2.6.29.
>> Patch #1 fixes a dma related BUG_ON() discovered after the merge window
>> opened. =A0#2 & #3 were original a single patch posted prior to the merg=
e
>> window, but not having a s-o-b line from the original author held them u=
p.
>> In the end I rewrote it from scratch as two patches just so I can get
>> them merged. =A0#2 makes the driver use net_device_ops, and #3 fixes a N=
ULL
>> dereference.
>>
>> I've tested these patches on several MPC5200 platforms.
>
> All applied, thanks Grant.

Thanks David!

g.

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: [PATCH 0/3] Series short description

[David Miller]

From: Grant Likely <grant.likely@secretlab.ca>
Date: Wed, 01 Apr 2009 00:16:46 -0600

> Here are the fec_mpc52xx patches which should be picked up for 2.6.29.
> Patch #1 fixes a dma related BUG_ON() discovered after the merge window
> opened.  #2 & #3 were original a single patch posted prior to the merge
> window, but not having a s-o-b line from the original author held them up.
> In the end I rewrote it from scratch as two patches just so I can get
> them merged.  #2 makes the driver use net_device_ops, and #3 fixes a NULL
> dereference.
> 
> I've tested these patches on several MPC5200 platforms.

All applied, thanks Grant.

[PATCH 0/3] Series short description

[Grant Likely]

Hi David,

Here are the fec_mpc52xx patches which should be picked up for 2.6.29.
Patch #1 fixes a dma related BUG_ON() discovered after the merge window
opened.  #2 & #3 were original a single patch posted prior to the merge
window, but not having a s-o-b line from the original author held them up.
In the end I rewrote it from scratch as two patches just so I can get
them merged.  #2 makes the driver use net_device_ops, and #3 fixes a NULL
dereference.

I've tested these patches on several MPC5200 platforms.

 drivers/net/fec_mpc52xx.c |   77 +++++++++++++++++++++++++-------------------
 1 files changed, 44 insertions(+), 33 deletions(-)

Cheers,
g.

--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.

[PATCH 0/3] Series short description

[Alexey Starikovskiy]

In order to get notifications from Smart Batteries there is a need to
allow non-AML query handlers in EC driver.
AML query handlers are now found at init time, so there is no need to
look them up in namespace at query time.

-- 
Regards,
Alex.