All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Hemant Pedanekar <hemantp@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Kevin Hilman <khilman@ti.com>, Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH v2 1/3] TI81XX: Prepare for addition of TI814X support
Date: Wed, 21 Sep 2011 13:40:58 -0700	[thread overview]
Message-ID: <20110921204057.GJ2937@atomide.com> (raw)
In-Reply-To: <1316626735-5597-1-git-send-email-hemantp@ti.com>

* Hemant Pedanekar <hemantp@ti.com> [110921 10:05]:
> --- a/arch/arm/mach-omap2/board-ti8168evm.c
> +++ b/arch/arm/mach-omap2/board-ti8168evm.c
> @@ -37,16 +37,16 @@ static void __init ti8168_evm_init(void)
>  
>  static void __init ti8168_evm_map_io(void)
>  {
> -	omap2_set_globals_ti816x();
> -	omapti816x_map_common_io();
> +	omap2_set_globals_ti81xx();
> +	omapti81xx_map_common_io();
>  }
>  
>  MACHINE_START(TI8168EVM, "ti8168evm")
>  	/* Maintainer: Texas Instruments */
>  	.atag_offset	= 0x100,
>  	.map_io		= ti8168_evm_map_io,
> -	.init_early	= ti816x_init_early,
> -	.init_irq	= ti816x_init_irq,
> +	.init_early	= ti81xx_init_early,
> +	.init_irq	= ti81xx_init_irq,
>  	.timer		= &omap3_timer,
>  	.init_machine	= ti8168_evm_init,
>  MACHINE_END

Looks like you still need a minor rebase on the current cleanup
branch as the ti8668_evm_map_io is no longer needed. The cleanup
branch already has Paul's CHIP_IS removal, so that should be
trivial.

Ideally the rename patch would be separate without any functional
changes, maybe you can move the changes and additions to the next
patch?

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] TI81XX: Prepare for addition of TI814X support
Date: Wed, 21 Sep 2011 13:40:58 -0700	[thread overview]
Message-ID: <20110921204057.GJ2937@atomide.com> (raw)
In-Reply-To: <1316626735-5597-1-git-send-email-hemantp@ti.com>

* Hemant Pedanekar <hemantp@ti.com> [110921 10:05]:
> --- a/arch/arm/mach-omap2/board-ti8168evm.c
> +++ b/arch/arm/mach-omap2/board-ti8168evm.c
> @@ -37,16 +37,16 @@ static void __init ti8168_evm_init(void)
>  
>  static void __init ti8168_evm_map_io(void)
>  {
> -	omap2_set_globals_ti816x();
> -	omapti816x_map_common_io();
> +	omap2_set_globals_ti81xx();
> +	omapti81xx_map_common_io();
>  }
>  
>  MACHINE_START(TI8168EVM, "ti8168evm")
>  	/* Maintainer: Texas Instruments */
>  	.atag_offset	= 0x100,
>  	.map_io		= ti8168_evm_map_io,
> -	.init_early	= ti816x_init_early,
> -	.init_irq	= ti816x_init_irq,
> +	.init_early	= ti81xx_init_early,
> +	.init_irq	= ti81xx_init_irq,
>  	.timer		= &omap3_timer,
>  	.init_machine	= ti8168_evm_init,
>  MACHINE_END

Looks like you still need a minor rebase on the current cleanup
branch as the ti8668_evm_map_io is no longer needed. The cleanup
branch already has Paul's CHIP_IS removal, so that should be
trivial.

Ideally the rename patch would be separate without any functional
changes, maybe you can move the changes and additions to the next
patch?

Tony

  reply	other threads:[~2011-09-21 20:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21 17:38 [PATCH v2 1/3] TI81XX: Prepare for addition of TI814X support Hemant Pedanekar
2011-09-21 17:38 ` Hemant Pedanekar
2011-09-21 20:40 ` Tony Lindgren [this message]
2011-09-21 20:40   ` Tony Lindgren
2011-09-22  0:33   ` Pedanekar, Hemant
2011-09-22  0:33     ` Pedanekar, Hemant
2011-09-22 18:21     ` Tony Lindgren
2011-09-22 18:21       ` Tony Lindgren
2011-09-23  0:56       ` Pedanekar, Hemant
2011-09-23  0:56         ` Pedanekar, Hemant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110921204057.GJ2937@atomide.com \
    --to=tony@atomide.com \
    --cc=hemantp@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.