* [PATCH] btrfs/extent_map.c: quiet sparse noise
@ 2011-09-23 1:45 H Hartley Sweeten
2011-09-23 18:58 ` Valdis.Kletnieks
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2011-09-23 1:45 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-btrfs, chris.mason
Quiet the sparse noise:
warning: symbol '__lookup_extent_mapping' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Chris Mason <chris.mason@oracle.com>
linux-btrfs@vger.kernel.org
linux-kernel@vger.kernel.org
---
diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c
index 7c97b33..48004fe 100644
--- a/fs/btrfs/extent_map.c
+++ b/fs/btrfs/extent_map.c
@@ -282,7 +282,7 @@ static u64 range_end(u64 start, u64 len)
return start + len;
}
-struct extent_map *__lookup_extent_mapping(struct extent_map_tree *tree,
+static struct extent_map *__lookup_extent_mapping(struct extent_map_tree *tree,
u64 start, u64 len, int strict)
{
struct extent_map *em;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs/extent_map.c: quiet sparse noise
2011-09-23 1:45 [PATCH] btrfs/extent_map.c: quiet sparse noise H Hartley Sweeten
@ 2011-09-23 18:58 ` Valdis.Kletnieks
0 siblings, 0 replies; 2+ messages in thread
From: Valdis.Kletnieks @ 2011-09-23 18:58 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, linux-btrfs, chris.mason
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
On Thu, 22 Sep 2011 18:45:56 PDT, H Hartley Sweeten said:
> Quiet the sparse noise:
>
> warning: symbol '__lookup_extent_mapping' was not declared. Should it be static?
Patch itself is correct, changelog is bad. You're not quieting sparse noise,
you're making a declaration static because it doesn't need external visibility.
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-23 18:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-23 1:45 [PATCH] btrfs/extent_map.c: quiet sparse noise H Hartley Sweeten
2011-09-23 18:58 ` Valdis.Kletnieks
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.