* parse_config_data()...
@ 2011-09-22 18:30 Mukesh Rathor
2011-09-23 2:01 ` parse_config_data() Mukesh Rathor
0 siblings, 1 reply; 3+ messages in thread
From: Mukesh Rathor @ 2011-09-22 18:30 UTC (permalink / raw)
To: Xen-devel; +Cc: stefano.stabellini
Hi Stefano,
In parse_config_data():
init_create_info(c_info); <--- sets hvm and hap to 1, then:.
c_info->hvm = 0;
if (!xlu_cfg_get_string (config, "builder", &buf) &&
!strncmp(buf, "hvm", strlen(buf)))
c_info->hvm = 1;
if (!xlu_cfg_get_long (config, "hap", &l)) <-------- already 1
c_info->hap = l; <--- letter 'el'
no big deal, but just confusing for someone reading the code...
thanks,
Mukesh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: parse_config_data()...
2011-09-22 18:30 parse_config_data() Mukesh Rathor
@ 2011-09-23 2:01 ` Mukesh Rathor
2011-09-23 10:25 ` parse_config_data() Stefano Stabellini
0 siblings, 1 reply; 3+ messages in thread
From: Mukesh Rathor @ 2011-09-23 2:01 UTC (permalink / raw)
To: Mukesh Rathor; +Cc: Xen-devel, stefano.stabellini
On Thu, 22 Sep 2011 11:30:48 -0700
Mukesh Rathor <mukesh.rathor@oracle.com> wrote:
> Hi Stefano,
>
> In parse_config_data():
>
> init_create_info(c_info); <--- sets hvm and hap to 1, then:.
>
> c_info->hvm = 0;
> if (!xlu_cfg_get_string (config, "builder", &buf) &&
> !strncmp(buf, "hvm", strlen(buf)))
> c_info->hvm = 1;
>
> if (!xlu_cfg_get_long (config, "hap", &l)) <-------- already 1
> c_info->hap = l; <--- letter 'el'
>
>
> no big deal, but just confusing for someone reading the code...
>
> thanks,
> Mukesh
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
Never mind, my bad... thanks, Mukesh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: parse_config_data()...
2011-09-23 2:01 ` parse_config_data() Mukesh Rathor
@ 2011-09-23 10:25 ` Stefano Stabellini
0 siblings, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2011-09-23 10:25 UTC (permalink / raw)
To: Mukesh Rathor; +Cc: Xen-devel, Stabellini
On Fri, 23 Sep 2011, Mukesh Rathor wrote:
> On Thu, 22 Sep 2011 11:30:48 -0700
> Mukesh Rathor <mukesh.rathor@oracle.com> wrote:
>
> > Hi Stefano,
> >
> > In parse_config_data():
> >
> > init_create_info(c_info); <--- sets hvm and hap to 1, then:.
> >
> > c_info->hvm = 0;
> > if (!xlu_cfg_get_string (config, "builder", &buf) &&
> > !strncmp(buf, "hvm", strlen(buf)))
> > c_info->hvm = 1;
> >
> > if (!xlu_cfg_get_long (config, "hap", &l)) <-------- already 1
> > c_info->hap = l; <--- letter 'el'
> >
> >
> > no big deal, but just confusing for someone reading the code...
> >
> > thanks,
> > Mukesh
>
> Never mind, my bad... thanks, Mukesh
>
no problems :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-23 10:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-22 18:30 parse_config_data() Mukesh Rathor
2011-09-23 2:01 ` parse_config_data() Mukesh Rathor
2011-09-23 10:25 ` parse_config_data() Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.