From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] da830: emac: add support for RMII
Date: Fri, 30 Sep 2011 11:48:13 -0400 [thread overview]
Message-ID: <201109301148.14676.vapier@gentoo.org> (raw)
In-Reply-To: <1317383832-23480-3-git-send-email-nagabhushana.netagunte@ti.com>
On Friday, September 30, 2011 07:57:10 nagabhushana.netagunte at ti.com wrote:
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -246,7 +246,7 @@ static int gen_get_link_speed(int phy_addr)
> if (davinci_eth_phy_read(phy_addr, MII_STATUS_REG, &tmp) &&
> (tmp & 0x04)) {
> #if defined(CONFIG_DRIVER_TI_EMAC_USE_RMII) && \
there's a common CONFIG_RMII symbol already ...
> - defined(CONFIG_MACH_DAVINCI_DA850_EVM)
> + defined(CONFIG_MACH_DAVINCI_DA8XX_EVM)
maybe it's just me, but board level defines in an emac driver make no sense
-mike
next prev parent reply other threads:[~2011-09-30 15:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 11:57 [U-Boot] [PATCH 0/4] davinci: addition of emac features nagabhushana.netagunte at ti.com
2011-09-30 11:57 ` [U-Boot] [PATCH 1/4] davinci: emac: add new features to autonegotiate for EMAC nagabhushana.netagunte at ti.com
2011-09-30 21:07 ` Laurence Withers
2011-10-04 13:53 ` Netagunte, Nagabhushana
2011-10-11 7:00 ` Hadli, Manjunath
2011-09-30 11:57 ` [U-Boot] [PATCH 2/4] da830: emac: add support for RMII nagabhushana.netagunte at ti.com
2011-09-30 15:48 ` Mike Frysinger [this message]
2011-10-02 8:38 ` Igor Grinberg
2011-10-03 14:07 ` Laurence Withers
2011-09-30 11:57 ` [U-Boot] [PATCH 3/4] davinci: emac: add support for more than 1 PHYs nagabhushana.netagunte at ti.com
2011-09-30 20:29 ` Laurence Withers
2011-10-11 6:57 ` Hadli, Manjunath
2011-10-06 21:16 ` Wolfgang Denk
2011-09-30 11:57 ` [U-Boot] [PATCH 4/4] davinci: remove obsolete macro CONFIG_EMAC_MDIO_PHY_NUM nagabhushana.netagunte at ti.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109301148.14676.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.