From: Laurence Withers <lwithers@guralp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] davinci: emac: add support for more than 1 PHYs
Date: Fri, 30 Sep 2011 20:29:30 +0000 [thread overview]
Message-ID: <20110930202929.GA15470@lwithers.me.uk> (raw)
In-Reply-To: <1317383832-23480-4-git-send-email-nagabhushana.netagunte@ti.com>
On Fri, Sep 30, 2011 at 05:27:11PM +0530, nagabhushana.netagunte at ti.com wrote:
> add support for more than 1 PHYs. Many of the davinci platforms have more
> than 1 PHYs on thier board. This patch extends support in davinci emac
> driver for upto 3 PHYs.
As a nitpick, there is a typo in "thier", which should be "their".
But a real question: where does the number 3 come from? It seems rather
arbitrary, at least without any explanatory comments. The MDIO interface can
support up to 31 devices, so perhaps you should allow for that many PHYs?
(Or perhaps a limit configurable with a #define, as it would seem wasteful
to allocate memory for 31 phy_t structures when I doubt there are any boards
that could truly take advantage of that).
Bye for now,
--
Laurence Withers, <lwithers@guralp.com> http://www.guralp.com/
Direct tel:+447753988197 or tel:+443333408643 Software Engineer
General support queries: <support@guralp.com> CMG-DCM CMG-EAM CMG-NAM
next prev parent reply other threads:[~2011-09-30 20:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 11:57 [U-Boot] [PATCH 0/4] davinci: addition of emac features nagabhushana.netagunte at ti.com
2011-09-30 11:57 ` [U-Boot] [PATCH 1/4] davinci: emac: add new features to autonegotiate for EMAC nagabhushana.netagunte at ti.com
2011-09-30 21:07 ` Laurence Withers
2011-10-04 13:53 ` Netagunte, Nagabhushana
2011-10-11 7:00 ` Hadli, Manjunath
2011-09-30 11:57 ` [U-Boot] [PATCH 2/4] da830: emac: add support for RMII nagabhushana.netagunte at ti.com
2011-09-30 15:48 ` Mike Frysinger
2011-10-02 8:38 ` Igor Grinberg
2011-10-03 14:07 ` Laurence Withers
2011-09-30 11:57 ` [U-Boot] [PATCH 3/4] davinci: emac: add support for more than 1 PHYs nagabhushana.netagunte at ti.com
2011-09-30 20:29 ` Laurence Withers [this message]
2011-10-11 6:57 ` Hadli, Manjunath
2011-10-06 21:16 ` Wolfgang Denk
2011-09-30 11:57 ` [U-Boot] [PATCH 4/4] davinci: remove obsolete macro CONFIG_EMAC_MDIO_PHY_NUM nagabhushana.netagunte at ti.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930202929.GA15470@lwithers.me.uk \
--to=lwithers@guralp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.