All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "T Krishnamoorthy, Balaji" <balajitk@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mmc@vger.kernel.org, kishore.kadiyala@ti.com, vishp@ti.com
Subject: Re: [PATCH 1/2] arm: omap4: hsmmc: Fix Pbias configuration on regulator OFF
Date: Fri, 30 Sep 2011 10:41:48 -0700	[thread overview]
Message-ID: <20110930174147.GJ6324@atomide.com> (raw)
In-Reply-To: <CANrkHUaJr3L+y33j=za-j6Kcsv1dy-rt0URc_9GgzpfOjqPTZA@mail.gmail.com>

* T Krishnamoorthy, Balaji <balajitk@ti.com> [110930 07:43]:
> On Thu, Sep 29, 2011 at 9:50 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Balaji T K <balajitk@ti.com> [110929 07:11]:
> >> MMC1 data line IO's are powered down in before set regulator function.
> >> IO's should not be powered ON when regulator is OFF.
> >> Keep the IO's in power pown mode after regulator OFF.
> >> Delete incorrect comments which are not applicable for OMAP4.
> >
> > Care to check how this is different from what I added into fixes
> > branch as commit 3fe8df93b0992199e3a0026fc51e90b705f94e40?
> >
> > Is this a separate issue?
> 
> Yes.
> commit 3fe8df93b fixes USBC1 configuration.
> USBC1 IO was configured unnecessarily for MMC IO.
> 
> This patch keeps the MMC IO's in power down after regulator OFF
> otherwise it generates VMODE_ERROR due to mismatch in input (regulator)
> voltage and MMC IO drive voltage.

OK, can you please refresh it against the current fixes branch?

Thanks,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: omap4: hsmmc: Fix Pbias configuration on regulator OFF
Date: Fri, 30 Sep 2011 10:41:48 -0700	[thread overview]
Message-ID: <20110930174147.GJ6324@atomide.com> (raw)
In-Reply-To: <CANrkHUaJr3L+y33j=za-j6Kcsv1dy-rt0URc_9GgzpfOjqPTZA@mail.gmail.com>

* T Krishnamoorthy, Balaji <balajitk@ti.com> [110930 07:43]:
> On Thu, Sep 29, 2011 at 9:50 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Balaji T K <balajitk@ti.com> [110929 07:11]:
> >> MMC1 data line IO's are powered down in before set regulator function.
> >> IO's should not be powered ON when regulator is OFF.
> >> Keep the IO's in power pown mode after regulator OFF.
> >> Delete incorrect comments which are not applicable for OMAP4.
> >
> > Care to check how this is different from what I added into fixes
> > branch as commit 3fe8df93b0992199e3a0026fc51e90b705f94e40?
> >
> > Is this a separate issue?
> 
> Yes.
> commit 3fe8df93b fixes USBC1 configuration.
> USBC1 IO was configured unnecessarily for MMC IO.
> 
> This patch keeps the MMC IO's in power down after regulator OFF
> otherwise it generates VMODE_ERROR due to mismatch in input (regulator)
> voltage and MMC IO drive voltage.

OK, can you please refresh it against the current fixes branch?

Thanks,

Tony

  reply	other threads:[~2011-09-30 17:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-29 14:44 [PATCH 0/2] arm: omap4: hsmmc: pbias fixes Balaji T K
2011-09-29 14:44 ` Balaji T K
2011-09-29 14:44 ` [PATCH 1/2] arm: omap4: hsmmc: Fix Pbias configuration on regulator OFF Balaji T K
2011-09-29 14:44   ` Balaji T K
2011-09-29 16:20   ` Tony Lindgren
2011-09-29 16:20     ` Tony Lindgren
2011-09-30 15:16     ` T Krishnamoorthy, Balaji
2011-09-30 15:16       ` T Krishnamoorthy, Balaji
2011-09-30 17:41       ` Tony Lindgren [this message]
2011-09-30 17:41         ` Tony Lindgren
2011-09-29 14:45 ` [PATCH 2/2] arm: omap4: hsmmc: configure SDMMC1_DR0 properly Balaji T K
2011-09-29 14:45   ` Balaji T K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110930174147.GJ6324@atomide.com \
    --to=tony@atomide.com \
    --cc=balajitk@ti.com \
    --cc=kishore.kadiyala@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=vishp@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.