[Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Juan Quintela]

Hi

This patch adds copyrights to all the machine description files for
all architectures supported. (this is done on top of my vmstate-cpus
series patches) The problem?

- What should we put as "copyirght" owners.

Althought I modified almost every line of the files, mostly of the
changes are a conversion, so claiming myself as the only "copyright"
owner sounds at least pretentious, and more than probably false.

I tried to "dig" into the git logs and tried to came with "whoever"
commit the initial cpu_save/load foar each architecture.  I have put
them as:

 * Based on qemu-file support done by:
 *   Richard Henderson <rth@twiddle.net>

But I would preffer that the persons involved state what copyright
notice they want, name, address, year(s), etc.  (Some architectures
already have a propper copyright notice, I didn't touch them), and
others had an empty file (I put mine there on the previosu series).

Several of the logs are from the svn days, and then I don't know if
the person was the committer, or the author.  If anyone contributed
to the functionality and want to add its copyright, please told me.

To make things more complicated, when machine.c files were split from
vl.c, they didn't carry any copyright notice at all, should we copy
back everything from vl.c?

To make things more complicated, it looks like Thiemo Seufer did the
original mips support, and he passed away.  So he can't obviously
comment.

Anthony asked me to send a patch to the list, asking form comments.

alpha:
CC: Richard Henderson <rth@twiddle.net>

arm:
CC: Andrzej Zaborowski <andrew.zaborowski@intel.com>

  (it appears as balrog, but on irc channel peter told me that balrog
  has him)

cris:
CC: Edgar E. Iglesias <edgar.iglesias@gmail.com>

i386:

Fabrice Bellard?

 * Copyright (c) 2003-2008 Fabrice Bellard

Didn't cc'd him because he left project/didn't have email address on
MAINTAINERS/vl.c.  If you think that I should cc'd to him, just let me
know.

lm32:

CC: Michael Walle <michael@walle.cc>

mips:

Thiemo Seufer?

ppc & sparc:

CC: Blue Swirl <blauwirbel@gmail.com>


What do you think, what should we do?  Juan.

Signed-off-by: Juan Quintela <quintela@redhat.com>

---
 target-alpha/vmstate-cpu.c |   15 +++++++++++++++
 target-arm/vmstate-cpu.c   |   15 +++++++++++++++
 target-cris/vmstate-cpu.c  |   15 +++++++++++++++
 target-i386/vmstate-cpu.c  |   15 +++++++++++++++
 target-lm32/vmstate-cpu.c  |   15 +++++++++++++++
 target-mips/vmstate-cpu.c  |   15 +++++++++++++++
 target-ppc/vmstate-cpu.c   |   15 +++++++++++++++
 target-sparc/vmstate-cpu.c |   15 +++++++++++++++
 8 files changed, 120 insertions(+), 0 deletions(-)

diff --git a/target-alpha/vmstate-cpu.c b/target-alpha/vmstate-cpu.c
index 156cb74..5525fab 100644
--- a/target-alpha/vmstate-cpu.c
+++ b/target-alpha/vmstate-cpu.c
@@ -1,3 +1,18 @@
+/*
+ * Migration support for alpha cpus
+ *
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Based on qemu-file support done by:
+ *   Richard Henderson <rth@twiddle.net>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2.  See
+ * the COPYING file in the top-level directory.
+ */
+
 #include "hw/hw.h"

 static int get_fpcr(QEMUFile *f, void *opaque, size_t size)
diff --git a/target-arm/vmstate-cpu.c b/target-arm/vmstate-cpu.c
index 836d9ed..4435540 100644
--- a/target-arm/vmstate-cpu.c
+++ b/target-arm/vmstate-cpu.c
@@ -1,3 +1,18 @@
+/*
+ * Migration support for arm cpus
+ *
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Based on qemu-file support done by:
+ *  Andrzej Zaborowski <andrew.zaborowski@intel.com>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2.  See
+ * the COPYING file in the top-level directory.
+ */
+
 #include "hw/hw.h"

 static bool feature_vfp_needed(void *opaque)
diff --git a/target-cris/vmstate-cpu.c b/target-cris/vmstate-cpu.c
index 0f732d3..bbccb8b 100644
--- a/target-cris/vmstate-cpu.c
+++ b/target-cris/vmstate-cpu.c
@@ -1,3 +1,18 @@
+/*
+ * Migration support for cris cpus
+ *
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Based on qemu-file support done by:
+ *  Edgar E. Iglesias <edgar.iglesias@gmail.com>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2.  See
+ * the COPYING file in the top-level directory.
+ */
+
 #include "hw/hw.h"

 static const VMStateDescription vmstate_tlbset = {
diff --git a/target-i386/vmstate-cpu.c b/target-i386/vmstate-cpu.c
index 838983e..8bb7ca8 100644
--- a/target-i386/vmstate-cpu.c
+++ b/target-i386/vmstate-cpu.c
@@ -1,3 +1,18 @@
+/*
+ * Migration support for x86 cpus
+ *
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Based on qemu-file support done by:
+ *  Fabrice Bellard
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2.  See
+ * the COPYING file in the top-level directory.
+ */
+
 #include "hw/hw.h"

 static const VMStateDescription vmstate_segment = {
diff --git a/target-lm32/vmstate-cpu.c b/target-lm32/vmstate-cpu.c
index 60b4b29..99ce957 100644
--- a/target-lm32/vmstate-cpu.c
+++ b/target-lm32/vmstate-cpu.c
@@ -1,3 +1,18 @@
+/*
+ * Migration support for lm32 cpus
+ *
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Based on qemu-file support done by:
+ *  Michael Walle <michael@walle.cc>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2.  See
+ * the COPYING file in the top-level directory.
+ */
+
 #include "hw/hw.h"

 const VMStateDescription vmstate_cpu = {
diff --git a/target-mips/vmstate-cpu.c b/target-mips/vmstate-cpu.c
index d6d7830..6b63af6 100644
--- a/target-mips/vmstate-cpu.c
+++ b/target-mips/vmstate-cpu.c
@@ -1,3 +1,18 @@
+/*
+ * Migration support for mips cpus
+ *
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Based on qemu-file support done by:
+ *  Thiemo Seufer
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2.  See
+ * the COPYING file in the top-level directory.
+ */
+
 #include "hw/hw.h"

 static const VMStateDescription vmstate_tc = {
diff --git a/target-ppc/vmstate-cpu.c b/target-ppc/vmstate-cpu.c
index 1664d32..48dbc1a 100644
--- a/target-ppc/vmstate-cpu.c
+++ b/target-ppc/vmstate-cpu.c
@@ -1,3 +1,18 @@
+/*
+ * Migration support for ppc cpus
+ *
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Based on qemu-file support done by:
+ *  Blue Swirl <blauwirbel@gmail.com>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2.  See
+ * the COPYING file in the top-level directory.
+ */
+
 #include "hw/hw.h"

 static const VMStateDescription vmstate_tlb = {
diff --git a/target-sparc/vmstate-cpu.c b/target-sparc/vmstate-cpu.c
index 259db19..35f9b0f 100644
--- a/target-sparc/vmstate-cpu.c
+++ b/target-sparc/vmstate-cpu.c
@@ -1,3 +1,18 @@
+/*
+ * Migration support for sparc cpus
+ *
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Based on qemu-file support done by:
+ *  Blue Swirl <blauwirbel@gmail.com>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2.  See
+ * the COPYING file in the top-level directory.
+ */
+
 #include "hw/hw.h"

 static const VMStateDescription vmstate_cpu_timer = {
-- 
1.7.7

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Paolo Bonzini]

On 11/07/2011 06:38 PM, Juan Quintela wrote:
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.

... or later please.

Paolo

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Edgar E. Iglesias]

On Mon, Nov 07, 2011 at 06:38:49PM +0100, Juan Quintela wrote:
> Hi
> 
> This patch adds copyrights to all the machine description files for
> all architectures supported. (this is done on top of my vmstate-cpus
> series patches) The problem?
> 
> - What should we put as "copyirght" owners.
> 
> Althought I modified almost every line of the files, mostly of the
> changes are a conversion, so claiming myself as the only "copyright"
> owner sounds at least pretentious, and more than probably false.
> 
> I tried to "dig" into the git logs and tried to came with "whoever"
> commit the initial cpu_save/load foar each architecture.  I have put
> them as:
> 
>  * Based on qemu-file support done by:
>  *   Richard Henderson <rth@twiddle.net>
> 
> But I would preffer that the persons involved state what copyright
> notice they want, name, address, year(s), etc.  (Some architectures
> already have a propper copyright notice, I didn't touch them), and
> others had an empty file (I put mine there on the previosu series).
> 
> Several of the logs are from the svn days, and then I don't know if
> the person was the committer, or the author.  If anyone contributed
> to the functionality and want to add its copyright, please told me.
> 
> To make things more complicated, when machine.c files were split from
> vl.c, they didn't carry any copyright notice at all, should we copy
> back everything from vl.c?
> 
> To make things more complicated, it looks like Thiemo Seufer did the
> original mips support, and he passed away.  So he can't obviously
> comment.
> 
> Anthony asked me to send a patch to the list, asking form comments.
> 
> alpha:
> CC: Richard Henderson <rth@twiddle.net>
> 
> arm:
> CC: Andrzej Zaborowski <andrew.zaborowski@intel.com>
> 
>   (it appears as balrog, but on irc channel peter told me that balrog
>   has him)
> 
> cris:
> CC: Edgar E. Iglesias <edgar.iglesias@gmail.com>

...


>  static bool feature_vfp_needed(void *opaque)
> diff --git a/target-cris/vmstate-cpu.c b/target-cris/vmstate-cpu.c
> index 0f732d3..bbccb8b 100644
> --- a/target-cris/vmstate-cpu.c
> +++ b/target-cris/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for cris cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <quintela@redhat.com>
> + *
> + * Based on qemu-file support done by:
> + *  Edgar E. Iglesias <edgar.iglesias@gmail.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
> 
>  static const VMStateDescription vmstate_tlbset = {


Hi Juan,

This is OK with me

Thanks,
Edgar

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Anthony Liguori]

On 11/07/2011 12:39 PM, Edgar E. Iglesias wrote:
> On Mon, Nov 07, 2011 at 06:38:49PM +0100, Juan Quintela wrote:
>>   static bool feature_vfp_needed(void *opaque)
>> diff --git a/target-cris/vmstate-cpu.c b/target-cris/vmstate-cpu.c
>> index 0f732d3..bbccb8b 100644
>> --- a/target-cris/vmstate-cpu.c
>> +++ b/target-cris/vmstate-cpu.c
>> @@ -1,3 +1,18 @@
>> +/*
>> + * Migration support for cris cpus
>> + *
>> + * Copyright (C) 2011 Red Hat, Inc.
>> + *
>> + * Author(s):
>> + *  Juan Quintela<quintela@redhat.com>
>> + *
>> + * Based on qemu-file support done by:
>> + *  Edgar E. Iglesias<edgar.iglesias@gmail.com>
>> + *
>> + * This work is licensed under the terms of the GNU GPL, version 2.  See
>> + * the COPYING file in the top-level directory.
>> + */
>> +
>>   #include "hw/hw.h"
>>
>>   static const VMStateDescription vmstate_tlbset = {
>
>
> Hi Juan,
>
> This is OK with me

Please give an explicit Acked-by for the commit.  I'd like there to be a clear 
history in git of these types of changes.

Regards,

Anthony Liguori

>
> Thanks,
> Edgar
>

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Juan Quintela]

Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 11/07/2011 06:38 PM, Juan Quintela wrote:
>> + * This work is licensed under the terms of the GNU GPL, version 2.  See
>> + * the COPYING file in the top-level directory.
>
> ... or later please.

I thougth I had forgot something to ask O:-)

Later, Juan.

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Richard Henderson]

On 11/07/2011 09:38 AM, Juan Quintela wrote:
> alpha:
> CC: Richard Henderson <rth@twiddle.net>

Acked-by: Richard Henderson <rth@twiddle.net>


r~

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Michael Walle]

Am Montag 07 November 2011, 18:38:49 schrieb Juan Quintela:
> diff --git a/target-lm32/vmstate-cpu.c b/target-lm32/vmstate-cpu.c
> index 60b4b29..99ce957 100644
> --- a/target-lm32/vmstate-cpu.c
> +++ b/target-lm32/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for lm32 cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <quintela@redhat.com>
> + *
> + * Based on qemu-file support done by:
> + *  Michael Walle <michael@walle.cc>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
> 
>  const VMStateDescription vmstate_cpu = {

Acked-By: Michael Walle <michael@walle.cc>

-- 
Michael

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Edgar E. Iglesias]

On Mon, Nov 07, 2011 at 01:29:35PM -0600, Anthony Liguori wrote:
> On 11/07/2011 12:39 PM, Edgar E. Iglesias wrote:
> >On Mon, Nov 07, 2011 at 06:38:49PM +0100, Juan Quintela wrote:
> >>  static bool feature_vfp_needed(void *opaque)
> >>diff --git a/target-cris/vmstate-cpu.c b/target-cris/vmstate-cpu.c
> >>index 0f732d3..bbccb8b 100644
> >>--- a/target-cris/vmstate-cpu.c
> >>+++ b/target-cris/vmstate-cpu.c
> >>@@ -1,3 +1,18 @@
> >>+/*
> >>+ * Migration support for cris cpus
> >>+ *
> >>+ * Copyright (C) 2011 Red Hat, Inc.
> >>+ *
> >>+ * Author(s):
> >>+ *  Juan Quintela<quintela@redhat.com>
> >>+ *
> >>+ * Based on qemu-file support done by:
> >>+ *  Edgar E. Iglesias<edgar.iglesias@gmail.com>
> >>+ *
> >>+ * This work is licensed under the terms of the GNU GPL, version 2.  See
> >>+ * the COPYING file in the top-level directory.
> >>+ */
> >>+
> >>  #include "hw/hw.h"
> >>
> >>  static const VMStateDescription vmstate_tlbset = {
> >
> >
> >Hi Juan,
> >
> >This is OK with me
> 
> Please give an explicit Acked-by for the commit.  I'd like there to
> be a clear history in git of these types of changes.

OK:

Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>

Cheers

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Peter Maydell]

On 7 November 2011 17:46, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 11/07/2011 06:38 PM, Juan Quintela wrote:
>>
>> + * This work is licensed under the terms of the GNU GPL, version 2.  See
>> + * the COPYING file in the top-level directory.
>
> ... or later please.

Need to be careful here. Marking something previously unmarked as
GPLv2 is pretty clearly OK because the project license is v2 so
the unmarked stuff was contributed either under that or under a
compatible license. Marking as v2+ is on somewhat thinner ice
IMHO and ideally we shouldn't do it without an ack from the
relevant copyright owner.

-- PMM

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Andrzej Zaborowski]

On 7 November 2011 18:38, Juan Quintela <quintela@redhat.com> wrote:
> This patch adds copyrights to all the machine description files for
> all architectures supported. (this is done on top of my vmstate-cpus
> series patches) The problem?
>
> - What should we put as "copyirght" owners.
>
> Althought I modified almost every line of the files, mostly of the
> changes are a conversion, so claiming myself as the only "copyright"
> owner sounds at least pretentious, and more than probably false.
>
> I tried to "dig" into the git logs and tried to came with "whoever"
> commit the initial cpu_save/load foar each architecture.  I have put
> them as:
>
>  * Based on qemu-file support done by:
>  *   Richard Henderson <rth@twiddle.net>
>
> But I would preffer that the persons involved state what copyright
> notice they want, name, address, year(s), etc.  (Some architectures
> already have a propper copyright notice, I didn't touch them), and
> others had an empty file (I put mine there on the previosu series).
>
> Several of the logs are from the svn days, and then I don't know if
> the person was the committer, or the author.  If anyone contributed
> to the functionality and want to add its copyright, please told me.
>
> To make things more complicated, when machine.c files were split from
> vl.c, they didn't carry any copyright notice at all, should we copy
> back everything from vl.c?
>
> To make things more complicated, it looks like Thiemo Seufer did the
> original mips support, and he passed away.  So he can't obviously
> comment.
>
> Anthony asked me to send a patch to the list, asking form comments.

Acked-by: Andrzej Zaborowski <andrew.zaborowski@intel.com>

Cheers

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Paolo Bonzini]

On 11/08/2011 04:39 PM, Peter Maydell wrote:
>>> >>  + * This work is licensed under the terms of the GNU GPL, version 2.  See
>>> >>  + * the COPYING file in the top-level directory.
>> >
>> >  ... or later please.
> Need to be careful here. Marking something previously unmarked as
> GPLv2 is pretty clearly OK because the project license is v2 so
> the unmarked stuff was contributed either under that or under a
> compatible license. Marking as v2+ is on somewhat thinner ice
> IMHO and ideally we shouldn't do it without an ack from the
> relevant copyright owner.

Richard Fontana (who is not our lawyer, but still knows the GPL pretty 
well) posted a while ago his reasoning as to why it should be safe to 
consider files without a header to be GPLv2+.  Of course this is only as 
long as they do not contain GPLv2-only code from non-QEMU sources.

Paolo

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Blue Swirl]

On Mon, Nov 7, 2011 at 17:38, Juan Quintela <quintela@redhat.com> wrote:
> Hi
>
> This patch adds copyrights to all the machine description files for
> all architectures supported. (this is done on top of my vmstate-cpus
> series patches) The problem?
>
> - What should we put as "copyirght" owners.
>
> Althought I modified almost every line of the files, mostly of the
> changes are a conversion, so claiming myself as the only "copyright"
> owner sounds at least pretentious, and more than probably false.
>
> I tried to "dig" into the git logs and tried to came with "whoever"
> commit the initial cpu_save/load foar each architecture.  I have put
> them as:
>
>  * Based on qemu-file support done by:
>  *   Richard Henderson <rth@twiddle.net>

I don't think this is correct at all.

> But I would preffer that the persons involved state what copyright
> notice they want, name, address, year(s), etc.  (Some architectures
> already have a propper copyright notice, I didn't touch them), and
> others had an empty file (I put mine there on the previosu series).
>
> Several of the logs are from the svn days, and then I don't know if
> the person was the committer, or the author.  If anyone contributed
> to the functionality and want to add its copyright, please told me.
>
> To make things more complicated, when machine.c files were split from
> vl.c, they didn't carry any copyright notice at all, should we copy
> back everything from vl.c?

Yes, vl.c says Copyright (c) 2003-2008 Fabrice Bellard and its license
is BSD like, not GPLv2only. I'd use those as a starting point for
machine files originating from vl.c.

> To make things more complicated, it looks like Thiemo Seufer did the
> original mips support, and he passed away.  So he can't obviously
> comment.
>
> Anthony asked me to send a patch to the list, asking form comments.
>
> alpha:
> CC: Richard Henderson <rth@twiddle.net>
>
> arm:
> CC: Andrzej Zaborowski <andrew.zaborowski@intel.com>
>
>  (it appears as balrog, but on irc channel peter told me that balrog
>  has him)
>
> cris:
> CC: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>
> i386:
>
> Fabrice Bellard?
>
>  * Copyright (c) 2003-2008 Fabrice Bellard
>
> Didn't cc'd him because he left project/didn't have email address on
> MAINTAINERS/vl.c.  If you think that I should cc'd to him, just let me
> know.

Yes.

> lm32:
>
> CC: Michael Walle <michael@walle.cc>
>
> mips:
>
> Thiemo Seufer?
>
> ppc & sparc:
>
> CC: Blue Swirl <blauwirbel@gmail.com>

Sparc: I think I was behind e80cfcfc8884400e826328b772971913a14d0f44
aka SVN 1179 but Fabrice's hand was there too especially in later
commits.

PPC: OK except for license. Most definitely Nack for GPLv2only.

>
> What do you think, what should we do?  Juan.

In general the approach is fine.

> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> ---
>  target-alpha/vmstate-cpu.c |   15 +++++++++++++++
>  target-arm/vmstate-cpu.c   |   15 +++++++++++++++
>  target-cris/vmstate-cpu.c  |   15 +++++++++++++++
>  target-i386/vmstate-cpu.c  |   15 +++++++++++++++
>  target-lm32/vmstate-cpu.c  |   15 +++++++++++++++
>  target-mips/vmstate-cpu.c  |   15 +++++++++++++++
>  target-ppc/vmstate-cpu.c   |   15 +++++++++++++++
>  target-sparc/vmstate-cpu.c |   15 +++++++++++++++
>  8 files changed, 120 insertions(+), 0 deletions(-)
>
> diff --git a/target-alpha/vmstate-cpu.c b/target-alpha/vmstate-cpu.c
> index 156cb74..5525fab 100644
> --- a/target-alpha/vmstate-cpu.c
> +++ b/target-alpha/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for alpha cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <quintela@redhat.com>
> + *
> + * Based on qemu-file support done by:
> + *   Richard Henderson <rth@twiddle.net>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static int get_fpcr(QEMUFile *f, void *opaque, size_t size)
> diff --git a/target-arm/vmstate-cpu.c b/target-arm/vmstate-cpu.c
> index 836d9ed..4435540 100644
> --- a/target-arm/vmstate-cpu.c
> +++ b/target-arm/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for arm cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <quintela@redhat.com>
> + *
> + * Based on qemu-file support done by:
> + *  Andrzej Zaborowski <andrew.zaborowski@intel.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static bool feature_vfp_needed(void *opaque)
> diff --git a/target-cris/vmstate-cpu.c b/target-cris/vmstate-cpu.c
> index 0f732d3..bbccb8b 100644
> --- a/target-cris/vmstate-cpu.c
> +++ b/target-cris/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for cris cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <quintela@redhat.com>
> + *
> + * Based on qemu-file support done by:
> + *  Edgar E. Iglesias <edgar.iglesias@gmail.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static const VMStateDescription vmstate_tlbset = {
> diff --git a/target-i386/vmstate-cpu.c b/target-i386/vmstate-cpu.c
> index 838983e..8bb7ca8 100644
> --- a/target-i386/vmstate-cpu.c
> +++ b/target-i386/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for x86 cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <quintela@redhat.com>
> + *
> + * Based on qemu-file support done by:
> + *  Fabrice Bellard
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static const VMStateDescription vmstate_segment = {
> diff --git a/target-lm32/vmstate-cpu.c b/target-lm32/vmstate-cpu.c
> index 60b4b29..99ce957 100644
> --- a/target-lm32/vmstate-cpu.c
> +++ b/target-lm32/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for lm32 cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <quintela@redhat.com>
> + *
> + * Based on qemu-file support done by:
> + *  Michael Walle <michael@walle.cc>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  const VMStateDescription vmstate_cpu = {
> diff --git a/target-mips/vmstate-cpu.c b/target-mips/vmstate-cpu.c
> index d6d7830..6b63af6 100644
> --- a/target-mips/vmstate-cpu.c
> +++ b/target-mips/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for mips cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <quintela@redhat.com>
> + *
> + * Based on qemu-file support done by:
> + *  Thiemo Seufer
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static const VMStateDescription vmstate_tc = {
> diff --git a/target-ppc/vmstate-cpu.c b/target-ppc/vmstate-cpu.c
> index 1664d32..48dbc1a 100644
> --- a/target-ppc/vmstate-cpu.c
> +++ b/target-ppc/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for ppc cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <quintela@redhat.com>
> + *
> + * Based on qemu-file support done by:
> + *  Blue Swirl <blauwirbel@gmail.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static const VMStateDescription vmstate_tlb = {
> diff --git a/target-sparc/vmstate-cpu.c b/target-sparc/vmstate-cpu.c
> index 259db19..35f9b0f 100644
> --- a/target-sparc/vmstate-cpu.c
> +++ b/target-sparc/vmstate-cpu.c
> @@ -1,3 +1,18 @@
> +/*
> + * Migration support for sparc cpus
> + *
> + * Copyright (C) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <quintela@redhat.com>
> + *
> + * Based on qemu-file support done by:
> + *  Blue Swirl <blauwirbel@gmail.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + */
> +
>  #include "hw/hw.h"
>
>  static const VMStateDescription vmstate_cpu_timer = {
> --
> 1.7.7
>
>

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Juan Quintela]

Blue Swirl <blauwirbel@gmail.com> wrote:
> On Mon, Nov 7, 2011 at 17:38, Juan Quintela <quintela@redhat.com> wrote:
>> Hi
>>
>> This patch adds copyrights to all the machine description files for
>> all architectures supported. (this is done on top of my vmstate-cpus
>> series patches) The problem?
>>
>> - What should we put as "copyirght" owners.
>>
>> Althought I modified almost every line of the files, mostly of the
>> changes are a conversion, so claiming myself as the only "copyright"
>> owner sounds at least pretentious, and more than probably false.
>>
>> I tried to "dig" into the git logs and tried to came with "whoever"
>> commit the initial cpu_save/load foar each architecture.  I have put
>> them as:
>>
>>  * Based on qemu-file support done by:
>>  *   Richard Henderson <rth@twiddle.net>
>
> I don't think this is correct at all.

I posted it as an example to start the discussion.  If you don't like
it, an specific example of what to do would be perfect O:-)

I think I put it somewhere that I just stole it from
hw/virtio-serial-bus.c (i.e. it is not even mine).

>> But I would preffer that the persons involved state what copyright
>> notice they want, name, address, year(s), etc.  (Some architectures
>> already have a propper copyright notice, I didn't touch them), and
>> others had an empty file (I put mine there on the previosu series).
>>
>> Several of the logs are from the svn days, and then I don't know if
>> the person was the committer, or the author.  If anyone contributed
>> to the functionality and want to add its copyright, please told me.
>>
>> To make things more complicated, when machine.c files were split from
>> vl.c, they didn't carry any copyright notice at all, should we copy
>> back everything from vl.c?
>
> Yes, vl.c says Copyright (c) 2003-2008 Fabrice Bellard and its license
> is BSD like, not GPLv2only. I'd use those as a starting point for
> machine files originating from vl.c.

/*
 * QEMU System Emulator
 *
 * Copyright (c) 2003-2008 Fabrice Bellard
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */


>> To make things more complicated, it looks like Thiemo Seufer did the
>> original mips support, and he passed away.  So he can't obviously
>> comment.
>>
>> Anthony asked me to send a patch to the list, asking form comments.
>>
>> alpha:
>> CC: Richard Henderson <rth@twiddle.net>
>>
>> arm:
>> CC: Andrzej Zaborowski <andrew.zaborowski@intel.com>
>>
>>  (it appears as balrog, but on irc channel peter told me that balrog
>>  has him)
>>
>> cris:
>> CC: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>>
>> i386:
>>
>> Fabrice Bellard?
>>
>>  * Copyright (c) 2003-2008 Fabrice Bellard
>>
>> Didn't cc'd him because he left project/didn't have email address on
>> MAINTAINERS/vl.c.  If you think that I should cc'd to him, just let me
>> know.
>
> Yes.

google says: fabrice@bellard.org

Sending second round later.

>> lm32:
>>
>> CC: Michael Walle <michael@walle.cc>
>>
>> mips:
>>
>> Thiemo Seufer?
>>
>> ppc & sparc:
>>
>> CC: Blue Swirl <blauwirbel@gmail.com>
>
> Sparc: I think I was behind e80cfcfc8884400e826328b772971913a14d0f44
> aka SVN 1179 but Fabrice's hand was there too especially in later
> commits.

Going to send another one with you & Fabrice.

> PPC: OK except for license. Most definitely Nack for GPLv2only.

As Paolo said, once here, it is better to move to GPL2 or later, or you
preffer the one directly from vl.c?

>> What do you think, what should we do?  Juan.
>
> In general the approach is fine.

As everybody cc'd answered by know, sending second round with
suggestions/corrections and adding Fabrice.

Thanks, Juan.

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

[Andreas Färber]

Am 07.11.2011 18:38, schrieb Juan Quintela:
> I tried to "dig" into the git logs and tried to came with "whoever"
> commit the initial cpu_save/load foar each architecture.  I have put
> them as:
> 
>  * Based on qemu-file support done by:
>  *   Richard Henderson <rth@twiddle.net>

I don't really associate much with the term "qemu-file support". Sounds
more like QEMUFile and file system wrapper functions.
savevm or serialization format or the like might be more understandable?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg