* [PATCH net-next] virtio_net: return already tracked tx_fifo_errors via virtnet_getstats()
@ 2011-11-21 19:28 Rick Jones
2011-11-22 0:56 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Rick Jones @ 2011-11-21 19:28 UTC (permalink / raw)
To: netdev, rusty, mst
From: Rick Jones <rick.jones2@hp.com>
Tx_fifo_errors are tracked in start_xmit_ for virtio_net, but not
reported in the tallies returned by virtnet_stats(). Return them
as the rx "sub-stats" rx_length_errors and rx_frame_errors are.
Signed-off-by: Rick Jones <rick.jones2@hp.com>
---
Compiled and booted in a guest, but no tx_fifo_errors generated.
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 4dc9d84..5a96172 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -700,6 +700,7 @@ static struct rtnl_link_stats64 *virtnet_stats(struct net_device *dev,
}
tot->tx_dropped = dev->stats.tx_dropped;
+ tot->tx_fifo_errors = dev->stats.tx_fifo_errors;
tot->rx_dropped = dev->stats.rx_dropped;
tot->rx_length_errors = dev->stats.rx_length_errors;
tot->rx_frame_errors = dev->stats.rx_frame_errors;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] virtio_net: return already tracked tx_fifo_errors via virtnet_getstats()
2011-11-21 19:28 [PATCH net-next] virtio_net: return already tracked tx_fifo_errors via virtnet_getstats() Rick Jones
@ 2011-11-22 0:56 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2011-11-22 0:56 UTC (permalink / raw)
To: Rick Jones, netdev, mst
On Mon, 21 Nov 2011 11:28:17 -0800 (PST), raj@tardy.cup.hp.com (Rick Jones) wrote:
> From: Rick Jones <rick.jones2@hp.com>
>
> Tx_fifo_errors are tracked in start_xmit_ for virtio_net, but not
> reported in the tallies returned by virtnet_stats(). Return them
> as the rx "sub-stats" rx_length_errors and rx_frame_errors are.
>
> Signed-off-by: Rick Jones <rick.jones2@hp.com>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-22 0:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-21 19:28 [PATCH net-next] virtio_net: return already tracked tx_fifo_errors via virtnet_getstats() Rick Jones
2011-11-22 0:56 ` Rusty Russell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.