* [PATCH] PM: fix compile breakage on sh #ifndef CONFIG_PM_RUNTIME
@ 2011-11-21 15:56 Guennadi Liakhovetski
2011-11-21 19:53 ` Rafael J. Wysocki
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Guennadi Liakhovetski @ 2011-11-21 15:56 UTC (permalink / raw)
To: linux-sh
Fix the following compalitaion breakage:
In file included from linux/drivers/sh/pm_runtime.c:15:
linux/include/linux/pm_domain.h: In function 'dev_to_genpd':
linux/include/linux/pm_domain.h:142: error: implicit declaration of function 'ERR_PTR'
linux/include/linux/pm_domain.h:142: warning: return makes pointer from integer without a cast
In file included from linux/include/linux/sh_clk.h:10,
from linux/drivers/sh/pm_runtime.c:19:
linux/include/linux/err.h: At top level:
linux/include/linux/err.h:22: error: conflicting types for 'ERR_PTR'
linux/include/linux/pm_domain.h:142: note: previous implicit declaration of 'ERR_PTR' was here
make[3]: *** [drivers/sh/pm_runtime.o] Error 1
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
index 765083ad..b931682 100644
--- a/include/linux/pm_domain.h
+++ b/include/linux/pm_domain.h
@@ -10,6 +10,7 @@
#define _LINUX_PM_DOMAIN_H
#include <linux/device.h>
+#include <linux/err.h>
enum gpd_status {
GPD_STATE_ACTIVE = 0, /* PM domain is active */
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] PM: fix compile breakage on sh #ifndef CONFIG_PM_RUNTIME
2011-11-21 15:56 [PATCH] PM: fix compile breakage on sh #ifndef CONFIG_PM_RUNTIME Guennadi Liakhovetski
@ 2011-11-21 19:53 ` Rafael J. Wysocki
2011-11-21 23:32 ` Guennadi Liakhovetski
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2011-11-21 19:53 UTC (permalink / raw)
To: linux-sh
On Monday, November 21, 2011, Guennadi Liakhovetski wrote:
> Fix the following compalitaion breakage:
>
> In file included from linux/drivers/sh/pm_runtime.c:15:
> linux/include/linux/pm_domain.h: In function 'dev_to_genpd':
> linux/include/linux/pm_domain.h:142: error: implicit declaration of function 'ERR_PTR'
> linux/include/linux/pm_domain.h:142: warning: return makes pointer from integer without a cast
> In file included from linux/include/linux/sh_clk.h:10,
> from linux/drivers/sh/pm_runtime.c:19:
> linux/include/linux/err.h: At top level:
> linux/include/linux/err.h:22: error: conflicting types for 'ERR_PTR'
> linux/include/linux/pm_domain.h:142: note: previous implicit declaration of 'ERR_PTR' was here
> make[3]: *** [drivers/sh/pm_runtime.o] Error 1
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
This bug only happens if CONFIG_PM_GENERIC_DOMAINS is unset, which doesn't
correspond to the subject. I'm not sure how you reproduced it.
Thanks,
Rafael
> ---
> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> index 765083ad..b931682 100644
> --- a/include/linux/pm_domain.h
> +++ b/include/linux/pm_domain.h
> @@ -10,6 +10,7 @@
> #define _LINUX_PM_DOMAIN_H
>
> #include <linux/device.h>
> +#include <linux/err.h>
>
> enum gpd_status {
> GPD_STATE_ACTIVE = 0, /* PM domain is active */
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PM: fix compile breakage on sh #ifndef CONFIG_PM_RUNTIME
2011-11-21 15:56 [PATCH] PM: fix compile breakage on sh #ifndef CONFIG_PM_RUNTIME Guennadi Liakhovetski
2011-11-21 19:53 ` Rafael J. Wysocki
@ 2011-11-21 23:32 ` Guennadi Liakhovetski
2011-11-22 22:25 ` Rafael J. Wysocki
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Guennadi Liakhovetski @ 2011-11-21 23:32 UTC (permalink / raw)
To: linux-sh
Hi Rafael
On Mon, 21 Nov 2011, Rafael J. Wysocki wrote:
> On Monday, November 21, 2011, Guennadi Liakhovetski wrote:
> > Fix the following compalitaion breakage:
> >
> > In file included from linux/drivers/sh/pm_runtime.c:15:
> > linux/include/linux/pm_domain.h: In function 'dev_to_genpd':
> > linux/include/linux/pm_domain.h:142: error: implicit declaration of function 'ERR_PTR'
> > linux/include/linux/pm_domain.h:142: warning: return makes pointer from integer without a cast
> > In file included from linux/include/linux/sh_clk.h:10,
> > from linux/drivers/sh/pm_runtime.c:19:
> > linux/include/linux/err.h: At top level:
> > linux/include/linux/err.h:22: error: conflicting types for 'ERR_PTR'
> > linux/include/linux/pm_domain.h:142: note: previous implicit declaration of 'ERR_PTR' was here
> > make[3]: *** [drivers/sh/pm_runtime.o] Error 1
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> This bug only happens if CONFIG_PM_GENERIC_DOMAINS is unset, which doesn't
> correspond to the subject. I'm not sure how you reproduced it.
I'll send you both .config's off-list.
Thanks
Guennadi
> Thanks,
> Rafael
>
>
> > ---
> > diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> > index 765083ad..b931682 100644
> > --- a/include/linux/pm_domain.h
> > +++ b/include/linux/pm_domain.h
> > @@ -10,6 +10,7 @@
> > #define _LINUX_PM_DOMAIN_H
> >
> > #include <linux/device.h>
> > +#include <linux/err.h>
> >
> > enum gpd_status {
> > GPD_STATE_ACTIVE = 0, /* PM domain is active */
> >
> >
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PM: fix compile breakage on sh #ifndef CONFIG_PM_RUNTIME
2011-11-21 15:56 [PATCH] PM: fix compile breakage on sh #ifndef CONFIG_PM_RUNTIME Guennadi Liakhovetski
2011-11-21 19:53 ` Rafael J. Wysocki
2011-11-21 23:32 ` Guennadi Liakhovetski
@ 2011-11-22 22:25 ` Rafael J. Wysocki
2011-11-22 22:27 ` Guennadi Liakhovetski
2011-11-22 23:42 ` Rafael J. Wysocki
4 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2011-11-22 22:25 UTC (permalink / raw)
To: linux-sh
On Monday, November 21, 2011, Guennadi Liakhovetski wrote:
> Fix the following compalitaion breakage:
>
> In file included from linux/drivers/sh/pm_runtime.c:15:
> linux/include/linux/pm_domain.h: In function 'dev_to_genpd':
> linux/include/linux/pm_domain.h:142: error: implicit declaration of function 'ERR_PTR'
> linux/include/linux/pm_domain.h:142: warning: return makes pointer from integer without a cast
> In file included from linux/include/linux/sh_clk.h:10,
> from linux/drivers/sh/pm_runtime.c:19:
> linux/include/linux/err.h: At top level:
> linux/include/linux/err.h:22: error: conflicting types for 'ERR_PTR'
> linux/include/linux/pm_domain.h:142: note: previous implicit declaration of 'ERR_PTR' was here
> make[3]: *** [drivers/sh/pm_runtime.o] Error 1
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> index 765083ad..b931682 100644
> --- a/include/linux/pm_domain.h
> +++ b/include/linux/pm_domain.h
> @@ -10,6 +10,7 @@
> #define _LINUX_PM_DOMAIN_H
>
> #include <linux/device.h>
> +#include <linux/err.h>
>
> enum gpd_status {
> GPD_STATE_ACTIVE = 0, /* PM domain is active */
That new #include is only necessary if CONFIG_PM_GENERIC_DOMAINS is unset, right?
Rafael
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PM: fix compile breakage on sh #ifndef CONFIG_PM_RUNTIME
2011-11-21 15:56 [PATCH] PM: fix compile breakage on sh #ifndef CONFIG_PM_RUNTIME Guennadi Liakhovetski
` (2 preceding siblings ...)
2011-11-22 22:25 ` Rafael J. Wysocki
@ 2011-11-22 22:27 ` Guennadi Liakhovetski
2011-11-22 23:42 ` Rafael J. Wysocki
4 siblings, 0 replies; 6+ messages in thread
From: Guennadi Liakhovetski @ 2011-11-22 22:27 UTC (permalink / raw)
To: linux-sh
On Tue, 22 Nov 2011, Rafael J. Wysocki wrote:
> On Monday, November 21, 2011, Guennadi Liakhovetski wrote:
> > Fix the following compalitaion breakage:
> >
> > In file included from linux/drivers/sh/pm_runtime.c:15:
> > linux/include/linux/pm_domain.h: In function 'dev_to_genpd':
> > linux/include/linux/pm_domain.h:142: error: implicit declaration of function 'ERR_PTR'
> > linux/include/linux/pm_domain.h:142: warning: return makes pointer from integer without a cast
> > In file included from linux/include/linux/sh_clk.h:10,
> > from linux/drivers/sh/pm_runtime.c:19:
> > linux/include/linux/err.h: At top level:
> > linux/include/linux/err.h:22: error: conflicting types for 'ERR_PTR'
> > linux/include/linux/pm_domain.h:142: note: previous implicit declaration of 'ERR_PTR' was here
> > make[3]: *** [drivers/sh/pm_runtime.o] Error 1
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > ---
> > diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> > index 765083ad..b931682 100644
> > --- a/include/linux/pm_domain.h
> > +++ b/include/linux/pm_domain.h
> > @@ -10,6 +10,7 @@
> > #define _LINUX_PM_DOMAIN_H
> >
> > #include <linux/device.h>
> > +#include <linux/err.h>
> >
> > enum gpd_status {
> > GPD_STATE_ACTIVE = 0, /* PM domain is active */
>
> That new #include is only necessary if CONFIG_PM_GENERIC_DOMAINS is unset, right?
Yes, I think so.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PM: fix compile breakage on sh #ifndef CONFIG_PM_RUNTIME
2011-11-21 15:56 [PATCH] PM: fix compile breakage on sh #ifndef CONFIG_PM_RUNTIME Guennadi Liakhovetski
` (3 preceding siblings ...)
2011-11-22 22:27 ` Guennadi Liakhovetski
@ 2011-11-22 23:42 ` Rafael J. Wysocki
4 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2011-11-22 23:42 UTC (permalink / raw)
To: linux-sh
On Tuesday, November 22, 2011, Guennadi Liakhovetski wrote:
> On Tue, 22 Nov 2011, Rafael J. Wysocki wrote:
>
> > On Monday, November 21, 2011, Guennadi Liakhovetski wrote:
> > > Fix the following compalitaion breakage:
> > >
> > > In file included from linux/drivers/sh/pm_runtime.c:15:
> > > linux/include/linux/pm_domain.h: In function 'dev_to_genpd':
> > > linux/include/linux/pm_domain.h:142: error: implicit declaration of function 'ERR_PTR'
> > > linux/include/linux/pm_domain.h:142: warning: return makes pointer from integer without a cast
> > > In file included from linux/include/linux/sh_clk.h:10,
> > > from linux/drivers/sh/pm_runtime.c:19:
> > > linux/include/linux/err.h: At top level:
> > > linux/include/linux/err.h:22: error: conflicting types for 'ERR_PTR'
> > > linux/include/linux/pm_domain.h:142: note: previous implicit declaration of 'ERR_PTR' was here
> > > make[3]: *** [drivers/sh/pm_runtime.o] Error 1
> > >
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > > ---
> > > diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> > > index 765083ad..b931682 100644
> > > --- a/include/linux/pm_domain.h
> > > +++ b/include/linux/pm_domain.h
> > > @@ -10,6 +10,7 @@
> > > #define _LINUX_PM_DOMAIN_H
> > >
> > > #include <linux/device.h>
> > > +#include <linux/err.h>
> > >
> > > enum gpd_status {
> > > GPD_STATE_ACTIVE = 0, /* PM domain is active */
> >
> > That new #include is only necessary if CONFIG_PM_GENERIC_DOMAINS is unset, right?
>
> Yes, I think so.
Can you respin the patch with that in mind, please?
Rafael
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-11-22 23:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-21 15:56 [PATCH] PM: fix compile breakage on sh #ifndef CONFIG_PM_RUNTIME Guennadi Liakhovetski
2011-11-21 19:53 ` Rafael J. Wysocki
2011-11-21 23:32 ` Guennadi Liakhovetski
2011-11-22 22:25 ` Rafael J. Wysocki
2011-11-22 22:27 ` Guennadi Liakhovetski
2011-11-22 23:42 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.