[PATCH net-next] cls_flow: remove one dynamic array

[PATCH net-next] cls_flow: remove one dynamic array

[Eric Dumazet]

Its better to use a predefined size for this small automatic variable.

Removes a sparse error as well :

net/sched/cls_flow.c:288:13: error: bad constant expression

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
 net/sched/cls_flow.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/cls_flow.c b/net/sched/cls_flow.c
index 51ff194..1d8bd0d 100644
--- a/net/sched/cls_flow.c
+++ b/net/sched/cls_flow.c
@@ -285,7 +285,7 @@ static int flow_classify(struct sk_buff *skb, const struct tcf_proto *tp,
 	int r;
 
 	list_for_each_entry(f, &head->filters, list) {
-		u32 keys[f->nkeys];
+		u32 keys[FLOW_KEY_MAX + 1];
 		struct flow_keys flow_keys;
 
 		if (!tcf_em_tree_match(skb, &f->ematches, NULL))

Re: [PATCH net-next] cls_flow: remove one dynamic array

[David Miller]

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 14 Dec 2011 13:30:00 +0100

> Its better to use a predefined size for this small automatic variable.
> 
> Removes a sparse error as well :
> 
> net/sched/cls_flow.c:288:13: error: bad constant expression
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied.