All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
@ 2011-12-15 16:52 ` Joerg Roedel
  0 siblings, 0 replies; 9+ messages in thread
From: Joerg Roedel @ 2011-12-15 16:52 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
  Cc: alsa-devel, linux-kernel

(again with mailing lists on Cc, sorry)

Hi,

I tested current linux-next against my iommu-configs and found a compile
error in sound/soc/mid-x86/sst_platform.c. The variable ret_val in the
sst_platform_open() function is used but not declared. Attached patch
fixes this.

>From d4e6d3b9ff8084c02eaf50e8212f77bcde5dec9d Mon Sep 17 00:00:00 2001
From: Joerg Roedel <joerg.roedel@amd.com>
Date: Thu, 15 Dec 2011 17:39:31 +0100
Subject: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c

The variable ret_val is used but not declared. Fix this.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 sound/soc/mid-x86/sst_platform.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_platform.c
index 24f9471..11c39c5 100644
--- a/sound/soc/mid-x86/sst_platform.c
+++ b/sound/soc/mid-x86/sst_platform.c
@@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream)
 {
 	struct snd_pcm_runtime *runtime = substream->runtime;
 	struct sst_runtime_stream *stream;
+	int ret_val;
 
 	pr_debug("sst_platform_open called\n");
 
-- 
1.7.5.4

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
@ 2011-12-15 16:52 ` Joerg Roedel
  0 siblings, 0 replies; 9+ messages in thread
From: Joerg Roedel @ 2011-12-15 16:52 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
  Cc: alsa-devel, linux-kernel

(again with mailing lists on Cc, sorry)

Hi,

I tested current linux-next against my iommu-configs and found a compile
error in sound/soc/mid-x86/sst_platform.c. The variable ret_val in the
sst_platform_open() function is used but not declared. Attached patch
fixes this.

>From d4e6d3b9ff8084c02eaf50e8212f77bcde5dec9d Mon Sep 17 00:00:00 2001
From: Joerg Roedel <joerg.roedel@amd.com>
Date: Thu, 15 Dec 2011 17:39:31 +0100
Subject: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c

The variable ret_val is used but not declared. Fix this.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 sound/soc/mid-x86/sst_platform.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_platform.c
index 24f9471..11c39c5 100644
--- a/sound/soc/mid-x86/sst_platform.c
+++ b/sound/soc/mid-x86/sst_platform.c
@@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream)
 {
 	struct snd_pcm_runtime *runtime = substream->runtime;
 	struct sst_runtime_stream *stream;
+	int ret_val;
 
 	pr_debug("sst_platform_open called\n");
 
-- 
1.7.5.4

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
  2011-12-15 16:52 ` Joerg Roedel
  (?)
@ 2011-12-15 17:16 ` Rakib Mullick
  2011-12-15 17:24     ` Joerg Roedel
  -1 siblings, 1 reply; 9+ messages in thread
From: Rakib Mullick @ 2011-12-15 17:16 UTC (permalink / raw)
  To: Joerg Roedel
  Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	alsa-devel, linux-kernel

On Thu, Dec 15, 2011 at 10:52 PM, Joerg Roedel <joerg.roedel@amd.com> wrote:
> (again with mailing lists on Cc, sorry)
>
> Hi,
>
> I tested current linux-next against my iommu-configs and found a compile
> error in sound/soc/mid-x86/sst_platform.c. The variable ret_val in the
> sst_platform_open() function is used but not declared. Attached patch
> fixes this.
>

While fixing any kind of error/warning, it's nice to have
error/warning message in changelog.

Thanks,
Rakib

> From d4e6d3b9ff8084c02eaf50e8212f77bcde5dec9d Mon Sep 17 00:00:00 2001
> From: Joerg Roedel <joerg.roedel@amd.com>
> Date: Thu, 15 Dec 2011 17:39:31 +0100
> Subject: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
>
> The variable ret_val is used but not declared. Fix this.
>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
>  sound/soc/mid-x86/sst_platform.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_platform.c
> index 24f9471..11c39c5 100644
> --- a/sound/soc/mid-x86/sst_platform.c
> +++ b/sound/soc/mid-x86/sst_platform.c
> @@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream)
>  {
>        struct snd_pcm_runtime *runtime = substream->runtime;
>        struct sst_runtime_stream *stream;
> +       int ret_val;
>
>        pr_debug("sst_platform_open called\n");
>
> --
> 1.7.5.4
>
> --
> AMD Operating System Research Center
>
> Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
> General Managers: Alberto Bozzo, Andrew Bowd
> Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
  2011-12-15 17:16 ` Rakib Mullick
@ 2011-12-15 17:24     ` Joerg Roedel
  0 siblings, 0 replies; 9+ messages in thread
From: Joerg Roedel @ 2011-12-15 17:24 UTC (permalink / raw)
  To: Rakib Mullick
  Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	alsa-devel, linux-kernel

On Thu, Dec 15, 2011 at 11:16:52PM +0600, Rakib Mullick wrote:
> On Thu, Dec 15, 2011 at 10:52 PM, Joerg Roedel <joerg.roedel@amd.com> wrote:
> > (again with mailing lists on Cc, sorry)
> >
> > Hi,
> >
> > I tested current linux-next against my iommu-configs and found a compile
> > error in sound/soc/mid-x86/sst_platform.c. The variable ret_val in the
> > sst_platform_open() function is used but not declared. Attached patch
> > fixes this.
> >
> 
> While fixing any kind of error/warning, it's nice to have
> error/warning message in changelog.

Okay, here it is:

>From 9d0876632c4fc07254eafbe5018e68963bdcfe17 Mon Sep 17 00:00:00 2001
From: Joerg Roedel <joerg.roedel@amd.com>
Date: Thu, 15 Dec 2011 17:39:31 +0100
Subject: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The variable ret_val is used but not declared. This causes
the following compile error:

sound/soc/mid-x86/sst_platform.c: In function ‘sst_platform_open’:
sound/soc/mid-x86/sst_platform.c:274:2: error: ‘ret_val’ undeclared (first use in this function)
sound/soc/mid-x86/sst_platform.c:274:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [sound/soc/mid-x86/sst_platform.o] Error 1

Fix this.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 sound/soc/mid-x86/sst_platform.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_platform.c
index 24f9471..11c39c5 100644
--- a/sound/soc/mid-x86/sst_platform.c
+++ b/sound/soc/mid-x86/sst_platform.c
@@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream)
 {
 	struct snd_pcm_runtime *runtime = substream->runtime;
 	struct sst_runtime_stream *stream;
+	int ret_val;
 
 	pr_debug("sst_platform_open called\n");
 
-- 
1.7.5.4


-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
@ 2011-12-15 17:24     ` Joerg Roedel
  0 siblings, 0 replies; 9+ messages in thread
From: Joerg Roedel @ 2011-12-15 17:24 UTC (permalink / raw)
  To: Rakib Mullick
  Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	alsa-devel, linux-kernel

On Thu, Dec 15, 2011 at 11:16:52PM +0600, Rakib Mullick wrote:
> On Thu, Dec 15, 2011 at 10:52 PM, Joerg Roedel <joerg.roedel@amd.com> wrote:
> > (again with mailing lists on Cc, sorry)
> >
> > Hi,
> >
> > I tested current linux-next against my iommu-configs and found a compile
> > error in sound/soc/mid-x86/sst_platform.c. The variable ret_val in the
> > sst_platform_open() function is used but not declared. Attached patch
> > fixes this.
> >
> 
> While fixing any kind of error/warning, it's nice to have
> error/warning message in changelog.

Okay, here it is:

From 9d0876632c4fc07254eafbe5018e68963bdcfe17 Mon Sep 17 00:00:00 2001
From: Joerg Roedel <joerg.roedel@amd.com>
Date: Thu, 15 Dec 2011 17:39:31 +0100
Subject: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The variable ret_val is used but not declared. This causes
the following compile error:

sound/soc/mid-x86/sst_platform.c: In function ‘sst_platform_open’:
sound/soc/mid-x86/sst_platform.c:274:2: error: ‘ret_val’ undeclared (first use in this function)
sound/soc/mid-x86/sst_platform.c:274:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [sound/soc/mid-x86/sst_platform.o] Error 1

Fix this.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 sound/soc/mid-x86/sst_platform.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_platform.c
index 24f9471..11c39c5 100644
--- a/sound/soc/mid-x86/sst_platform.c
+++ b/sound/soc/mid-x86/sst_platform.c
@@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream)
 {
 	struct snd_pcm_runtime *runtime = substream->runtime;
 	struct sst_runtime_stream *stream;
+	int ret_val;
 
 	pr_debug("sst_platform_open called\n");
 
-- 
1.7.5.4


-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
  2011-12-15 17:24     ` Joerg Roedel
@ 2011-12-16  6:53       ` Takashi Iwai
  -1 siblings, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2011-12-16  6:53 UTC (permalink / raw)
  To: Joerg Roedel
  Cc: Rakib Mullick, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	alsa-devel, linux-kernel, akpm

At Thu, 15 Dec 2011 18:24:54 +0100,
Joerg Roedel wrote:
> 
> On Thu, Dec 15, 2011 at 11:16:52PM +0600, Rakib Mullick wrote:
> > On Thu, Dec 15, 2011 at 10:52 PM, Joerg Roedel <joerg.roedel@amd.com> wrote:
> > > (again with mailing lists on Cc, sorry)
> > >
> > > Hi,
> > >
> > > I tested current linux-next against my iommu-configs and found a compile
> > > error in sound/soc/mid-x86/sst_platform.c. The variable ret_val in the
> > > sst_platform_open() function is used but not declared. Attached patch
> > > fixes this.
> > >
> > 
> > While fixing any kind of error/warning, it's nice to have
> > error/warning message in changelog.
> 
> Okay, here it is:
> 
> >From 9d0876632c4fc07254eafbe5018e68963bdcfe17 Mon Sep 17 00:00:00 2001
> From: Joerg Roedel <joerg.roedel@amd.com>
> Date: Thu, 15 Dec 2011 17:39:31 +0100
> Subject: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> The variable ret_val is used but not declared. This causes
> the following compile error:
> 
> sound/soc/mid-x86/sst_platform.c: In function ‘sst_platform_open’:
> sound/soc/mid-x86/sst_platform.c:274:2: error: ‘ret_val’ undeclared (first use in this function)
> sound/soc/mid-x86/sst_platform.c:274:2: note: each undeclared identifier is reported only once for each function it appears in
> make[1]: *** [sound/soc/mid-x86/sst_platform.o] Error 1
> 
> Fix this.
> 
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>

Thanks, I applied the patch now to sound git tree.

Mark, could you merge back topic/asoc branch into your tree later?


Takashi



> ---
>  sound/soc/mid-x86/sst_platform.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_platform.c
> index 24f9471..11c39c5 100644
> --- a/sound/soc/mid-x86/sst_platform.c
> +++ b/sound/soc/mid-x86/sst_platform.c
> @@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream)
>  {
>  	struct snd_pcm_runtime *runtime = substream->runtime;
>  	struct sst_runtime_stream *stream;
> +	int ret_val;
>  
>  	pr_debug("sst_platform_open called\n");
>  
> -- 
> 1.7.5.4
> 
> 
> -- 
> AMD Operating System Research Center
> 
> Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
> General Managers: Alberto Bozzo, Andrew Bowd
> Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
@ 2011-12-16  6:53       ` Takashi Iwai
  0 siblings, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2011-12-16  6:53 UTC (permalink / raw)
  To: Joerg Roedel
  Cc: alsa-devel, Mark Brown, linux-kernel, Rakib Mullick, akpm, Liam Girdwood

At Thu, 15 Dec 2011 18:24:54 +0100,
Joerg Roedel wrote:
> 
> On Thu, Dec 15, 2011 at 11:16:52PM +0600, Rakib Mullick wrote:
> > On Thu, Dec 15, 2011 at 10:52 PM, Joerg Roedel <joerg.roedel@amd.com> wrote:
> > > (again with mailing lists on Cc, sorry)
> > >
> > > Hi,
> > >
> > > I tested current linux-next against my iommu-configs and found a compile
> > > error in sound/soc/mid-x86/sst_platform.c. The variable ret_val in the
> > > sst_platform_open() function is used but not declared. Attached patch
> > > fixes this.
> > >
> > 
> > While fixing any kind of error/warning, it's nice to have
> > error/warning message in changelog.
> 
> Okay, here it is:
> 
> >From 9d0876632c4fc07254eafbe5018e68963bdcfe17 Mon Sep 17 00:00:00 2001
> From: Joerg Roedel <joerg.roedel@amd.com>
> Date: Thu, 15 Dec 2011 17:39:31 +0100
> Subject: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> The variable ret_val is used but not declared. This causes
> the following compile error:
> 
> sound/soc/mid-x86/sst_platform.c: In function ‘sst_platform_open’:
> sound/soc/mid-x86/sst_platform.c:274:2: error: ‘ret_val’ undeclared (first use in this function)
> sound/soc/mid-x86/sst_platform.c:274:2: note: each undeclared identifier is reported only once for each function it appears in
> make[1]: *** [sound/soc/mid-x86/sst_platform.o] Error 1
> 
> Fix this.
> 
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>

Thanks, I applied the patch now to sound git tree.

Mark, could you merge back topic/asoc branch into your tree later?


Takashi



> ---
>  sound/soc/mid-x86/sst_platform.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_platform.c
> index 24f9471..11c39c5 100644
> --- a/sound/soc/mid-x86/sst_platform.c
> +++ b/sound/soc/mid-x86/sst_platform.c
> @@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream)
>  {
>  	struct snd_pcm_runtime *runtime = substream->runtime;
>  	struct sst_runtime_stream *stream;
> +	int ret_val;
>  
>  	pr_debug("sst_platform_open called\n");
>  
> -- 
> 1.7.5.4
> 
> 
> -- 
> AMD Operating System Research Center
> 
> Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
> General Managers: Alberto Bozzo, Andrew Bowd
> Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
  2011-12-16  6:53       ` Takashi Iwai
@ 2011-12-16 12:55         ` Mark Brown
  -1 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2011-12-16 12:55 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Joerg Roedel, Rakib Mullick, Liam Girdwood, Jaroslav Kysela,
	alsa-devel, linux-kernel, akpm

On Fri, Dec 16, 2011 at 07:53:37AM +0100, Takashi Iwai wrote:

> Mark, could you merge back topic/asoc branch into your tree later?

Sure...  that was a bit fast waiting for my response.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
@ 2011-12-16 12:55         ` Mark Brown
  0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2011-12-16 12:55 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: alsa-devel, Joerg Roedel, linux-kernel, Rakib Mullick, akpm,
	Liam Girdwood

On Fri, Dec 16, 2011 at 07:53:37AM +0100, Takashi Iwai wrote:

> Mark, could you merge back topic/asoc branch into your tree later?

Sure...  that was a bit fast waiting for my response.

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-12-16 12:55 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-15 16:52 [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c Joerg Roedel
2011-12-15 16:52 ` Joerg Roedel
2011-12-15 17:16 ` Rakib Mullick
2011-12-15 17:24   ` Joerg Roedel
2011-12-15 17:24     ` Joerg Roedel
2011-12-16  6:53     ` Takashi Iwai
2011-12-16  6:53       ` Takashi Iwai
2011-12-16 12:55       ` Mark Brown
2011-12-16 12:55         ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.