From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 1/2] tpm: Rename generic_lpc_tpm to tpm_tis_lpc
Date: Sat, 17 Dec 2011 21:35:58 +0100 [thread overview]
Message-ID: <20111217203558.6E04E1ECC61@gemini.denx.de> (raw)
In-Reply-To: <1323852504-19954-2-git-send-email-clchiou@chromium.org>
Dear Che-Liang Chiou,
In message <1323852504-19954-2-git-send-email-clchiou@chromium.org> you wrote:
> The new name is more aligned with Linux kernel's naming of TPM driver.
>
> Signed-off-by: Peter Huewe <peter.huewe@infineon.com>
> Signed-off-by: Che-Liang Chiou <clchiou@chromium.org>
> Acked-by: Mike Frysinger <vapier@gentoo.org>
> ---
> Changes in v1:
> - Update s-o-b Peter Huewe's email address
>
> Makefile | 2 +-
> README | 5 ++++-
> drivers/tpm/Makefile | 2 +-
> drivers/tpm/{generic_lpc_tpm.c => tpm_tis_lpc.c} | 0
> 4 files changed, 6 insertions(+), 3 deletions(-)
> rename drivers/tpm/{generic_lpc_tpm.c => tpm_tis_lpc.c} (100%)
Does such a change actually make sense?
Should we not rather remove all this dead code again?
Until today there are no users for this code in mainline, and no
patches have been submitted that intend to use it.
I think we should scrap this in the next release.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Drawing on my fine command of language, I said nothing.
next prev parent reply other threads:[~2011-12-17 20:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 8:48 [U-Boot] [PATCH v1 0/2] Add i2c TPM driver Che-Liang Chiou
2011-12-14 8:48 ` [U-Boot] [PATCH v1 1/2] tpm: Rename generic_lpc_tpm to tpm_tis_lpc Che-Liang Chiou
2011-12-17 20:35 ` Wolfgang Denk [this message]
2011-12-19 10:57 ` Che-liang Chiou
2011-12-19 11:38 ` Wolfgang Denk
2011-12-20 8:12 ` Che-liang Chiou
2011-12-20 11:43 ` Wolfgang Denk
2011-12-21 3:23 ` Che-liang Chiou
2011-12-14 8:48 ` [U-Boot] [PATCH v1 2/2] tpm: Add i2c TPM driver Che-Liang Chiou
2011-12-16 17:21 ` Mike Frysinger
2011-12-19 9:51 ` Che-liang Chiou
2011-12-17 20:33 ` Wolfgang Denk
2011-12-19 9:53 ` Che-liang Chiou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111217203558.6E04E1ECC61@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.