From: Che-liang Chiou <clchiou@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 2/2] tpm: Add i2c TPM driver
Date: Mon, 19 Dec 2011 17:51:54 +0800 [thread overview]
Message-ID: <CANJuy2JZ93xHVEyWQZ5VUrT6ae=M2YJwvnnd8YceH3hDtqrB2A@mail.gmail.com> (raw)
In-Reply-To: <201112161221.14711.vapier@gentoo.org>
On Sat, Dec 17, 2011 at 1:21 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Wednesday 14 December 2011 03:48:24 Che-Liang Chiou wrote:
>> --- /dev/null
>> +++ b/drivers/tpm/tpm.c
>>
>> +int tis_sendrecv(const uint8_t *sendbuf, size_t send_size, uint8_t
>> *recvbuf, + ? ? ? ? ? size_t *recv_len)
>> +{
>> + ? ? ? ? ? ? error("%s: invalid send_size %zx\n", __func__, send_size);
>
> using __func__ with error() makes no sense as error() already includes that
Done.
>> --- /dev/null
>> +++ b/drivers/tpm/tpm_private.h
>
> this should probably include linux/types.h and linux/compiler.h since it uses
> __be32 and __packed
Done.
>> --- /dev/null
>> +++ b/drivers/tpm/tpm_tis_i2c.c
>>
>> + ? ? ? ? ? ? if (burstcnt > (len-1-count))
>> + ? ? ? ? ? ? ? ? ? ? burstcnt = len-1-count;
>
> add some spaces around those "-"
Done.
> -mike
next prev parent reply other threads:[~2011-12-19 9:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 8:48 [U-Boot] [PATCH v1 0/2] Add i2c TPM driver Che-Liang Chiou
2011-12-14 8:48 ` [U-Boot] [PATCH v1 1/2] tpm: Rename generic_lpc_tpm to tpm_tis_lpc Che-Liang Chiou
2011-12-17 20:35 ` Wolfgang Denk
2011-12-19 10:57 ` Che-liang Chiou
2011-12-19 11:38 ` Wolfgang Denk
2011-12-20 8:12 ` Che-liang Chiou
2011-12-20 11:43 ` Wolfgang Denk
2011-12-21 3:23 ` Che-liang Chiou
2011-12-14 8:48 ` [U-Boot] [PATCH v1 2/2] tpm: Add i2c TPM driver Che-Liang Chiou
2011-12-16 17:21 ` Mike Frysinger
2011-12-19 9:51 ` Che-liang Chiou [this message]
2011-12-17 20:33 ` Wolfgang Denk
2011-12-19 9:53 ` Che-liang Chiou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANJuy2JZ93xHVEyWQZ5VUrT6ae=M2YJwvnnd8YceH3hDtqrB2A@mail.gmail.com' \
--to=clchiou@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.