From: "Heiko Stübner" <heiko@sntech.de> To: Russell King - ARM Linux <linux@arm.linux.org.uk> Cc: Greg KH <greg@kroah.com>, Felipe Balbi <balbi@ti.com>, Kukjin Kim <kgene.kim@samsung.com>, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org, Thomas Abraham <thomas.abraham@linaro.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/7] s3c-hsudc: add a remove function Date: Sun, 18 Dec 2011 10:42:15 +0100 [thread overview] Message-ID: <201112181042.15550.heiko@sntech.de> (raw) In-Reply-To: <20111218081048.GS14542@n2100.arm.linux.org.uk> Am Sonntag 18 Dezember 2011, 09:10:48 schrieb Russell King - ARM Linux: > On Sat, Dec 17, 2011 at 08:26:33PM +0100, Heiko Stübner wrote: > > As the driver is also buildable as a module it should need > > a cleanup function for the removal of the module. > > My guess is that this wasn't implemented because of the embedded struct > device lifetime rules for the gadget - to prevent the unbinding of the > driver. > > Until the struct device lifetime gets fixed, you must not allow the module > nor the data structure containing the struct device to be freed. so essentially, this patch and the release stuff in 5/7 must go. Thanks for pointing out this problem. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > --- > > > > drivers/usb/gadget/s3c-hsudc.c | 25 +++++++++++++++++++++++++ > > 1 files changed, 25 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/usb/gadget/s3c-hsudc.c > > b/drivers/usb/gadget/s3c-hsudc.c index 3e5673d..7cb0850 100644 > > --- a/drivers/usb/gadget/s3c-hsudc.c > > +++ b/drivers/usb/gadget/s3c-hsudc.c > > > > @@ -1370,12 +1370,37 @@ err_res: > > return ret; > > > > } > > > > +static int __devexit s3c_hsudc_remove(struct platform_device *pdev) > > +{ > > + struct s3c_hsudc *hsudc = the_controller; > > + > > + usb_del_gadget_udc(&hsudc->gadget); > > + > > + clk_disable(hsudc->uclk); > > + clk_put(hsudc->uclk); > > + > > + free_irq(hsudc->irq, hsudc); > > + > > + iounmap(hsudc->regs); > > + > > + release_resource(hsudc->mem_rsrc); > > + kfree(hsudc->mem_rsrc); > > + > > + if (hsudc->transceiver) > > + otg_put_transceiver(hsudc->transceiver); > > + > > + the_controller = NULL; > > + kfree(hsudc); > > + return 0; > > +} > > + > > > > static struct platform_driver s3c_hsudc_driver = { > > > > .driver = { > > > > .owner = THIS_MODULE, > > .name = "s3c-hsudc", > > > > }, > > .probe = s3c_hsudc_probe, > > > > + .remove = __devexit_p(s3c_hsudc_remove), > > > > }; > > > > module_platform_driver(s3c_hsudc_driver);
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/7] s3c-hsudc: add a remove function Date: Sun, 18 Dec 2011 10:42:15 +0100 [thread overview] Message-ID: <201112181042.15550.heiko@sntech.de> (raw) In-Reply-To: <20111218081048.GS14542@n2100.arm.linux.org.uk> Am Sonntag 18 Dezember 2011, 09:10:48 schrieb Russell King - ARM Linux: > On Sat, Dec 17, 2011 at 08:26:33PM +0100, Heiko St?bner wrote: > > As the driver is also buildable as a module it should need > > a cleanup function for the removal of the module. > > My guess is that this wasn't implemented because of the embedded struct > device lifetime rules for the gadget - to prevent the unbinding of the > driver. > > Until the struct device lifetime gets fixed, you must not allow the module > nor the data structure containing the struct device to be freed. so essentially, this patch and the release stuff in 5/7 must go. Thanks for pointing out this problem. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > --- > > > > drivers/usb/gadget/s3c-hsudc.c | 25 +++++++++++++++++++++++++ > > 1 files changed, 25 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/usb/gadget/s3c-hsudc.c > > b/drivers/usb/gadget/s3c-hsudc.c index 3e5673d..7cb0850 100644 > > --- a/drivers/usb/gadget/s3c-hsudc.c > > +++ b/drivers/usb/gadget/s3c-hsudc.c > > > > @@ -1370,12 +1370,37 @@ err_res: > > return ret; > > > > } > > > > +static int __devexit s3c_hsudc_remove(struct platform_device *pdev) > > +{ > > + struct s3c_hsudc *hsudc = the_controller; > > + > > + usb_del_gadget_udc(&hsudc->gadget); > > + > > + clk_disable(hsudc->uclk); > > + clk_put(hsudc->uclk); > > + > > + free_irq(hsudc->irq, hsudc); > > + > > + iounmap(hsudc->regs); > > + > > + release_resource(hsudc->mem_rsrc); > > + kfree(hsudc->mem_rsrc); > > + > > + if (hsudc->transceiver) > > + otg_put_transceiver(hsudc->transceiver); > > + > > + the_controller = NULL; > > + kfree(hsudc); > > + return 0; > > +} > > + > > > > static struct platform_driver s3c_hsudc_driver = { > > > > .driver = { > > > > .owner = THIS_MODULE, > > .name = "s3c-hsudc", > > > > }, > > .probe = s3c_hsudc_probe, > > > > + .remove = __devexit_p(s3c_hsudc_remove), > > > > }; > > > > module_platform_driver(s3c_hsudc_driver);
next prev parent reply other threads:[~2011-12-18 9:42 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-12-17 19:23 [PATCH v2 0/7] s3c-hsudc: regulator handling and a lot of fixes Heiko Stübner 2011-12-17 19:23 ` Heiko Stübner 2011-12-17 19:24 ` [PATCH 1/7] s3c-hsudc: move platform_data struct to global header Heiko Stübner 2011-12-17 19:24 ` Heiko Stübner 2011-12-17 19:25 ` [PATCH 2/7] s3c-hsudc: add __devinit to probe function Heiko Stübner 2011-12-17 19:25 ` Heiko Stübner 2011-12-17 19:26 ` [PATCH 3/7] s3c-hsudc: add a remove function Heiko Stübner 2011-12-17 19:26 ` Heiko Stübner 2011-12-18 8:03 ` Russell King - ARM Linux 2011-12-18 8:03 ` Russell King - ARM Linux 2011-12-18 8:10 ` Russell King - ARM Linux 2011-12-18 8:10 ` Russell King - ARM Linux 2011-12-18 9:42 ` Heiko Stübner [this message] 2011-12-18 9:42 ` Heiko Stübner 2011-12-18 13:44 ` Heiko Stübner 2011-12-18 13:44 ` Heiko Stübner 2011-12-18 14:43 ` Russell King - ARM Linux 2011-12-18 14:43 ` Russell King - ARM Linux 2011-12-18 18:50 ` Heiko Stübner 2011-12-18 18:50 ` Heiko Stübner [not found] ` <201112181950.38993.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> 2011-12-18 19:01 ` Russell King - ARM Linux 2011-12-18 19:01 ` Russell King - ARM Linux 2011-12-18 19:33 ` Heiko Stübner 2011-12-18 19:33 ` Heiko Stübner 2011-12-18 19:45 ` Russell King - ARM Linux 2011-12-18 19:45 ` Russell King - ARM Linux 2011-12-18 20:24 ` Heiko Stübner 2011-12-18 20:24 ` Heiko Stübner [not found] ` <201112182124.13313.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> 2011-12-18 20:39 ` Russell King - ARM Linux 2011-12-18 20:39 ` Russell King - ARM Linux [not found] ` <20111218203953.GY14542-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2011-12-18 20:46 ` Heiko Stübner 2011-12-18 20:46 ` Heiko Stübner 2011-12-18 21:37 ` Russell King - ARM Linux 2011-12-18 21:37 ` Russell King - ARM Linux [not found] ` <20111218213704.GZ14542-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2011-12-20 6:08 ` Greg KH 2011-12-20 6:08 ` Greg KH 2011-12-20 6:07 ` Greg KH 2011-12-20 6:07 ` Greg KH 2011-12-17 19:27 ` [PATCH 4/7] s3c-hsudc: add missing otg_put_transceiver in probe Heiko Stübner 2011-12-17 19:27 ` Heiko Stübner 2011-12-17 19:28 ` [PATCH 5/7] s3c-hsudc: move device registration to probe and remove Heiko Stübner 2011-12-17 19:28 ` Heiko Stübner 2011-12-18 8:09 ` Russell King - ARM Linux 2011-12-18 8:09 ` Russell King - ARM Linux [not found] ` <201112172023.05519.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> 2011-12-17 19:29 ` [PATCH 6/7] s3c-hsudc: use udc_start and udc_stop functions Heiko Stübner 2011-12-17 19:29 ` Heiko Stübner 2011-12-17 19:30 ` [PATCH 7/7] s3c-hsudc: Add regulator handling Heiko Stübner 2011-12-17 19:30 ` Heiko Stübner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201112181042.15550.heiko@sntech.de \ --to=heiko@sntech.de \ --cc=balbi@ti.com \ --cc=greg@kroah.com \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=thomas.abraham@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.