* [PATCH] net: macb: fix build break with !CONFIG_OF
@ 2011-12-20 21:20 ` Olof Johansson
0 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2011-12-20 21:20 UTC (permalink / raw)
To: Nicolas Ferre
Cc: netdev, Jean-Christophe PLAGNIOL-VILLARD, Jamie Iles,
linux-arm-kernel, Olof Johansson
This fixes the build of the macb driver that was broken by the DT changes:
drivers/net/ethernet/cadence/macb.c:1503: error: implicit declaration of function 'of_match_ptr'
drivers/net/ethernet/cadence/macb.c:1503: error: 'macb_dt_ids' undeclared here (not in a function)
drivers/net/ethernet/cadence/macb.c:1503: error: initializer element is not constant
drivers/net/ethernet/cadence/macb.c:1503: error: (near initialization for 'macb_driver.driver.of_match_table')
Signed-off-by: Olof Johansson <olof@lixom.net>
---
Nicolas, care to ack this so I can apply it on top of the macb DT branch in arm-soc?
drivers/net/ethernet/cadence/macb.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index baf1a0d..f3d5c65 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -23,6 +23,7 @@
#include <linux/platform_data/macb.h>
#include <linux/platform_device.h>
#include <linux/phy.h>
+#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/of_net.h>
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] net: macb: fix build break with !CONFIG_OF
@ 2011-12-20 21:20 ` Olof Johansson
0 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2011-12-20 21:20 UTC (permalink / raw)
To: linux-arm-kernel
This fixes the build of the macb driver that was broken by the DT changes:
drivers/net/ethernet/cadence/macb.c:1503: error: implicit declaration of function 'of_match_ptr'
drivers/net/ethernet/cadence/macb.c:1503: error: 'macb_dt_ids' undeclared here (not in a function)
drivers/net/ethernet/cadence/macb.c:1503: error: initializer element is not constant
drivers/net/ethernet/cadence/macb.c:1503: error: (near initialization for 'macb_driver.driver.of_match_table')
Signed-off-by: Olof Johansson <olof@lixom.net>
---
Nicolas, care to ack this so I can apply it on top of the macb DT branch in arm-soc?
drivers/net/ethernet/cadence/macb.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index baf1a0d..f3d5c65 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -23,6 +23,7 @@
#include <linux/platform_data/macb.h>
#include <linux/platform_device.h>
#include <linux/phy.h>
+#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/of_net.h>
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] net: macb: fix build break with !CONFIG_OF
2011-12-20 21:20 ` Olof Johansson
@ 2011-12-21 6:04 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2011-12-21 6:04 UTC (permalink / raw)
To: olof; +Cc: nicolas.ferre, netdev, plagnioj, jamie, linux-arm-kernel
From: Olof Johansson <olof@lixom.net>
Date: Tue, 20 Dec 2011 13:20:29 -0800
> This fixes the build of the macb driver that was broken by the DT changes:
>
> drivers/net/ethernet/cadence/macb.c:1503: error: implicit declaration of function 'of_match_ptr'
> drivers/net/ethernet/cadence/macb.c:1503: error: 'macb_dt_ids' undeclared here (not in a function)
> drivers/net/ethernet/cadence/macb.c:1503: error: initializer element is not constant
> drivers/net/ethernet/cadence/macb.c:1503: error: (near initialization for 'macb_driver.driver.of_match_table')
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
>
> Nicolas, care to ack this so I can apply it on top of the macb DT branch in arm-soc?
Yes, please apply it there.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] net: macb: fix build break with !CONFIG_OF
@ 2011-12-21 6:04 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2011-12-21 6:04 UTC (permalink / raw)
To: linux-arm-kernel
From: Olof Johansson <olof@lixom.net>
Date: Tue, 20 Dec 2011 13:20:29 -0800
> This fixes the build of the macb driver that was broken by the DT changes:
>
> drivers/net/ethernet/cadence/macb.c:1503: error: implicit declaration of function 'of_match_ptr'
> drivers/net/ethernet/cadence/macb.c:1503: error: 'macb_dt_ids' undeclared here (not in a function)
> drivers/net/ethernet/cadence/macb.c:1503: error: initializer element is not constant
> drivers/net/ethernet/cadence/macb.c:1503: error: (near initialization for 'macb_driver.driver.of_match_table')
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
>
> Nicolas, care to ack this so I can apply it on top of the macb DT branch in arm-soc?
Yes, please apply it there.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: macb: fix build break with !CONFIG_OF
2011-12-20 21:20 ` Olof Johansson
@ 2011-12-21 21:34 ` Nicolas Ferre
-1 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2011-12-21 21:34 UTC (permalink / raw)
To: Olof Johansson
Cc: netdev, Jean-Christophe PLAGNIOL-VILLARD, Jamie Iles, linux-arm-kernel
On 12/20/2011 10:20 PM, Olof Johansson :
> This fixes the build of the macb driver that was broken by the DT changes:
>
> drivers/net/ethernet/cadence/macb.c:1503: error: implicit declaration of function 'of_match_ptr'
> drivers/net/ethernet/cadence/macb.c:1503: error: 'macb_dt_ids' undeclared here (not in a function)
> drivers/net/ethernet/cadence/macb.c:1503: error: initializer element is not constant
> drivers/net/ethernet/cadence/macb.c:1503: error: (near initialization for 'macb_driver.driver.of_match_table')
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Olof, thanks for this patch.
Best regards,
> ---
>
> Nicolas, care to ack this so I can apply it on top of the macb DT branch in arm-soc?
>
> drivers/net/ethernet/cadence/macb.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index baf1a0d..f3d5c65 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -23,6 +23,7 @@
> #include <linux/platform_data/macb.h>
> #include <linux/platform_device.h>
> #include <linux/phy.h>
> +#include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/of_net.h>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] net: macb: fix build break with !CONFIG_OF
@ 2011-12-21 21:34 ` Nicolas Ferre
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2011-12-21 21:34 UTC (permalink / raw)
To: linux-arm-kernel
On 12/20/2011 10:20 PM, Olof Johansson :
> This fixes the build of the macb driver that was broken by the DT changes:
>
> drivers/net/ethernet/cadence/macb.c:1503: error: implicit declaration of function 'of_match_ptr'
> drivers/net/ethernet/cadence/macb.c:1503: error: 'macb_dt_ids' undeclared here (not in a function)
> drivers/net/ethernet/cadence/macb.c:1503: error: initializer element is not constant
> drivers/net/ethernet/cadence/macb.c:1503: error: (near initialization for 'macb_driver.driver.of_match_table')
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Olof, thanks for this patch.
Best regards,
> ---
>
> Nicolas, care to ack this so I can apply it on top of the macb DT branch in arm-soc?
>
> drivers/net/ethernet/cadence/macb.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index baf1a0d..f3d5c65 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -23,6 +23,7 @@
> #include <linux/platform_data/macb.h>
> #include <linux/platform_device.h>
> #include <linux/phy.h>
> +#include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/of_net.h>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-21 21:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-20 21:20 [PATCH] net: macb: fix build break with !CONFIG_OF Olof Johansson
2011-12-20 21:20 ` Olof Johansson
2011-12-21 6:04 ` David Miller
2011-12-21 6:04 ` David Miller
2011-12-21 21:34 ` Nicolas Ferre
2011-12-21 21:34 ` Nicolas Ferre
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.