* [PATCH] drivers/iwlwifi: use dma_zalloc_coherent() for DMA allocation
@ 2011-12-21 0:21 Djalal Harouni
2011-12-21 16:52 ` Guy, Wey-Yi
0 siblings, 1 reply; 6+ messages in thread
From: Djalal Harouni @ 2011-12-21 0:21 UTC (permalink / raw)
To: Wey-Yi Guy, Intel Linux Wireless, John W. Linville, linux-wireless
Cc: netdev, Andrew Morton
Replace dma_alloc_coherent()+memset() with the new dma_zalloc_coherent()
Signed-off-by: Djalal Harouni <tixxdz@opendz.org>
---
drivers/net/wireless/iwlwifi/iwl-trans-pcie.c | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c b/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c
index ce91898..4363da7 100644
--- a/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c
+++ b/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c
@@ -88,18 +88,16 @@ static int iwl_trans_rx_alloc(struct iwl_trans *trans)
return -EINVAL;
/* Allocate the circular buffer of Read Buffer Descriptors (RBDs) */
- rxq->bd = dma_alloc_coherent(dev, sizeof(__le32) * RX_QUEUE_SIZE,
- &rxq->bd_dma, GFP_KERNEL);
+ rxq->bd = dma_zalloc_coherent(dev, sizeof(__le32) * RX_QUEUE_SIZE,
+ &rxq->bd_dma, GFP_KERNEL);
if (!rxq->bd)
goto err_bd;
- memset(rxq->bd, 0, sizeof(__le32) * RX_QUEUE_SIZE);
/*Allocate the driver's pointer to receive buffer status */
- rxq->rb_stts = dma_alloc_coherent(dev, sizeof(*rxq->rb_stts),
- &rxq->rb_stts_dma, GFP_KERNEL);
+ rxq->rb_stts = dma_zalloc_coherent(dev, sizeof(*rxq->rb_stts),
+ &rxq->rb_stts_dma, GFP_KERNEL);
if (!rxq->rb_stts)
goto err_rb_stts;
- memset(rxq->rb_stts, 0, sizeof(*rxq->rb_stts));
return 0;
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/iwlwifi: use dma_zalloc_coherent() for DMA allocation
2011-12-21 0:21 [PATCH] drivers/iwlwifi: use dma_zalloc_coherent() for DMA allocation Djalal Harouni
@ 2011-12-21 16:52 ` Guy, Wey-Yi
2011-12-21 19:48 ` Djalal Harouni
0 siblings, 1 reply; 6+ messages in thread
From: Guy, Wey-Yi @ 2011-12-21 16:52 UTC (permalink / raw)
To: Djalal Harouni
Cc: Intel Linux Wireless, John W. Linville, linux-wireless, netdev,
Andrew Morton
Hi Djalal,
On Tue, 2011-12-20 at 16:21 -0800, Djalal Harouni wrote:
> Replace dma_alloc_coherent()+memset() with the new dma_zalloc_coherent()
>
> Signed-off-by: Djalal Harouni <tixxdz@opendz.org>
> ---
iwl-trans-pcie.c is one of the source files in iwlwifi driver hold
dual-license (GPL + BSD), are you ok to release your code for the BSD
license and relinquish the copyright?
btw, we are in the process of rewrite and re-architect major portion of
iwlwifi driver, and we also plan to make most of the code dual-license
(GPL + BSD).
Thanks you in advance
Wey
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/iwlwifi: use dma_zalloc_coherent() for DMA allocation
2011-12-21 16:52 ` Guy, Wey-Yi
@ 2011-12-21 19:48 ` Djalal Harouni
0 siblings, 0 replies; 6+ messages in thread
From: Djalal Harouni @ 2011-12-21 19:48 UTC (permalink / raw)
To: Guy, Wey-Yi
Cc: Intel Linux Wireless, John W. Linville, linux-wireless, netdev,
Andrew Morton
On Wed, Dec 21, 2011 at 08:52:10AM -0800, Guy, Wey-Yi wrote:
> Hi Djalal,
>
>
> On Tue, 2011-12-20 at 16:21 -0800, Djalal Harouni wrote:
> > Replace dma_alloc_coherent()+memset() with the new dma_zalloc_coherent()
> >
> > Signed-off-by: Djalal Harouni <tixxdz@opendz.org>
> > ---
>
> iwl-trans-pcie.c is one of the source files in iwlwifi driver hold
> dual-license (GPL + BSD), are you ok to release your code for the BSD
> license and relinquish the copyright?
Yes, It's ok.
> btw, we are in the process of rewrite and re-architect major portion of
> iwlwifi driver, and we also plan to make most of the code dual-license
> (GPL + BSD).
>
> Thanks you in advance
>
> Wey
Thanks Wey.
--
tixxdz
http://opendz.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/iwlwifi: use dma_zalloc_coherent() for DMA allocation
@ 2011-12-21 19:48 ` Djalal Harouni
0 siblings, 0 replies; 6+ messages in thread
From: Djalal Harouni @ 2011-12-21 19:48 UTC (permalink / raw)
To: Guy, Wey-Yi
Cc: Intel Linux Wireless, John W. Linville,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, Andrew Morton
On Wed, Dec 21, 2011 at 08:52:10AM -0800, Guy, Wey-Yi wrote:
> Hi Djalal,
>
>
> On Tue, 2011-12-20 at 16:21 -0800, Djalal Harouni wrote:
> > Replace dma_alloc_coherent()+memset() with the new dma_zalloc_coherent()
> >
> > Signed-off-by: Djalal Harouni <tixxdz-Umm1ozX2/EEdnm+yROfE0A@public.gmane.org>
> > ---
>
> iwl-trans-pcie.c is one of the source files in iwlwifi driver hold
> dual-license (GPL + BSD), are you ok to release your code for the BSD
> license and relinquish the copyright?
Yes, It's ok.
> btw, we are in the process of rewrite and re-architect major portion of
> iwlwifi driver, and we also plan to make most of the code dual-license
> (GPL + BSD).
>
> Thanks you in advance
>
> Wey
Thanks Wey.
--
tixxdz
http://opendz.org
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] drivers/iwlwifi: use dma_zalloc_coherent() for DMA allocation
2011-12-21 19:48 ` Djalal Harouni
@ 2011-12-22 1:33 ` Guy, Wey-Yi W
-1 siblings, 0 replies; 6+ messages in thread
From: Guy, Wey-Yi W @ 2011-12-22 1:33 UTC (permalink / raw)
To: Djalal Harouni
Cc: Intel Linux Wireless, John W. Linville, linux-wireless, netdev,
Andrew Morton
Hi Djalal,
>
> iwl-trans-pcie.c is one of the source files in iwlwifi driver hold
> dual-license (GPL + BSD), are you ok to release your code for the BSD
> license and relinquish the copyright?
Yes, It's ok.
Thank you very much
Wey
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] drivers/iwlwifi: use dma_zalloc_coherent() for DMA allocation
@ 2011-12-22 1:33 ` Guy, Wey-Yi W
0 siblings, 0 replies; 6+ messages in thread
From: Guy, Wey-Yi W @ 2011-12-22 1:33 UTC (permalink / raw)
To: Djalal Harouni
Cc: Intel Linux Wireless, John W. Linville,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, Andrew Morton
Hi Djalal,
>
> iwl-trans-pcie.c is one of the source files in iwlwifi driver hold
> dual-license (GPL + BSD), are you ok to release your code for the BSD
> license and relinquish the copyright?
Yes, It's ok.
Thank you very much
Wey
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-22 1:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-21 0:21 [PATCH] drivers/iwlwifi: use dma_zalloc_coherent() for DMA allocation Djalal Harouni
2011-12-21 16:52 ` Guy, Wey-Yi
2011-12-21 19:48 ` Djalal Harouni
2011-12-21 19:48 ` Djalal Harouni
2011-12-22 1:33 ` Guy, Wey-Yi W
2011-12-22 1:33 ` Guy, Wey-Yi W
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.