* [PATCH 0/1] Treat IPv6 diffserv the same as ipv4 diffserv for 802.11e
@ 2011-12-21 8:41 Dave Taht
2011-12-21 8:41 ` [PATCH 1/1] " Dave Taht
0 siblings, 1 reply; 3+ messages in thread
From: Dave Taht @ 2011-12-21 8:41 UTC (permalink / raw)
To: linux-wireless
This treats ipv6 and ipv4 the same, on wireles, where diffserv is
concerned.
I note that it would be nice if this mechanism tossed packets marked
with the interactive bit into the VI queue as well. Nicer still
would be a more generic and comprehensive diffserv handling.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] Treat IPv6 diffserv the same as ipv4 diffserv for 802.11e
2011-12-21 8:41 [PATCH 0/1] Treat IPv6 diffserv the same as ipv4 diffserv for 802.11e Dave Taht
@ 2011-12-21 8:41 ` Dave Taht
2011-12-21 20:09 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Dave Taht @ 2011-12-21 8:41 UTC (permalink / raw)
To: linux-wireless; +Cc: Dave Taht
Wireless will select a different hardware queue based on the
top 3 bits of the diffserv field, for ipv4. Extend that queue
selection mechanism to ipv6, and make the calls orthogonal.
---
net/wireless/util.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/net/wireless/util.c b/net/wireless/util.c
index e77df75..2c0600c 100644
--- a/net/wireless/util.c
+++ b/net/wireless/util.c
@@ -9,6 +9,7 @@
#include <linux/slab.h>
#include <net/cfg80211.h>
#include <net/ip.h>
+#include <net/dsfield.h>
#include "core.h"
struct ieee80211_rate *
@@ -650,7 +651,10 @@ unsigned int cfg80211_classify8021d(struct sk_buff *skb)
switch (skb->protocol) {
case htons(ETH_P_IP):
- dscp = ip_hdr(skb)->tos & 0xfc;
+ dscp = ipv4_get_dsfield(ip_hdr(skb)) & 0xfc;
+ break;
+ case htons(ETH_P_IPV6):
+ dscp = ipv6_get_dsfield(ipv6_hdr(skb)) & 0xfc;
break;
default:
return 0;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Treat IPv6 diffserv the same as ipv4 diffserv for 802.11e
2011-12-21 8:41 ` [PATCH 1/1] " Dave Taht
@ 2011-12-21 20:09 ` John W. Linville
0 siblings, 0 replies; 3+ messages in thread
From: John W. Linville @ 2011-12-21 20:09 UTC (permalink / raw)
To: Dave Taht; +Cc: linux-wireless
On Wed, Dec 21, 2011 at 12:41:45AM -0800, Dave Taht wrote:
> Wireless will select a different hardware queue based on the
> top 3 bits of the diffserv field, for ipv4. Extend that queue
> selection mechanism to ipv6, and make the calls orthogonal.
The patch itself seems fine to me. But the format needs work:
http://linux.yyz.us/patch-format.html
Would you mind fixing-up the email and resubmitting?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-21 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-21 8:41 [PATCH 0/1] Treat IPv6 diffserv the same as ipv4 diffserv for 802.11e Dave Taht
2011-12-21 8:41 ` [PATCH 1/1] " Dave Taht
2011-12-21 20:09 ` John W. Linville
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.