* linux-next: net/smsc911x compile error on next-20120106
@ 2012-01-07 5:55 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2012-01-07 5:55 UTC (permalink / raw)
To: Stephen Rothwell, David Miller; +Cc: netdev, linux-next, linux-arm-kernel
Hi Stephen, David,
I just ran into the following compile error when building
next-20120106 with imx_v6_v7_defconfig.
CC drivers/net/ethernet/smsc/smsc911x.o
drivers/net/ethernet/smsc/smsc911x.c: In function
‘smsc911x_phy_disable_energy_detect’:
drivers/net/ethernet/smsc/smsc911x.c:1329:32: error:
‘MII_LAN83C185_CTRL_STATUS’ undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1329:32: note: each undeclared
identifier is reported only once for each function it appears in
drivers/net/ethernet/smsc/smsc911x.c:1340:12: error:
‘MII_LAN83C185_EDPWRDOWN’ undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1341:13: error:
‘MII_LAN83C185_ENERGYON’ undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c: In function
‘smsc911x_phy_enable_energy_detect’:
drivers/net/ethernet/smsc/smsc911x.c:1364:32: error:
‘MII_LAN83C185_CTRL_STATUS’ undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1372:13: error:
‘MII_LAN83C185_EDPWRDOWN’ undeclared (first use in this function)
--
Regards,
Shawn
^ permalink raw reply [flat|nested] 4+ messages in thread
* linux-next: net/smsc911x compile error on next-20120106
@ 2012-01-07 5:55 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2012-01-07 5:55 UTC (permalink / raw)
To: linux-arm-kernel
Hi Stephen, David,
I just ran into the following compile error when building
next-20120106 with imx_v6_v7_defconfig.
CC drivers/net/ethernet/smsc/smsc911x.o
drivers/net/ethernet/smsc/smsc911x.c: In function
?smsc911x_phy_disable_energy_detect?:
drivers/net/ethernet/smsc/smsc911x.c:1329:32: error:
?MII_LAN83C185_CTRL_STATUS? undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1329:32: note: each undeclared
identifier is reported only once for each function it appears in
drivers/net/ethernet/smsc/smsc911x.c:1340:12: error:
?MII_LAN83C185_EDPWRDOWN? undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1341:13: error:
?MII_LAN83C185_ENERGYON? undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c: In function
?smsc911x_phy_enable_energy_detect?:
drivers/net/ethernet/smsc/smsc911x.c:1364:32: error:
?MII_LAN83C185_CTRL_STATUS? undeclared (first use in this function)
drivers/net/ethernet/smsc/smsc911x.c:1372:13: error:
?MII_LAN83C185_EDPWRDOWN? undeclared (first use in this function)
--
Regards,
Shawn
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: net/smsc911x compile error on next-20120106
2012-01-07 5:55 ` Shawn Guo
@ 2012-01-07 20:22 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2012-01-07 20:22 UTC (permalink / raw)
To: shawn.guo; +Cc: sfr, linux-next, netdev, linux-arm-kernel
From: Shawn Guo <shawn.guo@linaro.org>
Date: Sat, 7 Jan 2012 13:55:41 +0800
> Hi Stephen, David,
>
> I just ran into the following compile error when building
> next-20120106 with imx_v6_v7_defconfig.
>
I just commited the following to fix this, thanks:
--------------------
smsc911x: Unconditionally include linux/smscphy.h in smsc911x.h
The energy detect enable/disable code in the driver uses some
register defines in this header unconditionally, so guarding
the smscphy.h header include with CONFIG_SMSC_PHY leads to
build failures in some configurations.
Reported-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/ethernet/smsc/smsc911x.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.h b/drivers/net/ethernet/smsc/smsc911x.h
index 938ecf2..9ad5e5d 100644
--- a/drivers/net/ethernet/smsc/smsc911x.h
+++ b/drivers/net/ethernet/smsc/smsc911x.h
@@ -401,8 +401,6 @@
#include <asm/smsc911x.h>
#endif
-#ifdef CONFIG_SMSC_PHY
#include <linux/smscphy.h>
-#endif
#endif /* __SMSC911X_H__ */
--
1.7.6.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* linux-next: net/smsc911x compile error on next-20120106
@ 2012-01-07 20:22 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2012-01-07 20:22 UTC (permalink / raw)
To: linux-arm-kernel
From: Shawn Guo <shawn.guo@linaro.org>
Date: Sat, 7 Jan 2012 13:55:41 +0800
> Hi Stephen, David,
>
> I just ran into the following compile error when building
> next-20120106 with imx_v6_v7_defconfig.
>
I just commited the following to fix this, thanks:
--------------------
smsc911x: Unconditionally include linux/smscphy.h in smsc911x.h
The energy detect enable/disable code in the driver uses some
register defines in this header unconditionally, so guarding
the smscphy.h header include with CONFIG_SMSC_PHY leads to
build failures in some configurations.
Reported-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/ethernet/smsc/smsc911x.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.h b/drivers/net/ethernet/smsc/smsc911x.h
index 938ecf2..9ad5e5d 100644
--- a/drivers/net/ethernet/smsc/smsc911x.h
+++ b/drivers/net/ethernet/smsc/smsc911x.h
@@ -401,8 +401,6 @@
#include <asm/smsc911x.h>
#endif
-#ifdef CONFIG_SMSC_PHY
#include <linux/smscphy.h>
-#endif
#endif /* __SMSC911X_H__ */
--
1.7.6.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-07 20:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-07 5:55 linux-next: net/smsc911x compile error on next-20120106 Shawn Guo
2012-01-07 5:55 ` Shawn Guo
2012-01-07 20:22 ` David Miller
2012-01-07 20:22 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.