* [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations
@ 2012-01-06 23:55 Andrea Adami
2012-01-07 0:21 ` Martin Jansa
2012-01-07 8:05 ` Koen Kooi
0 siblings, 2 replies; 10+ messages in thread
From: Andrea Adami @ 2012-01-06 23:55 UTC (permalink / raw)
To: openembedded-devel
* delete patches meant for BSP layers
* bump PR
Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
.../Xserver.add.dpi.for.gta.patch | 29 ------------------
.../Xserver.add.nocursor.for.gta.patch | 20 ------------
.../xserver-common-1.34/Xserver.gta04.patch | 32 --------------------
.../xserver-common-1.34/Xserver.n900.patch | 17 ----------
.../xserver-common-1.34/Xserver.nexusone.patch | 14 --------
.../xserver-common-1.34/Xserver.nexuss.patch | 14 --------
.../xserver-common/xserver-common_1.34.bb | 8 +----
7 files changed, 1 insertions(+), 133 deletions(-)
delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.dpi.for.gta.patch
delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.nocursor.for.gta.patch
delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.gta04.patch
delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.n900.patch
delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexusone.patch
delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexuss.patch
diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.dpi.for.gta.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.dpi.for.gta.patch
deleted file mode 100644
index f6e36d9..0000000
--- a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.dpi.for.gta.patch
+++ /dev/null
@@ -1,29 +0,0 @@
-xdpyinfo returns 96, but 285 is right value (but 280 is used as it renders 4 columns of illume icons instead of 3 and empty space)
-
-diff -uNr xserver-common-1.33.orig//X11/xserver-common xserver-common-1.33/X11/xserver-common
---- xserver-common-1.33.orig//X11/xserver-common 2010-04-28 23:27:10.000000000 +0200
-+++ xserver-common-1.33/X11/xserver-common 2010-04-28 23:29:07.000000000 +0200
-@@ -133,19 +133,19 @@
- ARGS="$ARGS -screen ${SCREEN_SIZE}"
- DPI="225" ;;
- "gta01" )
-- DPI="285"
-+ DPI="280"
- if [ "$XSERVER" != "Xorg" ] ; then
- ARGS="$ARGS -screen 480x640"
- else
-- ARGS="$ARGS -nocursor"
-+ ARGS="$ARGS -dpi ${DPI} -nocursor"
- fi
- ;;
- "gta02")
-- DPI="285"
-+ DPI="280"
- if [ "$XSERVER" != "Xorg" ] ; then
- ARGS="$ARGS -screen ${SCREEN_SIZE}"
- else
-- ARGS="$ARGS -nocursor"
-+ ARGS="$ARGS -dpi ${DPI} -nocursor"
- fi
- ;;
- "motorola_ezx_platform")
diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.nocursor.for.gta.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.nocursor.for.gta.patch
deleted file mode 100644
index bd16efc..0000000
--- a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.nocursor.for.gta.patch
+++ /dev/null
@@ -1,20 +0,0 @@
-diff -uNr xserver-common-1.33.orig//X11/xserver-common xserver-common-1.33/X11/xserver-common
---- xserver-common-1.33.orig//X11/xserver-common 2010-04-28 10:44:23.000000000 +0200
-+++ xserver-common-1.33/X11/xserver-common 2010-04-28 10:46:41.000000000 +0200
-@@ -136,12 +136,16 @@
- DPI="285"
- if [ "$XSERVER" != "Xorg" ] ; then
- ARGS="$ARGS -screen 480x640"
-+ else
-+ ARGS="$ARGS -nocursor"
- fi
- ;;
- "gta02")
- DPI="285"
- if [ "$XSERVER" != "Xorg" ] ; then
- ARGS="$ARGS -screen ${SCREEN_SIZE}"
-+ else
-+ ARGS="$ARGS -nocursor"
- fi
- ;;
- "motorola_ezx_platform")
diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.gta04.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.gta04.patch
deleted file mode 100644
index 8a17c9a..0000000
--- a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.gta04.patch
+++ /dev/null
@@ -1,32 +0,0 @@
-From 95d741d6849a2faddf8c1e930c7250ead90e7bed Mon Sep 17 00:00:00 2001
-From: Klaus Kurzmann <mok@fluxnetz.de>
-Date: Thu, 20 Oct 2011 09:05:43 +0200
-Subject: [PATCH] gta04
-
-Signed-off-by: Klaus Kurzmann <mok@fluxnetz.de>
----
- X11/xserver-common | 8 ++++++++
- 1 files changed, 8 insertions(+), 0 deletions(-)
-
-diff --git a/X11/xserver-common b/X11/xserver-common
-index 448b262..208bbfd 100644
---- a/X11/xserver-common
-+++ b/X11/xserver-common
-@@ -161,6 +161,14 @@ else
- ARGS="$ARGS -dpi ${DPI} -nocursor"
- fi
- ;;
-+ "gta04")
-+ DPI="280"
-+ if [ "$XSERVER" != "Xorg" ] ; then
-+ ARGS="$ARGS -screen ${SCREEN_SIZE}"
-+ else
-+ ARGS="$ARGS -dpi ${DPI} -nocursor"
-+ fi
-+ ;;
- "motorola_ezx_platform")
- ARGS="$ARGS -screen 240x320"
- DPI="170" ;;
---
-1.7.7
-
diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.n900.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.n900.patch
deleted file mode 100644
index 4d36f5f..0000000
--- a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.n900.patch
+++ /dev/null
@@ -1,17 +0,0 @@
-diff -uri xserver-common-1.33.orig/X11/xserver-common xserver-common-1.33/X11/xserver-common
---- xserver-common-1.33.orig/X11/xserver-common 2010-09-14 17:10:35.955430177 +0200
-+++ xserver-common-1.33/X11/xserver-common 2010-09-14 17:17:12.484423440 +0200
-@@ -132,6 +132,13 @@
- "nokia_n800" | "nokia_rx-44" | "nokia_n770")
- ARGS="$ARGS -screen ${SCREEN_SIZE}"
- DPI="225" ;;
-+ "nokia_rx-51_board" )
-+ DPI="267"
-+ if [ "$XSERVER" != "Xorg" ] ; then
-+ ARGS="$ARGS -screen ${SCREEN_SIZE}"
-+ else
-+ ARGS="$ARGS -dpi ${DPI} -nocursor"
-+ fi ;;
- "gta01" )
- DPI="280"
- if [ "$XSERVER" != "Xorg" ] ; then
diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexusone.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexusone.patch
deleted file mode 100644
index 7d528ae..0000000
--- a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexusone.patch
+++ /dev/null
@@ -1,14 +0,0 @@
-Index: xserver-common-1.34/X11/xserver-common
-===================================================================
---- xserver-common-1.34.orig/X11/xserver-common 2011-10-10 22:36:14.163129002 +0200
-+++ xserver-common-1.34/X11/xserver-common 2011-10-10 22:37:47.513129001 +0200
-@@ -129,6 +129,9 @@
- "herring")
- DPI="235"
- ARGS="$ARGS -dpi ${DPI} -nocursor";;
-+ "mahimahi")
-+ DPI="254"
-+ ARGS="$ARGS -dpi ${DPI}";;
- "generic_omap1510/1610/1710")
- ARGS="$ARGS -screen ${SCREEN_SIZE}"
- DPI="225" ;;
diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexuss.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexuss.patch
deleted file mode 100644
index 1e564ce..0000000
--- a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexuss.patch
+++ /dev/null
@@ -1,14 +0,0 @@
-Index: xserver-common-1.34/X11/xserver-common
-===================================================================
---- xserver-common-1.34.orig/X11/xserver-common 2011-10-09 14:57:10.716896996 +0200
-+++ xserver-common-1.34/X11/xserver-common 2011-10-09 14:57:31.226897012 +0200
-@@ -126,6 +126,9 @@
- "htc_tornado")
- ARGS="$ARGS -hide-cursor"
- DPI="100" ;;
-+ "herring")
-+ DPI="235"
-+ ARGS="$ARGS -dpi ${DPI} -nocursor";;
- "generic_omap1510/1610/1710")
- ARGS="$ARGS -screen ${SCREEN_SIZE}"
- DPI="225" ;;
diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb b/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb
index 4f99a90..d326ea6 100644
--- a/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb
+++ b/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb
@@ -2,7 +2,7 @@ DESCRIPTION = "Common X11 scripts and support files"
LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
-PR = "r5"
+PR = "r6"
# we are using a gpe-style Makefile
inherit gpe
@@ -17,12 +17,6 @@ SRC_URI_append = " \
file://89xTs_Calibrate.xinput_calibrator.patch \
file://90xXWindowManager.patch \
file://Xserver.add.xserver-system.patch \
- file://Xserver.add.nocursor.for.gta.patch \
- file://Xserver.add.dpi.for.gta.patch \
- file://Xserver.n900.patch \
- file://Xserver.nexuss.patch \
- file://Xserver.nexusone.patch \
- file://Xserver.gta04.patch \
"
--
1.7.3.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations
2012-01-06 23:55 [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations Andrea Adami
@ 2012-01-07 0:21 ` Martin Jansa
2012-01-07 8:05 ` Koen Kooi
1 sibling, 0 replies; 10+ messages in thread
From: Martin Jansa @ 2012-01-07 0:21 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 10621 bytes --]
On Sat, Jan 07, 2012 at 12:55:28AM +0100, Andrea Adami wrote:
> * delete patches meant for BSP layers
will you send patches adding it back to those BSP layers, please?
> * bump PR
>
> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> ---
> .../Xserver.add.dpi.for.gta.patch | 29 ------------------
> .../Xserver.add.nocursor.for.gta.patch | 20 ------------
> .../xserver-common-1.34/Xserver.gta04.patch | 32 --------------------
> .../xserver-common-1.34/Xserver.n900.patch | 17 ----------
> .../xserver-common-1.34/Xserver.nexusone.patch | 14 --------
> .../xserver-common-1.34/Xserver.nexuss.patch | 14 --------
> .../xserver-common/xserver-common_1.34.bb | 8 +----
> 7 files changed, 1 insertions(+), 133 deletions(-)
> delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.dpi.for.gta.patch
> delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.nocursor.for.gta.patch
> delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.gta04.patch
> delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.n900.patch
> delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexusone.patch
> delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexuss.patch
>
> diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.dpi.for.gta.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.dpi.for.gta.patch
> deleted file mode 100644
> index f6e36d9..0000000
> --- a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.dpi.for.gta.patch
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -xdpyinfo returns 96, but 285 is right value (but 280 is used as it renders 4 columns of illume icons instead of 3 and empty space)
> -
> -diff -uNr xserver-common-1.33.orig//X11/xserver-common xserver-common-1.33/X11/xserver-common
> ---- xserver-common-1.33.orig//X11/xserver-common 2010-04-28 23:27:10.000000000 +0200
> -+++ xserver-common-1.33/X11/xserver-common 2010-04-28 23:29:07.000000000 +0200
> -@@ -133,19 +133,19 @@
> - ARGS="$ARGS -screen ${SCREEN_SIZE}"
> - DPI="225" ;;
> - "gta01" )
> -- DPI="285"
> -+ DPI="280"
> - if [ "$XSERVER" != "Xorg" ] ; then
> - ARGS="$ARGS -screen 480x640"
> - else
> -- ARGS="$ARGS -nocursor"
> -+ ARGS="$ARGS -dpi ${DPI} -nocursor"
> - fi
> - ;;
> - "gta02")
> -- DPI="285"
> -+ DPI="280"
> - if [ "$XSERVER" != "Xorg" ] ; then
> - ARGS="$ARGS -screen ${SCREEN_SIZE}"
> - else
> -- ARGS="$ARGS -nocursor"
> -+ ARGS="$ARGS -dpi ${DPI} -nocursor"
> - fi
> - ;;
> - "motorola_ezx_platform")
> diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.nocursor.for.gta.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.nocursor.for.gta.patch
> deleted file mode 100644
> index bd16efc..0000000
> --- a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.nocursor.for.gta.patch
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -diff -uNr xserver-common-1.33.orig//X11/xserver-common xserver-common-1.33/X11/xserver-common
> ---- xserver-common-1.33.orig//X11/xserver-common 2010-04-28 10:44:23.000000000 +0200
> -+++ xserver-common-1.33/X11/xserver-common 2010-04-28 10:46:41.000000000 +0200
> -@@ -136,12 +136,16 @@
> - DPI="285"
> - if [ "$XSERVER" != "Xorg" ] ; then
> - ARGS="$ARGS -screen 480x640"
> -+ else
> -+ ARGS="$ARGS -nocursor"
> - fi
> - ;;
> - "gta02")
> - DPI="285"
> - if [ "$XSERVER" != "Xorg" ] ; then
> - ARGS="$ARGS -screen ${SCREEN_SIZE}"
> -+ else
> -+ ARGS="$ARGS -nocursor"
> - fi
> - ;;
> - "motorola_ezx_platform")
> diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.gta04.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.gta04.patch
> deleted file mode 100644
> index 8a17c9a..0000000
> --- a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.gta04.patch
> +++ /dev/null
> @@ -1,32 +0,0 @@
> -From 95d741d6849a2faddf8c1e930c7250ead90e7bed Mon Sep 17 00:00:00 2001
> -From: Klaus Kurzmann <mok@fluxnetz.de>
> -Date: Thu, 20 Oct 2011 09:05:43 +0200
> -Subject: [PATCH] gta04
> -
> -Signed-off-by: Klaus Kurzmann <mok@fluxnetz.de>
> ----
> - X11/xserver-common | 8 ++++++++
> - 1 files changed, 8 insertions(+), 0 deletions(-)
> -
> -diff --git a/X11/xserver-common b/X11/xserver-common
> -index 448b262..208bbfd 100644
> ---- a/X11/xserver-common
> -+++ b/X11/xserver-common
> -@@ -161,6 +161,14 @@ else
> - ARGS="$ARGS -dpi ${DPI} -nocursor"
> - fi
> - ;;
> -+ "gta04")
> -+ DPI="280"
> -+ if [ "$XSERVER" != "Xorg" ] ; then
> -+ ARGS="$ARGS -screen ${SCREEN_SIZE}"
> -+ else
> -+ ARGS="$ARGS -dpi ${DPI} -nocursor"
> -+ fi
> -+ ;;
> - "motorola_ezx_platform")
> - ARGS="$ARGS -screen 240x320"
> - DPI="170" ;;
> ---
> -1.7.7
> -
> diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.n900.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.n900.patch
> deleted file mode 100644
> index 4d36f5f..0000000
> --- a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.n900.patch
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -diff -uri xserver-common-1.33.orig/X11/xserver-common xserver-common-1.33/X11/xserver-common
> ---- xserver-common-1.33.orig/X11/xserver-common 2010-09-14 17:10:35.955430177 +0200
> -+++ xserver-common-1.33/X11/xserver-common 2010-09-14 17:17:12.484423440 +0200
> -@@ -132,6 +132,13 @@
> - "nokia_n800" | "nokia_rx-44" | "nokia_n770")
> - ARGS="$ARGS -screen ${SCREEN_SIZE}"
> - DPI="225" ;;
> -+ "nokia_rx-51_board" )
> -+ DPI="267"
> -+ if [ "$XSERVER" != "Xorg" ] ; then
> -+ ARGS="$ARGS -screen ${SCREEN_SIZE}"
> -+ else
> -+ ARGS="$ARGS -dpi ${DPI} -nocursor"
> -+ fi ;;
> - "gta01" )
> - DPI="280"
> - if [ "$XSERVER" != "Xorg" ] ; then
> diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexusone.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexusone.patch
> deleted file mode 100644
> index 7d528ae..0000000
> --- a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexusone.patch
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -Index: xserver-common-1.34/X11/xserver-common
> -===================================================================
> ---- xserver-common-1.34.orig/X11/xserver-common 2011-10-10 22:36:14.163129002 +0200
> -+++ xserver-common-1.34/X11/xserver-common 2011-10-10 22:37:47.513129001 +0200
> -@@ -129,6 +129,9 @@
> - "herring")
> - DPI="235"
> - ARGS="$ARGS -dpi ${DPI} -nocursor";;
> -+ "mahimahi")
> -+ DPI="254"
> -+ ARGS="$ARGS -dpi ${DPI}";;
> - "generic_omap1510/1610/1710")
> - ARGS="$ARGS -screen ${SCREEN_SIZE}"
> - DPI="225" ;;
> diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexuss.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexuss.patch
> deleted file mode 100644
> index 1e564ce..0000000
> --- a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexuss.patch
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -Index: xserver-common-1.34/X11/xserver-common
> -===================================================================
> ---- xserver-common-1.34.orig/X11/xserver-common 2011-10-09 14:57:10.716896996 +0200
> -+++ xserver-common-1.34/X11/xserver-common 2011-10-09 14:57:31.226897012 +0200
> -@@ -126,6 +126,9 @@
> - "htc_tornado")
> - ARGS="$ARGS -hide-cursor"
> - DPI="100" ;;
> -+ "herring")
> -+ DPI="235"
> -+ ARGS="$ARGS -dpi ${DPI} -nocursor";;
> - "generic_omap1510/1610/1710")
> - ARGS="$ARGS -screen ${SCREEN_SIZE}"
> - DPI="225" ;;
> diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb b/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb
> index 4f99a90..d326ea6 100644
> --- a/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb
> +++ b/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb
> @@ -2,7 +2,7 @@ DESCRIPTION = "Common X11 scripts and support files"
> LICENSE = "GPLv2"
> LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
>
> -PR = "r5"
> +PR = "r6"
>
> # we are using a gpe-style Makefile
> inherit gpe
> @@ -17,12 +17,6 @@ SRC_URI_append = " \
> file://89xTs_Calibrate.xinput_calibrator.patch \
> file://90xXWindowManager.patch \
> file://Xserver.add.xserver-system.patch \
> - file://Xserver.add.nocursor.for.gta.patch \
> - file://Xserver.add.dpi.for.gta.patch \
> - file://Xserver.n900.patch \
> - file://Xserver.nexuss.patch \
> - file://Xserver.nexusone.patch \
> - file://Xserver.gta04.patch \
> "
>
>
> --
> 1.7.3.4
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations
2012-01-06 23:55 [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations Andrea Adami
2012-01-07 0:21 ` Martin Jansa
@ 2012-01-07 8:05 ` Koen Kooi
2012-01-07 10:41 ` Otavio Salvador
1 sibling, 1 reply; 10+ messages in thread
From: Koen Kooi @ 2012-01-07 8:05 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 07-01-12 00:55, Andrea Adami schreef:
> * delete patches meant for BSP layers * bump PR
With a recipe like xserver-common I don't see a point in going all out BSP
on it. This patch just moves things to layers just for the sake of moving it
to layers. I strongly suspect that applying this patch will be a net burden
on device maintainers instead of a gain.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org
iEYEARECAAYFAk8H/NIACgkQMkyGM64RGpEvwACfRRHrwdZqrc3UrqSNvEOPvh8w
kIoAn2Wpy6va4V/Y369vSwDj7AcZLuNO
=oYt/
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations
2012-01-07 8:05 ` Koen Kooi
@ 2012-01-07 10:41 ` Otavio Salvador
2012-01-07 10:49 ` Martin Jansa
0 siblings, 1 reply; 10+ messages in thread
From: Otavio Salvador @ 2012-01-07 10:41 UTC (permalink / raw)
To: openembedded-devel
On Sat, Jan 7, 2012 at 06:05, Koen Kooi <koen@dominion.thruhere.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 07-01-12 00:55, Andrea Adami schreef:
> > * delete patches meant for BSP layers * bump PR
>
> With a recipe like xserver-common I don't see a point in going all out BSP
> on it. This patch just moves things to layers just for the sake of moving
> it
> to layers. I strongly suspect that applying this patch will be a net burden
> on device maintainers instead of a gain.
>
I agree this is going to be bad at first but those kind of improvements
always cause some problems for a later gain. Dropping things that ought to
be in BSP layers is a good thing but only after the "fix other layers" time
window.
I think this is worth it however it might be better to instead port the
needed changes to OE-Core and ask other layers to adopt x11-common allowing
us to remove this later on. This makes the change easier and avoid some
problems for users IMO.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations
2012-01-07 10:41 ` Otavio Salvador
@ 2012-01-07 10:49 ` Martin Jansa
2012-01-07 13:22 ` Andrea Adami
0 siblings, 1 reply; 10+ messages in thread
From: Martin Jansa @ 2012-01-07 10:49 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]
On Sat, Jan 07, 2012 at 08:41:51AM -0200, Otavio Salvador wrote:
> On Sat, Jan 7, 2012 at 06:05, Koen Kooi <koen@dominion.thruhere.net> wrote:
>
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Op 07-01-12 00:55, Andrea Adami schreef:
> > > * delete patches meant for BSP layers * bump PR
> >
> > With a recipe like xserver-common I don't see a point in going all out BSP
> > on it. This patch just moves things to layers just for the sake of moving
> > it
> > to layers. I strongly suspect that applying this patch will be a net burden
> > on device maintainers instead of a gain.
> >
>
> I agree this is going to be bad at first but those kind of improvements
> always cause some problems for a later gain. Dropping things that ought to
> be in BSP layers is a good thing but only after the "fix other layers" time
> window.
>
> I think this is worth it however it might be better to instead port the
> needed changes to OE-Core and ask other layers to adopt x11-common allowing
> us to remove this later on. This makes the change easier and avoid some
> problems for users IMO.
This whole recipe has machine specific bits and removing those bits
only of some machines (in this case all from meta-smartphone BSPs)
doesn't improve that recipe.
So if you want to improve it, merge extra functionality (like
xinput-pointercal) to oe-core and drop this completely, but breaking
some machines doesn't make thinks better.
Instead of "fixing" it in meta-smartphone BSPs I would just copy whole
xserver-common back to meta-shr, because I don't have time now to fix it
properly and spending time on .bbappends is not worth it in this case.
Cheers,
JaMa, from daywork..ffs
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations
2012-01-07 10:49 ` Martin Jansa
@ 2012-01-07 13:22 ` Andrea Adami
2012-01-07 13:33 ` Otavio Salvador
2012-01-07 13:42 ` Martin Jansa
0 siblings, 2 replies; 10+ messages in thread
From: Andrea Adami @ 2012-01-07 13:22 UTC (permalink / raw)
To: openembedded-devel
On Sat, Jan 7, 2012 at 11:49 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Sat, Jan 07, 2012 at 08:41:51AM -0200, Otavio Salvador wrote:
>> On Sat, Jan 7, 2012 at 06:05, Koen Kooi <koen@dominion.thruhere.net> wrote:
>>
>> > -----BEGIN PGP SIGNED MESSAGE-----
>> > Hash: SHA1
>> >
>> > Op 07-01-12 00:55, Andrea Adami schreef:
>> > > * delete patches meant for BSP layers * bump PR
>> >
>> > With a recipe like xserver-common I don't see a point in going all out BSP
>> > on it. This patch just moves things to layers just for the sake of moving
>> > it
>> > to layers. I strongly suspect that applying this patch will be a net burden
>> > on device maintainers instead of a gain.
>> >
>>
>> I agree this is going to be bad at first but those kind of improvements
>> always cause some problems for a later gain. Dropping things that ought to
>> be in BSP layers is a good thing but only after the "fix other layers" time
>> window.
>>
>> I think this is worth it however it might be better to instead port the
>> needed changes to OE-Core and ask other layers to adopt x11-common allowing
>> us to remove this later on. This makes the change easier and avoid some
>> problems for users IMO.
>
> This whole recipe has machine specific bits and removing those bits
> only of some machines (in this case all from meta-smartphone BSPs)
> doesn't improve that recipe.
>
> So if you want to improve it, merge extra functionality (like
> xinput-pointercal) to oe-core and drop this completely, but breaking
> some machines doesn't make thinks better.
>
> Instead of "fixing" it in meta-smartphone BSPs I would just copy whole
> xserver-common back to meta-shr, because I don't have time now to fix it
> properly and spending time on .bbappends is not worth it in this case.
>
> Cheers,
>
> JaMa, from daywork..ffs
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
I try to explain again my intent:
1) we have at the moment two xserver-nodm-init, one in meta-oe and one
in oe-core
2) this is intrinsecaly bad and moreover the two recipes are totally
different with regards to runtime dependencies
3) as it is now, oe-core expects to use x11-common while in meta-oe
there is xserver-common
4) xserver-common is an old recipe coming from the oe-classic times,
designed to work with gpe environments and targeting mostly kdrive.
Thius recipe contains alot of BSP code.
5) today, if one builds core-image-sato distroless for zaurus qvga
using meta-oe the xserver won't start because of the bad settings
provided by the recipe.
So, I already sent a msg in that regard before (
http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-October/035564.html
) and now I'm trying to help cleaning both sides.
The patch for x11-common was taken in oe-core but this one for meta-oe
is unexpectedly under discussion.
BE sure my intentions are not to increase maintenance burden, on the
opposite I'd like neutral/sane defaults and patches to override those
in the BSP layers.
Regards
Andrea
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations
2012-01-07 13:22 ` Andrea Adami
@ 2012-01-07 13:33 ` Otavio Salvador
2012-01-07 13:42 ` Martin Jansa
1 sibling, 0 replies; 10+ messages in thread
From: Otavio Salvador @ 2012-01-07 13:33 UTC (permalink / raw)
To: openembedded-devel
On Sat, Jan 7, 2012 at 11:22, Andrea Adami <andrea.adami@gmail.com> wrote:
> I try to explain again my intent:
>
> 1) we have at the moment two xserver-nodm-init, one in meta-oe and one
> in oe-core
>
Yes and we ought to sort it out and merge meta-oe improvements on oe-core
one.
> ...
3) as it is now, oe-core expects to use x11-common while in meta-oe
> there is xserver-common
>
This is the real point. Instead of changing xserver-common the right way of
fixing it is porting changes need to x11-common and drop xserver-common
from meta-oe afterwards. This will reduce the delta between oe-core and
meta-oe plus making sane defaults working out of box :-)
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations
2012-01-07 13:22 ` Andrea Adami
2012-01-07 13:33 ` Otavio Salvador
@ 2012-01-07 13:42 ` Martin Jansa
2012-01-07 16:37 ` Andrea Adami
1 sibling, 1 reply; 10+ messages in thread
From: Martin Jansa @ 2012-01-07 13:42 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 4001 bytes --]
On Sat, Jan 07, 2012 at 02:22:24PM +0100, Andrea Adami wrote:
> On Sat, Jan 7, 2012 at 11:49 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Sat, Jan 07, 2012 at 08:41:51AM -0200, Otavio Salvador wrote:
> >> On Sat, Jan 7, 2012 at 06:05, Koen Kooi <koen@dominion.thruhere.net> wrote:
> >>
> >> > -----BEGIN PGP SIGNED MESSAGE-----
> >> > Hash: SHA1
> >> >
> >> > Op 07-01-12 00:55, Andrea Adami schreef:
> >> > > * delete patches meant for BSP layers * bump PR
> >> >
> >> > With a recipe like xserver-common I don't see a point in going all out BSP
> >> > on it. This patch just moves things to layers just for the sake of moving
> >> > it
> >> > to layers. I strongly suspect that applying this patch will be a net burden
> >> > on device maintainers instead of a gain.
> >> >
> >>
> >> I agree this is going to be bad at first but those kind of improvements
> >> always cause some problems for a later gain. Dropping things that ought to
> >> be in BSP layers is a good thing but only after the "fix other layers" time
> >> window.
> >>
> >> I think this is worth it however it might be better to instead port the
> >> needed changes to OE-Core and ask other layers to adopt x11-common allowing
> >> us to remove this later on. This makes the change easier and avoid some
> >> problems for users IMO.
> >
> > This whole recipe has machine specific bits and removing those bits
> > only of some machines (in this case all from meta-smartphone BSPs)
> > doesn't improve that recipe.
> >
> > So if you want to improve it, merge extra functionality (like
> > xinput-pointercal) to oe-core and drop this completely, but breaking
> > some machines doesn't make thinks better.
> >
> > Instead of "fixing" it in meta-smartphone BSPs I would just copy whole
> > xserver-common back to meta-shr, because I don't have time now to fix it
> > properly and spending time on .bbappends is not worth it in this case.
> >
> > Cheers,
> >
> > JaMa, from daywork..ffs
> >
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> >
>
> I try to explain again my intent:
>
> 1) we have at the moment two xserver-nodm-init, one in meta-oe and one
> in oe-core
> 2) this is intrinsecaly bad and moreover the two recipes are totally
> different with regards to runtime dependencies
I'm aware of that and said that many times, just to busy with daywork
(in last couple of months) to fix it myself ;/.
> 3) as it is now, oe-core expects to use x11-common while in meta-oe
> there is xserver-common
I've already explained to you to use VIRTUAL_RUNTIME vars.
> 4) xserver-common is an old recipe coming from the oe-classic times,
> designed to work with gpe environments and targeting mostly kdrive.
> Thius recipe contains alot of BSP code.
Yes and those patches you've removed are not making it worse, upstream
script contains a lot of BSP code already and those patches are just
making it more complete (think about it as patch which should be applied
upstream not in BSP layer).
> 5) today, if one builds core-image-sato distroless for zaurus qvga
> using meta-oe the xserver won't start because of the bad settings
> provided by the recipe.
see A3).
> So, I already sent a msg in that regard before (
> http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-October/035564.html
> ) and now I'm trying to help cleaning both sides.
> The patch for x11-common was taken in oe-core but this one for meta-oe
> is unexpectedly under discussion.
> BE sure my intentions are not to increase maintenance burden, on the
> opposite I'd like neutral/sane defaults and patches to override those
> in the BSP layers.
burden is to force people to fix recipe which should be removed instead.
Regards,
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations
2012-01-07 13:42 ` Martin Jansa
@ 2012-01-07 16:37 ` Andrea Adami
2012-01-07 16:44 ` Otavio Salvador
0 siblings, 1 reply; 10+ messages in thread
From: Andrea Adami @ 2012-01-07 16:37 UTC (permalink / raw)
To: openembedded-devel
On Sat, Jan 7, 2012 at 2:42 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Sat, Jan 07, 2012 at 02:22:24PM +0100, Andrea Adami wrote:
>> On Sat, Jan 7, 2012 at 11:49 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> > On Sat, Jan 07, 2012 at 08:41:51AM -0200, Otavio Salvador wrote:
>> >> On Sat, Jan 7, 2012 at 06:05, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> >>
>> >> > -----BEGIN PGP SIGNED MESSAGE-----
>> >> > Hash: SHA1
>> >> >
>> >> > Op 07-01-12 00:55, Andrea Adami schreef:
>> >> > > * delete patches meant for BSP layers * bump PR
>> >> >
>> >> > With a recipe like xserver-common I don't see a point in going all out BSP
>> >> > on it. This patch just moves things to layers just for the sake of moving
>> >> > it
>> >> > to layers. I strongly suspect that applying this patch will be a net burden
>> >> > on device maintainers instead of a gain.
>> >> >
>> >>
>> >> I agree this is going to be bad at first but those kind of improvements
>> >> always cause some problems for a later gain. Dropping things that ought to
>> >> be in BSP layers is a good thing but only after the "fix other layers" time
>> >> window.
>> >>
>> >> I think this is worth it however it might be better to instead port the
>> >> needed changes to OE-Core and ask other layers to adopt x11-common allowing
>> >> us to remove this later on. This makes the change easier and avoid some
>> >> problems for users IMO.
>> >
>> > This whole recipe has machine specific bits and removing those bits
>> > only of some machines (in this case all from meta-smartphone BSPs)
>> > doesn't improve that recipe.
>> >
>> > So if you want to improve it, merge extra functionality (like
>> > xinput-pointercal) to oe-core and drop this completely, but breaking
>> > some machines doesn't make thinks better.
>> >
>> > Instead of "fixing" it in meta-smartphone BSPs I would just copy whole
>> > xserver-common back to meta-shr, because I don't have time now to fix it
>> > properly and spending time on .bbappends is not worth it in this case.
>> >
>> > Cheers,
>> >
>> > JaMa, from daywork..ffs
>> >
>> > _______________________________________________
>> > Openembedded-devel mailing list
>> > Openembedded-devel@lists.openembedded.org
>> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>> >
>>
>> I try to explain again my intent:
>>
>> 1) we have at the moment two xserver-nodm-init, one in meta-oe and one
>> in oe-core
>> 2) this is intrinsecaly bad and moreover the two recipes are totally
>> different with regards to runtime dependencies
>
> I'm aware of that and said that many times, just to busy with daywork
> (in last couple of months) to fix it myself ;/.
>
>> 3) as it is now, oe-core expects to use x11-common while in meta-oe
>> there is xserver-common
>
> I've already explained to you to use VIRTUAL_RUNTIME vars.
Sorry but this is not enough in order to obtain a core-image-sato with
working xserver on first run.
The meta-oe layer is 'toxic' in that regard.
>
>> 4) xserver-common is an old recipe coming from the oe-classic times,
>> designed to work with gpe environments and targeting mostly kdrive.
>> Thius recipe contains alot of BSP code.
>
> Yes and those patches you've removed are not making it worse, upstream
> script contains a lot of BSP code already and those patches are just
> making it more complete (think about it as patch which should be applied
> upstream not in BSP layer).
>
Those patches ought to be sent upstream long agoi...
I'm sure Florian will apply almost immediately once aware.
>> 5) today, if one builds core-image-sato distroless for zaurus qvga
>> using meta-oe the xserver won't start because of the bad settings
>> provided by the recipe.
>
> see A3).
>
>> So, I already sent a msg in that regard before (
>> http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-October/035564.html
>> ) and now I'm trying to help cleaning both sides.
>> The patch for x11-common was taken in oe-core but this one for meta-oe
>> is unexpectedly under discussion.
>> BE sure my intentions are not to increase maintenance burden, on the
>> opposite I'd like neutral/sane defaults and patches to override those
>> in the BSP layers.
>
> burden is to force people to fix recipe which should be removed instead.
>
This is my last reply to this thread.
Again I'm sorry to force maintainers of external layers to react and
make hanges but there is anything wrong with this.
We did agree the policy of meta-oe is the same of oe-core, thus no BSP
code is allowed. Stop.
I'd expect the maintainer agrees.
Cheers
Andrea
> Regards,
>
> --
> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations
2012-01-07 16:37 ` Andrea Adami
@ 2012-01-07 16:44 ` Otavio Salvador
0 siblings, 0 replies; 10+ messages in thread
From: Otavio Salvador @ 2012-01-07 16:44 UTC (permalink / raw)
To: openembedded-devel
On Sat, Jan 7, 2012 at 14:37, Andrea Adami <andrea.adami@gmail.com> wrote:
> > I've already explained to you to use VIRTUAL_RUNTIME vars.
>
> Sorry but this is not enough in order to obtain a core-image-sato with
> working xserver on first run.
> The meta-oe layer is 'toxic' in that regard.
Agreed; that's why I said you could fix x11-common and make it work so we
can drop xserver-common from meta-oe.
> >> 4) xserver-common is an old recipe coming from the oe-classic times,
> >> designed to work with gpe environments and targeting mostly kdrive.
> >> Thius recipe contains alot of BSP code.
> >
> > Yes and those patches you've removed are not making it worse, upstream
> > script contains a lot of BSP code already and those patches are just
> > making it more complete (think about it as patch which should be applied
> > upstream not in BSP layer).
> >
>
> Those patches ought to be sent upstream long agoi...
> I'm sure Florian will apply almost immediately once aware.
>
>
> >> 5) today, if one builds core-image-sato distroless for zaurus qvga
> >> using meta-oe the xserver won't start because of the bad settings
> >> provided by the recipe.
> >
> > see A3).
> >
> >> So, I already sent a msg in that regard before (
> >>
> http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-October/035564.html
> >> ) and now I'm trying to help cleaning both sides.
> >> The patch for x11-common was taken in oe-core but this one for meta-oe
> >> is unexpectedly under discussion.
> >> BE sure my intentions are not to increase maintenance burden, on the
> >> opposite I'd like neutral/sane defaults and patches to override those
> >> in the BSP layers.
> >
> > burden is to force people to fix recipe which should be removed instead.
> >
>
> This is my last reply to this thread.
> Again I'm sorry to force maintainers of external layers to react and
> make hanges but there is anything wrong with this.
> We did agree the policy of meta-oe is the same of oe-core, thus no BSP
> code is allowed. Stop.
> I'd expect the maintainer agrees.
>
I think you missunderstood it. We are not saying it shouldn't be removed
but we're saying we ought to do that in another way.
This will be removed all together with xserver-common in the move to
x11-common but for this, x11-common need to have the improvements done on
xserver-common merged.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-01-07 16:52 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-06 23:55 [meta-oe] [PATCH] xserver-common: remove extraneous BSP customizations Andrea Adami
2012-01-07 0:21 ` Martin Jansa
2012-01-07 8:05 ` Koen Kooi
2012-01-07 10:41 ` Otavio Salvador
2012-01-07 10:49 ` Martin Jansa
2012-01-07 13:22 ` Andrea Adami
2012-01-07 13:33 ` Otavio Salvador
2012-01-07 13:42 ` Martin Jansa
2012-01-07 16:37 ` Andrea Adami
2012-01-07 16:44 ` Otavio Salvador
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.