* [to-be-updated] ipc-mqueue-switch-back-to-using-non-max-values-on-create.patch removed from -mm tree
@ 2012-01-10 23:57 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2012-01-10 23:57 UTC (permalink / raw)
To: dledford, amwang, joe.korty, manfred, serue, stable, stable, mm-commits
The patch titled
Subject: ipc/mqueue: switch back to using non-max values on create
has been removed from the -mm tree. Its filename was
ipc-mqueue-switch-back-to-using-non-max-values-on-create.patch
This patch was dropped because an updated version will be merged
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
From: Doug Ledford <dledford@redhat.com>
Subject: ipc/mqueue: switch back to using non-max values on create
Commit b231cca4381ee15e ("message queues: increase range limits") changed
how we create a queue that does not include an attr struct passed to open
so that it creates the queue with whatever the maximum values are.
However, if the admin has set the maximums to allow flexibility in
creating a queue (aka, both a large size and large queue are allowed, but
combined they create a queue too large for the RLIMIT_MSGQUEUE of the
user), then attempts to create a queue without an attr struct will fail.
Switch back to using acceptable defaults regardless of what the maximums
are.
Signed-off-by: Doug Ledford <dledford@redhat.com>
Cc: Amerigo Wang <amwang@redhat.com>
Cc: Serge E. Hallyn <serue@us.ibm.com>
Cc: Joe Korty <joe.korty@ccur.com>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: <stable@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/ipc_namespace.h | 2 ++
ipc/mqueue.c | 5 +++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff -puN include/linux/ipc_namespace.h~ipc-mqueue-switch-back-to-using-non-max-values-on-create include/linux/ipc_namespace.h
--- a/include/linux/ipc_namespace.h~ipc-mqueue-switch-back-to-using-non-max-values-on-create
+++ a/include/linux/ipc_namespace.h
@@ -95,9 +95,11 @@ extern int mq_init_ns(struct ipc_namespa
#define DFLT_QUEUESMAX 256 /* max number of message queues */
#define HARD_QUEUESMAX 1024
#define MIN_MSGMAX 1
+#define DFLT_MSG 10U
#define DFLT_MSGMAX 10 /* max number of messages in each queue */
#define HARD_MSGMAX (32768*sizeof(void *)/4)
#define MIN_MSGSIZEMAX 128
+#define DFLT_MSGSIZE 8192U
#define DFLT_MSGSIZEMAX 8192 /* max message size */
#define HARD_MSGSIZEMAX (8192*128)
#else
diff -puN ipc/mqueue.c~ipc-mqueue-switch-back-to-using-non-max-values-on-create ipc/mqueue.c
--- a/ipc/mqueue.c~ipc-mqueue-switch-back-to-using-non-max-values-on-create
+++ a/ipc/mqueue.c
@@ -143,8 +143,9 @@ static struct inode *mqueue_get_inode(st
info->qsize = 0;
info->user = NULL; /* set when all is ok */
memset(&info->attr, 0, sizeof(info->attr));
- info->attr.mq_maxmsg = ipc_ns->mq_msg_max;
- info->attr.mq_msgsize = ipc_ns->mq_msgsize_max;
+ info->attr.mq_maxmsg = min(ipc_ns->mq_msg_max, DFLT_MSG);
+ info->attr.mq_msgsize =
+ min(ipc_ns->mq_msgsize_max, DFLT_MSGSIZE);
if (attr) {
info->attr.mq_maxmsg = attr->mq_maxmsg;
info->attr.mq_msgsize = attr->mq_msgsize;
_
Patches currently in -mm which might be from dledford@redhat.com are
ipc-mqueue-enforce-hard-limits.patch
ipc-mqueue-update-maximums-for-the-mqueue-subsystem.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-01-10 23:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-10 23:57 [to-be-updated] ipc-mqueue-switch-back-to-using-non-max-values-on-create.patch removed from -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.