* [PATCH RESEND] mac80211: support fixed rate packet injection
@ 2012-01-12 17:53 Sam Leffler
2012-01-20 14:17 ` Johannes Berg
0 siblings, 1 reply; 6+ messages in thread
From: Sam Leffler @ 2012-01-12 17:53 UTC (permalink / raw)
To: linux-wireless; +Cc: John W. Linville
Support setting the transmit rate, flags, and try count for
injected packets by parsing the IEEE80211_RADIOTAP_RATE,
IEEE80211_RADIOTAP_DATA_RETRIES, and IEEE80211_RADIOTAP_MCS radiotap tags.
Signed-off-by: sleffler@chromium.org
---
Documentation/networking/mac80211-injection.txt | 13 ++++
include/net/mac80211.h | 4 +
net/mac80211/tx.c | 69 ++++++++++++++++++++++-
net/wireless/radiotap.c | 1 +
4 files changed, 84 insertions(+), 3 deletions(-)
diff --git a/Documentation/networking/mac80211-injection.txt b/Documentation/networking/mac80211-injection.txt
index 3a93007..8847a4c 100644
--- a/Documentation/networking/mac80211-injection.txt
+++ b/Documentation/networking/mac80211-injection.txt
@@ -23,11 +23,24 @@ radiotap headers and used to control injection:
IEEE80211_RADIOTAP_F_FRAG: frame will be fragmented if longer than the
current fragmentation threshold.
+ * IEEE80211_RADIOTAP_RATE
+ legacy transmit rate in .5 Mb/s units (u8)
+
* IEEE80211_RADIOTAP_TX_FLAGS
IEEE80211_RADIOTAP_F_TX_NOACK: frame should be sent without waiting for
an ACK even if it is a unicast frame
+ * IEEE80211_RADIOTAP_DATA_RETRIES
+ transmit retry count (u8): may be ignored if NOACK set or bcast/mcast address
+
+ * IEEE80211_RADIOTAP_MCS
+ have_flags(u8), flags(u8), mcs(u8)
+
+ IEEE80211_RADIOTAP_MCS_HAVE_MCS: use MCS value in mcs
+ IEEE80211_RADIOTAP_MCS_HAVE_GI: set GI according to flags
+ IEEE80211_RADIOTAP_MCS_HAVE_BW: set BW according to flags
+
The injection code can also skip all other currently defined radiotap fields
facilitating replay of captured radiotap headers directly.
diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index 2a7523e..5045277 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -378,6 +378,9 @@ struct ieee80211_bss_conf {
* @IEEE80211_TX_CTL_DONTFRAG: Don't fragment this packet even if it
* would be fragmented by size (this is optional, only used for
* monitor injection).
+ * @IEEE80211_TX_CTL_NO_RC: This frame does not require rate control.
+ * This flag is used when an injected frame includes a transmit
+ * rate (and possibly flags and retry count) in the radiotap header.
*
* Note: If you have to add new flags to the enumeration, then don't
* forget to update %IEEE80211_TX_TEMPORARY_FLAGS when necessary.
@@ -412,6 +415,7 @@ enum mac80211_tx_control_flags {
IEEE80211_TX_STATUS_EOSP = BIT(28),
IEEE80211_TX_CTL_USE_MINRATE = BIT(29),
IEEE80211_TX_CTL_DONTFRAG = BIT(30),
+ IEEE80211_TX_CTL_NO_RC = BIT(31),
};
#define IEEE80211_TX_CTL_STBC_SHIFT 23
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index e05667c..275f6a8 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1317,7 +1317,8 @@ static int invoke_tx_handlers(struct ieee80211_tx_data *tx)
CALL_TXH(ieee80211_tx_h_ps_buf);
CALL_TXH(ieee80211_tx_h_check_control_port_protocol);
CALL_TXH(ieee80211_tx_h_select_key);
- if (!(tx->local->hw.flags & IEEE80211_HW_HAS_RATE_CONTROL))
+ if (!(tx->local->hw.flags & IEEE80211_HW_HAS_RATE_CONTROL) &&
+ !(info->flags & IEEE80211_TX_CTL_NO_RC))
CALL_TXH(ieee80211_tx_h_rate_ctrl);
if (unlikely(info->flags & IEEE80211_TX_INTFL_RETRANSMISSION)) {
@@ -1466,7 +1467,8 @@ void ieee80211_xmit(struct ieee80211_sub_if_data *sdata, struct sk_buff *skb)
rcu_read_unlock();
}
-static bool ieee80211_parse_tx_radiotap(struct sk_buff *skb)
+static bool ieee80211_parse_tx_radiotap(struct sk_buff *skb,
+ struct ieee80211_local *local)
{
struct ieee80211_radiotap_iterator iterator;
struct ieee80211_radiotap_header *rthdr =
@@ -1474,6 +1476,8 @@ static bool ieee80211_parse_tx_radiotap(struct sk_buff *skb)
struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
int ret = ieee80211_radiotap_iterator_init(&iterator, rthdr, skb->len,
NULL);
+ u8 fixed_rate = 0, fixed_rate_data_retries = 0;
+ u32 fixed_rate_flags = 0;
u16 txflags;
info->flags |= IEEE80211_TX_INTFL_DONT_ENCRYPT |
@@ -1519,12 +1523,36 @@ static bool ieee80211_parse_tx_radiotap(struct sk_buff *skb)
info->flags &= ~IEEE80211_TX_CTL_DONTFRAG;
break;
+ case IEEE80211_RADIOTAP_RATE: /* u8 */
+ fixed_rate = *iterator.this_arg;
+ break;
+
case IEEE80211_RADIOTAP_TX_FLAGS:
txflags = get_unaligned_le16(iterator.this_arg);
if (txflags & IEEE80211_RADIOTAP_F_TX_NOACK)
info->flags |= IEEE80211_TX_CTL_NO_ACK;
break;
+ case IEEE80211_RADIOTAP_DATA_RETRIES: /* u8 */
+ fixed_rate_data_retries = *iterator.this_arg;
+ break;
+
+ case IEEE80211_RADIOTAP_MCS: { /* u8,u8,u8 */
+ u8 mcs_have = iterator.this_arg[0];
+ if (mcs_have & IEEE80211_RADIOTAP_MCS_HAVE_MCS) {
+ fixed_rate = iterator.this_arg[2];
+ fixed_rate_flags |= IEEE80211_TX_RC_MCS;
+ }
+ if ((mcs_have & IEEE80211_RADIOTAP_MCS_HAVE_GI) &&
+ (iterator.this_arg[1] & IEEE80211_RADIOTAP_MCS_SGI))
+ fixed_rate_flags |= IEEE80211_TX_RC_SHORT_GI;
+ if ((mcs_have & IEEE80211_RADIOTAP_MCS_HAVE_BW) &&
+ (iterator.this_arg[1]&IEEE80211_RADIOTAP_MCS_BW_40))
+ fixed_rate_flags |=
+ IEEE80211_TX_RC_40_MHZ_WIDTH;
+ break;
+ }
+
/*
* Please update the file
* Documentation/networking/mac80211-injection.txt
@@ -1539,6 +1567,41 @@ static bool ieee80211_parse_tx_radiotap(struct sk_buff *skb)
if (ret != -ENOENT) /* ie, if we didn't simply run out of fields */
return false;
+ if (fixed_rate != -1) {
+ struct ieee80211_channel *chan = local->hw.conf.channel;
+ struct ieee80211_supported_band *sband =
+ local->hw.wiphy->bands[chan->band];
+ struct ieee80211_tx_rate *rates = info->control.rates;
+ int i;
+
+ if (fixed_rate_flags & IEEE80211_TX_RC_MCS) {
+ WARN_ON(!sband->ht_cap.ht_supported);
+ rates[0].idx = fixed_rate;
+ } else {
+ /* convert legacy rate; NB: .5 Mb/s -> 100 kb/s */
+ int bitrate = fixed_rate*5;
+ rates[0].idx = 0; /* default to lowest rate */
+ for (i = 0; i < sband->n_bitrates; i++)
+ if (bitrate == sband->bitrates[i].bitrate) {
+ rates[0].idx = i;
+ break;
+ }
+ }
+
+ rates[0].count = 1+fixed_rate_data_retries;
+ if (rates[0].count > local->hw.max_rate_tries)
+ rates[0].count = local->hw.max_rate_tries;
+ rates[0].flags = fixed_rate_flags;
+
+ for (i = 1; i < IEEE80211_TX_MAX_RATES; i++) {
+ rates[i].idx = -1;
+ rates[i].count = 0;
+ rates[i].flags = 0;
+ }
+
+ info->flags |= IEEE80211_TX_CTL_NO_RC;
+ }
+
/*
* remove the radiotap header
* iterator->_max_length was sanity-checked against
@@ -1639,7 +1702,7 @@ netdev_tx_t ieee80211_monitor_start_xmit(struct sk_buff *skb,
IEEE80211_TX_CTL_INJECTED;
/* process and remove the injection radiotap header */
- if (!ieee80211_parse_tx_radiotap(skb))
+ if (!ieee80211_parse_tx_radiotap(skb, local))
goto fail;
rcu_read_lock();
diff --git a/net/wireless/radiotap.c b/net/wireless/radiotap.c
index c4ad795..0e99cb7 100644
--- a/net/wireless/radiotap.c
+++ b/net/wireless/radiotap.c
@@ -41,6 +41,7 @@ static const struct radiotap_align_size rtap_namespace_sizes[] = {
[IEEE80211_RADIOTAP_TX_FLAGS] = { .align = 2, .size = 2, },
[IEEE80211_RADIOTAP_RTS_RETRIES] = { .align = 1, .size = 1, },
[IEEE80211_RADIOTAP_DATA_RETRIES] = { .align = 1, .size = 1, },
+ [IEEE80211_RADIOTAP_MCS] = { .align = 1, .size = 3, },
/*
* add more here as they are defined in radiotap.h
*/
--
1.7.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] mac80211: support fixed rate packet injection
2012-01-12 17:53 [PATCH RESEND] mac80211: support fixed rate packet injection Sam Leffler
@ 2012-01-20 14:17 ` Johannes Berg
2012-01-20 18:44 ` Sam Leffler
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Berg @ 2012-01-20 14:17 UTC (permalink / raw)
To: Sam Leffler; +Cc: linux-wireless, John W. Linville
On Thu, 2012-01-12 at 09:53 -0800, Sam Leffler wrote:
> + if (fixed_rate != -1) {
> + struct ieee80211_channel *chan = local->hw.conf.channel;
> + struct ieee80211_supported_band *sband =
> + local->hw.wiphy->bands[chan->band];
> + struct ieee80211_tx_rate *rates = info->control.rates;
> + int i;
> +
> + if (fixed_rate_flags & IEEE80211_TX_RC_MCS) {
> + WARN_ON(!sband->ht_cap.ht_supported);
> + rates[0].idx = fixed_rate;
Unless I missed something, this would be *trivial* to trigger by
injection -- doesn't seem like a good idea to me.
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] mac80211: support fixed rate packet injection
2012-01-20 14:17 ` Johannes Berg
@ 2012-01-20 18:44 ` Sam Leffler
2012-01-20 19:19 ` Gábor Stefanik
2012-01-20 20:24 ` Johannes Berg
0 siblings, 2 replies; 6+ messages in thread
From: Sam Leffler @ 2012-01-20 18:44 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, John W. Linville
On Fri, Jan 20, 2012 at 6:17 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
>
> On Thu, 2012-01-12 at 09:53 -0800, Sam Leffler wrote:
>
> > + if (fixed_rate != -1) {
> > + struct ieee80211_channel *chan = local->hw.conf.channel;
> > + struct ieee80211_supported_band *sband =
> > + local->hw.wiphy->bands[chan->band];
> > + struct ieee80211_tx_rate *rates = info->control.rates;
> > + int i;
> > +
> > + if (fixed_rate_flags & IEEE80211_TX_RC_MCS) {
> > + WARN_ON(!sband->ht_cap.ht_supported);
> > + rates[0].idx = fixed_rate;
>
> Unless I missed something, this would be *trivial* to trigger by
> injection -- doesn't seem like a good idea to me.
>
Can unprivileged users inject packets? Is your preference to generate
an error or just suppress the warning?
-Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] mac80211: support fixed rate packet injection
2012-01-20 18:44 ` Sam Leffler
@ 2012-01-20 19:19 ` Gábor Stefanik
2012-01-20 20:24 ` Johannes Berg
1 sibling, 0 replies; 6+ messages in thread
From: Gábor Stefanik @ 2012-01-20 19:19 UTC (permalink / raw)
To: Sam Leffler; +Cc: Johannes Berg, linux-wireless, John W. Linville
On Fri, Jan 20, 2012 at 7:44 PM, Sam Leffler <sleffler@chromium.org> wrote:
> On Fri, Jan 20, 2012 at 6:17 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
>>
>> On Thu, 2012-01-12 at 09:53 -0800, Sam Leffler wrote:
>>
>> > + if (fixed_rate != -1) {
>> > + struct ieee80211_channel *chan = local->hw.conf.channel;
>> > + struct ieee80211_supported_band *sband =
>> > + local->hw.wiphy->bands[chan->band];
>> > + struct ieee80211_tx_rate *rates = info->control.rates;
>> > + int i;
>> > +
>> > + if (fixed_rate_flags & IEEE80211_TX_RC_MCS) {
>> > + WARN_ON(!sband->ht_cap.ht_supported);
>> > + rates[0].idx = fixed_rate;
>>
>> Unless I missed something, this would be *trivial* to trigger by
>> injection -- doesn't seem like a good idea to me.
>>
>
> Can unprivileged users inject packets? Is your preference to generate
> an error or just suppress the warning?
>
> -Sam
Yes, only the creation of monitor interfaces is restricted to root.
Once an interface is set up, anyone can inject.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] mac80211: support fixed rate packet injection
2012-01-20 18:44 ` Sam Leffler
2012-01-20 19:19 ` Gábor Stefanik
@ 2012-01-20 20:24 ` Johannes Berg
2012-01-20 21:42 ` Sam Leffler
1 sibling, 1 reply; 6+ messages in thread
From: Johannes Berg @ 2012-01-20 20:24 UTC (permalink / raw)
To: Sam Leffler; +Cc: linux-wireless, John W. Linville
On Fri, 2012-01-20 at 10:44 -0800, Sam Leffler wrote:
> On Fri, Jan 20, 2012 at 6:17 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> >
> > On Thu, 2012-01-12 at 09:53 -0800, Sam Leffler wrote:
> >
> > > + if (fixed_rate != -1) {
> > > + struct ieee80211_channel *chan = local->hw.conf.channel;
> > > + struct ieee80211_supported_band *sband =
> > > + local->hw.wiphy->bands[chan->band];
> > > + struct ieee80211_tx_rate *rates = info->control.rates;
> > > + int i;
> > > +
> > > + if (fixed_rate_flags & IEEE80211_TX_RC_MCS) {
> > > + WARN_ON(!sband->ht_cap.ht_supported);
> > > + rates[0].idx = fixed_rate;
> >
> > Unless I missed something, this would be *trivial* to trigger by
> > injection -- doesn't seem like a good idea to me.
> >
>
> Can unprivileged users inject packets? Is your preference to generate
> an error or just suppress the warning?
I'm not sure, but it doesn't really matter -- even printing an error
here is quite pointless.
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] mac80211: support fixed rate packet injection
2012-01-20 20:24 ` Johannes Berg
@ 2012-01-20 21:42 ` Sam Leffler
0 siblings, 0 replies; 6+ messages in thread
From: Sam Leffler @ 2012-01-20 21:42 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, John W. Linville
On Fri, Jan 20, 2012 at 12:24 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
>
> On Fri, 2012-01-20 at 10:44 -0800, Sam Leffler wrote:
> > On Fri, Jan 20, 2012 at 6:17 AM, Johannes Berg
> > <johannes@sipsolutions.net> wrote:
> > >
> > > On Thu, 2012-01-12 at 09:53 -0800, Sam Leffler wrote:
> > >
> > > > + if (fixed_rate != -1) {
> > > > + struct ieee80211_channel *chan = local->hw.conf.channel;
> > > > + struct ieee80211_supported_band *sband =
> > > > + local->hw.wiphy->bands[chan->band];
> > > > + struct ieee80211_tx_rate *rates = info->control.rates;
> > > > + int i;
> > > > +
> > > > + if (fixed_rate_flags & IEEE80211_TX_RC_MCS) {
> > > > + WARN_ON(!sband->ht_cap.ht_supported);
> > > > + rates[0].idx = fixed_rate;
> > >
> > > Unless I missed something, this would be *trivial* to trigger by
> > > injection -- doesn't seem like a good idea to me.
> > >
> >
> > Can unprivileged users inject packets? Is your preference to generate
> > an error or just suppress the warning?
>
> I'm not sure, but it doesn't really matter -- even printing an error
> here is quite pointless.
>
Not sure why you say that. If you submit a packet and it's tossed w/o
any indication (e.g. you mistakenly set the channel wrong so the
driver tosses the frame) then it's not obvious what's going on.
Anyway, I'll remove the warning.
-Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-01-20 21:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-12 17:53 [PATCH RESEND] mac80211: support fixed rate packet injection Sam Leffler
2012-01-20 14:17 ` Johannes Berg
2012-01-20 18:44 ` Sam Leffler
2012-01-20 19:19 ` Gábor Stefanik
2012-01-20 20:24 ` Johannes Berg
2012-01-20 21:42 ` Sam Leffler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.