All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] be2net: create RSS rings even in multi-channel configs
@ 2012-01-20  6:34 Sathya Perla
  2012-01-22 19:25 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Sathya Perla @ 2012-01-20  6:34 UTC (permalink / raw)
  To: netdev

Currently RSS rings are not created in a multi-channel config.
RSS rings can be created on one (out of four) interfaces per port in a
multi-channel config. Doing this insulates the driver from a FW bug wherin
multi-channel config is wrongly reported even when not enabled. This also
helps performance in a multi-channel config, as one interface per port gets
RSS rings.

Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
---
 drivers/net/ethernet/emulex/benet/be_main.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 6c46753..dfe748e 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -1786,8 +1786,7 @@ static void be_rx_queues_destroy(struct be_adapter *adapter)
 static u32 be_num_rxqs_want(struct be_adapter *adapter)
 {
 	if ((adapter->function_caps & BE_FUNCTION_CAPS_RSS) &&
-	     !sriov_enabled(adapter) && be_physfn(adapter) &&
-	     !be_is_mc(adapter)) {
+	     !sriov_enabled(adapter) && be_physfn(adapter)) {
 		return 1 + MAX_RSS_QS; /* one default non-RSS queue */
 	} else {
 		dev_warn(&adapter->pdev->dev,
-- 
1.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] be2net: create RSS rings even in multi-channel configs
  2012-01-20  6:34 [PATCH] be2net: create RSS rings even in multi-channel configs Sathya Perla
@ 2012-01-22 19:25 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-01-22 19:25 UTC (permalink / raw)
  To: sathya.perla; +Cc: netdev

From: Sathya Perla <sathya.perla@emulex.com>
Date: Fri, 20 Jan 2012 12:04:04 +0530

> Currently RSS rings are not created in a multi-channel config.
> RSS rings can be created on one (out of four) interfaces per port in a
> multi-channel config. Doing this insulates the driver from a FW bug wherin
> multi-channel config is wrongly reported even when not enabled. This also
> helps performance in a multi-channel config, as one interface per port gets
> RSS rings.
> 
> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-01-22 19:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-20  6:34 [PATCH] be2net: create RSS rings even in multi-channel configs Sathya Perla
2012-01-22 19:25 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.