may i ask a question about nfs fs ? thanks a lot.

may i ask a question about nfs fs ? thanks a lot.

[wangjing]

DQptYXkgaSBhc2sgYSBxdWVzdGlvbj8gdGhhbmtzIGEgbG90Lg0KDQp0aGUgYmFja2dyb3VuZA0K
ICAgMaGiTGludXggZnMgaGFzICAgL25mc21udC93b3JrX3B1Yi93ZWIgYW5kIC9uZnNtbnQvd29y
a19pbndvcmsvd2ViIKOsdGhleSB1c2UgTkZTIFYzIG1vdW50DQogICAyoaJ0aGVyZSBpcyBtYW55
IHByb2Nlc3Mgd2lsbCByZWFkIGFuZCB3cml0ZSBmaWxlcyBpbiB0aGUgZGlyIC9uZnNtbnQvd29y
a19wdWIvd2ViIA0KICAgM6GiY3JvbiB3aWxsIGRlbCAgYWxsIGZpbGVzIGluIGRpciAgL25mc21u
dC93b3JrX3B1Yi93ZWIgaW4gcGVyaW9ko6xhbmQgd2lsbCBjb3B5IGFsbCB0aGUgZmlsZXMgd2hp
Y2ggaW4gdGhlIGRpciAvbmZzbW50L3dvcmtfaW53b3JrL3dlYiANCg0KaW4gc29tZSB0aW1lcyBk
ZWxldGUgYWxsIGZpbGVzIGluICAvbmZzbW50L3dvcmtfcHViL3dlYiB3aWxsIGZhaWxkICxiZWNh
dXNlIHRoZXJlIGlzIHNvbWUgLm5mc1hYWFgNCg0KDQoNCk15IHF1ZXN0aW9uIGlzIDpjYW4gaSBt
b2RpZnkgbmZzX3NpbGx5cmVuYW1lIGZ1bm5jaW9uICBpbiB0aGUgZnMvbmZzL2Rpci5jICwgZ2Vu
ZXJhbCBhbGwgLm5mc1hYWCBpbiAvdG1wLGFuZCBtYWtlIGtlcm5lbCA/DQoNCg0KDQpzdGF0aWMg
aW50IG5mc19zaWxseXJlbmFtZShzdHJ1Y3QgaW5vZGUgKmRpciwgc3RydWN0IGRlbnRyeSAqZGVu
dHJ5KQ0Kew0Kc3RhdGljIHVuc2lnbmVkIGludCBzaWxseWNvdW50ZXI7DQpjb25zdCBpbnQgICAg
ICBpX2lub3NpemUgID0gc2l6ZW9mKGRpci0+aV9pbm8pKjI7DQpjb25zdCBpbnQgICAgICBjb3Vu
dGVyc2l6ZSA9IHNpemVvZihzaWxseWNvdW50ZXIpKjI7DQpjb25zdCBpbnQgICAgICBzbGVuICAg
ICAgID0gc3RybGVuKCIubmZzIikgKyBpX2lub3NpemUgKyBjb3VudGVyc2l6ZTsNCmNoYXIgICAg
ICAgICAgIHNpbGx5W3NsZW4rMV07DQpzdHJ1Y3QgcXN0ciAgICBxc2lsbHk7DQpzdHJ1Y3QgZGVu
dHJ5ICpzZGVudHJ5Ow0KaW50ICAgICAgICAgICAgZXJyb3IgPSAtRUlPOw0KZGZwcmludGsoVkZT
LCAiTkZTOiBzaWxseS1yZW5hbWUoJXMvJXMsIGN0PSVkKVxuIiwNCmRlbnRyeS0+ZF9wYXJlbnQt
PmRfbmFtZS5uYW1lLCBkZW50cnktPmRfbmFtZS5uYW1lLCANCmF0b21pY19yZWFkKCZkZW50cnkt
PmRfY291bnQpKTsNCmlmIChhdG9taWNfcmVhZCgmZGVudHJ5LT5kX2NvdW50KSA9PSAxKQ0KZ290
byBvdXQ7ICAvKiBObyBuZWVkIHRvIHNpbGx5IHJlbmFtZS4gKi8NCiNpZmRlZiBORlNfUEFSQU5P
SUENCmlmICghZGVudHJ5LT5kX2lub2RlKQ0KcHJpbnRrKCJORlM6IHNpbGx5LXJlbmFtaW5nICVz
LyVzLCBuZWdhdGl2ZSBkZW50cnk/P1xuIiwNCmRlbnRyeS0+ZF9wYXJlbnQtPmRfbmFtZS5uYW1l
LCBkZW50cnktPmRfbmFtZS5uYW1lKTsNCiNlbmRpZg0KLyoNCiAqIFdlIGRvbid0IGFsbG93IGEg
ZGVudHJ5IHRvIGJlIHNpbGx5LXJlbmFtZWQgdHdpY2UuDQogKi8NCmVycm9yID0gLUVCVVNZOw0K
aWYgKGRlbnRyeS0+ZF9mbGFncyAmIERDQUNIRV9ORlNGU19SRU5BTUVEKQ0KZ290byBvdXQ7DQpz
cHJpbnRmKHNpbGx5LCAiLm5mcyUqLipseCIsDQppX2lub3NpemUsIGlfaW5vc2l6ZSwgZGVudHJ5
LT5kX2lub2RlLT5pX2lubyk7DQpzZGVudHJ5ID0gTlVMTDsNCmRvIHsNCmNoYXIgKnN1ZmZpeCA9
IHNpbGx5ICsgc2xlbiAtIGNvdW50ZXJzaXplOw0KZHB1dChzZGVudHJ5KTsNCnNpbGx5Y291bnRl
cisrOw0Kc3ByaW50ZihzdWZmaXgsICIlKi4qeCIsIGNvdW50ZXJzaXplLCBjb3VudGVyc2l6ZSwg
c2lsbHljb3VudGVyKTsNCmRmcHJpbnRrKFZGUywgInRyeWluZyB0byByZW5hbWUgJXMgdG8gJXNc
biIsDQogZGVudHJ5LT5kX25hbWUubmFtZSwgc2lsbHkpOw0Kc2RlbnRyeSA9IGxvb2t1cF9vbmUo
c2lsbHksIGRlbnRyeS0+ZF9wYXJlbnQpOw0KLyoNCiAqIE4uQi4gQmV0dGVyIHRvIHJldHVybiBF
QlVTWSBoZXJlIC4uLiBpdCBjb3VsZCBiZQ0KICogZGFuZ2Vyb3VzIHRvIGRlbGV0ZSB0aGUgZmls
ZSB3aGlsZSBpdCdzIGluIHVzZS4NCiAqLw0KaWYgKElTX0VSUihzZGVudHJ5KSkNCmdvdG8gb3V0
Ow0KfSB3aGlsZShzZGVudHJ5LT5kX2lub2RlICE9IE5VTEwpOyAvKiBuZWVkIG5lZ2F0aXZlIGxv
b2t1cCAqLw0KbmZzX3phcF9jYWNoZXMoZGlyKTsNCnFzaWxseS5uYW1lID0gc2lsbHk7DQpxc2ls
bHkubGVuICA9IHN0cmxlbihzaWxseSk7DQplcnJvciA9IE5GU19QUk9UTyhkaXIpLT5yZW5hbWUo
ZGlyLCAmZGVudHJ5LT5kX25hbWUsIGRpciwgJnFzaWxseSk7ICAvL2NhbiBpIG1vZGlmeSB0aGlz
IHRvIHNvbHZlIG15IGlzc2l1ZSAgv8m38dDeuMQgtMu0prT6wuvAtL3ivvbOysziDQppZiAoIWVy
cm9yKSB7DQpuZnNfcmVuZXdfdGltZXMoZGVudHJ5KTsNCmRfbW92ZShkZW50cnksIHNkZW50cnkp
Ow0KZXJyb3IgPSBuZnNfYXN5bmNfdW5saW5rKGRlbnRyeSk7DQogIC8qIElmIHdlIHJldHVybiAw
IHdlIGRvbid0IHVubGluayAqLw0KfQ0KZHB1dChzZGVudHJ5KTsNCm91dDoNCnJldHVybiBlcnJv
cjsNCn0NCg0KDQoNCg0KMjAxMi0wMi0wMSANCndhbmdqaW5nDQo=

Re: may i ask a question about nfs fs ? thanks a lot.

[Jim Rees]

wangjing wrote:

  may i ask a question? thanks a lot.

Not trying to be difficult, but you'll have better luck if you:

1. Use a descriptive subject. Something like "modify sillyrename to put
files in /tmp".

2. Run your code through indent(1).  It's unreadable as-is.

3. Use an international standard character set, like utf-8.

Re:Re: may i ask a question about nfs fs ? thanks a lot.

[wangjing]

thanks for your help.

In nfs v3 ,if mulity process visit nfs mount nfs dir ,there sometimes occour .nfsXXX can't delete .

if modify sillyrename to put files in /tmp ,it will be more friendly to nfs user.


2012-02-02 
wangjing 




 Re: may i ask a question about nfs fs ? thanks a lot. 
 
wangjing wrote:
  may i ask a question? thanks a lot.
Not trying to be difficult, but you'll have better luck if you:
1. Use a descriptive subject. Something like "modify sillyrename to put
files in /tmp".
2. Run your code through indent(1).  It's unreadable as-is.
3. Use an international standard character set, like utf-8.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: may i ask a question about nfs fs ? thanks a lot.

[Boaz Harrosh]

On 02/01/2012 06:09 PM, wangjing wrote:
> 
> may i ask a question? thanks a lot.
> 
> the background
>    1、Linux fs has   /nfsmnt/work_pub/web and /nfsmnt/work_inwork/web ，they use NFS V3 mount
>    2、there is many process will read and write files in the dir /nfsmnt/work_pub/web 
>    3、cron will del  all files in dir  /nfsmnt/work_pub/web in period，and will copy all the files which in the dir /nfsmnt/work_inwork/web 
> 
> in some times delete all files in  /nfsmnt/work_pub/web will faild ,because there is some .nfsXXXX
> 
> 
> 
> My question is :can i modify nfs_sillyrename funncion  in the fs/nfs/dir.c , general all .nfsXXX in /tmp,and make kernel ?
> 
> 

You can't do this. /tmp on the client is on a different superblock than the nfs mount, and the point of
sillyrename is that it is a rename and not a move. (i.e same inode)

The /tmp on the server is not even accessible on the client, which does the sillyrename.

You'll have to better your scripts to loop and delete until all  .nfsXXXX go away because
these are temporarily there until the application on the client stops using the file.

Cheers
Boaz

Re: may i ask a question about nfs fs ? thanks a lot.

[sword]

何不直接去掉sillyrename功能，反正要暴力删除文件。 放到/tmp不大可能。
cron应该在client, 否则怎能有删不掉的文件?! 把它放到server端吧... 

On Thu, 2012-02-02 at 00:09 +0800, wangjing wrote:
> may i ask a question? thanks a lot.
> 
> the background
>    1、Linux fs has   /nfsmnt/work_pub/web and /nfsmnt/work_inwork/web ，they use NFS V3 mount
>    2、there is many process will read and write files in the dir /nfsmnt/work_pub/web 
>    3、cron will del  all files in dir  /nfsmnt/work_pub/web in period，and will copy all the files which in the dir /nfsmnt/work_inwork/web 
> 
> in some times delete all files in  /nfsmnt/work_pub/web will faild ,because there is some .nfsXXXX
> 
> 
> 
> My question is :can i modify nfs_sillyrename funncion  in the fs/nfs/dir.c , general all .nfsXXX in /tmp,and make kernel ?
> 
> 
> 
> static int nfs_sillyrename(struct inode *dir, struct dentry *dentry)
> {
> static unsigned int sillycounter;
> const int      i_inosize  = sizeof(dir->i_ino)*2;
> const int      countersize = sizeof(sillycounter)*2;
> const int      slen       = strlen(".nfs") + i_inosize + countersize;
> char           silly[slen+1];
> struct qstr    qsilly;
> struct dentry *sdentry;
> int            error = -EIO;
> dfprintk(VFS, "NFS: silly-rename(%s/%s, ct=%d)\n",
> dentry->d_parent->d_name.name, dentry->d_name.name, 
> atomic_read(&dentry->d_count));
> if (atomic_read(&dentry->d_count) == 1)
> goto out;  /* No need to silly rename. */
> #ifdef NFS_PARANOIA
> if (!dentry->d_inode)
> printk("NFS: silly-renaming %s/%s, negative dentry??\n",
> dentry->d_parent->d_name.name, dentry->d_name.name);
> #endif
> /*
>  * We don't allow a dentry to be silly-renamed twice.
>  */
> error = -EBUSY;
> if (dentry->d_flags & DCACHE_NFSFS_RENAMED)
> goto out;
> sprintf(silly, ".nfs%*.*lx",
> i_inosize, i_inosize, dentry->d_inode->i_ino);
> sdentry = NULL;
> do {
> char *suffix = silly + slen - countersize;
> dput(sdentry);
> sillycounter++;
> sprintf(suffix, "%*.*x", countersize, countersize, sillycounter);
> dfprintk(VFS, "trying to rename %s to %s\n",
>  dentry->d_name.name, silly);
> sdentry = lookup_one(silly, dentry->d_parent);
> /*
>  * N.B. Better to return EBUSY here ... it could be
>  * dangerous to delete the file while it's in use.
>  */
> if (IS_ERR(sdentry))
> goto out;
> } while(sdentry->d_inode != NULL); /* need negative lookup */
> nfs_zap_caches(dir);
> qsilly.name = silly;
> qsilly.len  = strlen(silly);
> error = NFS_PROTO(dir)->rename(dir, &dentry->d_name, dir, &qsilly);  //can i modify this to solve my issiue  可否修改 此处代码来解决问题
> if (!error) {
> nfs_renew_times(dentry);
> d_move(dentry, sdentry);
> error = nfs_async_unlink(dentry);
>   /* If we return 0 we don't unlink */
> }
> dput(sdentry);
> out:
> return error;
> }
> 
> 
> 
> 
> 2012-02-01 
> wangjing
> NР骒rybX肚v^)藓{.n+伐{"^nr■z\x1ahㄨ&Ⅷ\x1eGh\x03(茛j"\x1a^[m赇z罐帼f＂h~m