All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: Richard Zhao <richard.zhao@freescale.com>
Cc: alsa-devel@alsa-project.org, kernel@pengutronix.de,
	linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
	broonie@opensource.wolfsonmicro.com, eric.miao@linaro.org,
	patches@linaro.org, Richard Zhao <richard.zhao@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 6/9] ARM: mx31ads: add audmux device
Date: Thu, 2 Feb 2012 21:09:03 +0800	[thread overview]
Message-ID: <20120202130901.GE9773@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <20120202092427.GB32403@b20223-02.ap.freescale.net>

On Thu, Feb 02, 2012 at 05:24:28PM +0800, Richard Zhao wrote:
> On Thu, Feb 02, 2012 at 05:11:34PM +0800, Shawn Guo wrote:
> > On Thu, Feb 02, 2012 at 04:55:23PM +0800, Shawn Guo wrote:
> > > On Thu, Feb 02, 2012 at 10:12:05AM +0800, Richard Zhao wrote:
> > > > Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
> > > > ---
> > > >  arch/arm/mach-imx/mach-mx31ads.c      |   10 ++++++++++
> > > >  arch/arm/plat-mxc/include/mach/mx31.h |    1 +
> > > >  2 files changed, 11 insertions(+), 0 deletions(-)
> > > > 
> > > Hmm, let's see who are actually using mxc_audmux_v2_configure_port().
> > > 
> > > $ git grep -n mxc_audmux_v2_configure_port arch/arm/
> > > arch/arm/mach-imx/eukrea_mbimxsd25-baseboard.c:246:     mxc_audmux_v2_configure_port(0,
> > > arch/arm/mach-imx/eukrea_mbimxsd25-baseboard.c:254:     mxc_audmux_v2_configure_port(4,
> > > arch/arm/mach-imx/eukrea_mbimxsd35-baseboard.c:257:     mxc_audmux_v2_configure_port(0,
> > > arch/arm/mach-imx/eukrea_mbimxsd35-baseboard.c:265:     mxc_audmux_v2_configure_port(3,
> > > arch/arm/mach-imx/mach-pcm043.c:365:    mxc_audmux_v2_configure_port(3,
> > > arch/arm/mach-imx/mach-pcm043.c:371:    mxc_audmux_v2_configure_port(0,
> I didn't grep arch/arm. where is pc043 asoc machine file?

It seems to be sound/soc/imx/phycore-ac97.c.

> > > 
> > As we are moving audmux into sound/soc/imx, it makes less sense to
> > still keep these calls in board files.
> It don't corrupt git bisect. We don't have to include it in this patch.

It's logically part of this series.

> >  Instead, I prefer to call it
> > from machine driver like what wm1133-ev1 does below.
> Maybe pass the info as asoc machine driver pdata.

Sounds good.

> >  Or we can simply
> > make the it a audmux-self call with 3 parameters it needs retrieved
> > from platform_data or device tree, so that machine driver does not
> > even bother with the call.  Makes sense?
> audux configuration may change after initial set. For example, it may use
> one configuration for audio playback, but use another when you connect a
> BT audio device.

Right.  I forgot this point.

-- 
Regards,
Shawn

WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/9] ARM: mx31ads: add audmux device
Date: Thu, 2 Feb 2012 21:09:03 +0800	[thread overview]
Message-ID: <20120202130901.GE9773@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <20120202092427.GB32403@b20223-02.ap.freescale.net>

On Thu, Feb 02, 2012 at 05:24:28PM +0800, Richard Zhao wrote:
> On Thu, Feb 02, 2012 at 05:11:34PM +0800, Shawn Guo wrote:
> > On Thu, Feb 02, 2012 at 04:55:23PM +0800, Shawn Guo wrote:
> > > On Thu, Feb 02, 2012 at 10:12:05AM +0800, Richard Zhao wrote:
> > > > Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
> > > > ---
> > > >  arch/arm/mach-imx/mach-mx31ads.c      |   10 ++++++++++
> > > >  arch/arm/plat-mxc/include/mach/mx31.h |    1 +
> > > >  2 files changed, 11 insertions(+), 0 deletions(-)
> > > > 
> > > Hmm, let's see who are actually using mxc_audmux_v2_configure_port().
> > > 
> > > $ git grep -n mxc_audmux_v2_configure_port arch/arm/
> > > arch/arm/mach-imx/eukrea_mbimxsd25-baseboard.c:246:     mxc_audmux_v2_configure_port(0,
> > > arch/arm/mach-imx/eukrea_mbimxsd25-baseboard.c:254:     mxc_audmux_v2_configure_port(4,
> > > arch/arm/mach-imx/eukrea_mbimxsd35-baseboard.c:257:     mxc_audmux_v2_configure_port(0,
> > > arch/arm/mach-imx/eukrea_mbimxsd35-baseboard.c:265:     mxc_audmux_v2_configure_port(3,
> > > arch/arm/mach-imx/mach-pcm043.c:365:    mxc_audmux_v2_configure_port(3,
> > > arch/arm/mach-imx/mach-pcm043.c:371:    mxc_audmux_v2_configure_port(0,
> I didn't grep arch/arm. where is pc043 asoc machine file?

It seems to be sound/soc/imx/phycore-ac97.c.

> > > 
> > As we are moving audmux into sound/soc/imx, it makes less sense to
> > still keep these calls in board files.
> It don't corrupt git bisect. We don't have to include it in this patch.

It's logically part of this series.

> >  Instead, I prefer to call it
> > from machine driver like what wm1133-ev1 does below.
> Maybe pass the info as asoc machine driver pdata.

Sounds good.

> >  Or we can simply
> > make the it a audmux-self call with 3 parameters it needs retrieved
> > from platform_data or device tree, so that machine driver does not
> > even bother with the call.  Makes sense?
> audux configuration may change after initial set. For example, it may use
> one configuration for audio playback, but use another when you connect a
> BT audio device.

Right.  I forgot this point.

-- 
Regards,
Shawn

  reply	other threads:[~2012-02-02 13:09 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02  2:11 [PATCH v2 0/9] imx patches when I enable imx6q sabrelite audio Richard Zhao
2012-02-02  2:11 ` Richard Zhao
2012-02-02  2:12 ` [PATCH v2 1/9] ARM: mxc: make imx_dma_is_general_purpose more generic for sdma Richard Zhao
2012-02-02  2:12   ` Richard Zhao
2012-02-02  2:12 ` [PATCH v2 2/9] ARM: imx6q: add cko1 clock Richard Zhao
2012-02-02  2:12   ` Richard Zhao
2012-02-02  2:12 ` [PATCH v2 3/9] ARM: dts: imx6q-sabrelite: add 2p5v and 3p3v regulators Richard Zhao
2012-02-02  2:12   ` Richard Zhao
2012-02-02  2:12 ` [PATCH v2 4/9] ARM: dts: imx6q-sabrelite: add sgtl5000 audio codec Richard Zhao
2012-02-02  2:12   ` Richard Zhao
2012-02-02 11:24   ` Fabio Estevam
2012-02-02 11:24     ` Fabio Estevam
2012-02-02 13:49     ` Richard Zhao
2012-02-02 13:49       ` Richard Zhao
2012-02-02 14:15       ` Fabio Estevam
2012-02-02 14:15         ` Fabio Estevam
2012-02-02 14:41         ` Richard Zhao
2012-02-02 14:41           ` Richard Zhao
2012-02-02  2:12 ` [PATCH v2 5/9] ARM: mxc: convert audmux-v2 to a platform driver Richard Zhao
2012-02-02  2:12   ` Richard Zhao
2012-02-02  2:12 ` [PATCH v2 6/9] ARM: mx31ads: add audmux device Richard Zhao
2012-02-02  2:12   ` Richard Zhao
2012-02-02  8:55   ` Shawn Guo
2012-02-02  8:55     ` Shawn Guo
2012-02-02  9:11     ` Shawn Guo
2012-02-02  9:11       ` Shawn Guo
2012-02-02  9:24       ` Richard Zhao
2012-02-02  9:24         ` Richard Zhao
2012-02-02 13:09         ` Shawn Guo [this message]
2012-02-02 13:09           ` Shawn Guo
2012-02-02 13:58           ` Richard Zhao
2012-02-02 13:58             ` Richard Zhao
2012-02-02 14:09             ` Mark Brown
2012-02-02 14:09               ` Mark Brown
2012-02-02 14:25             ` Shawn Guo
2012-02-02 14:25               ` Shawn Guo
2012-02-03  2:15             ` Richard Zhao
2012-02-03  2:15               ` Richard Zhao
2012-02-03 13:32               ` Shawn Guo
2012-02-03 13:32                 ` Shawn Guo
2012-02-05  4:50                 ` Richard Zhao
2012-02-05  4:50                   ` Richard Zhao
2012-02-14  1:35                   ` Richard Zhao
2012-02-14  1:35                     ` Richard Zhao
2012-02-14  6:06                     ` Mark Brown
2012-02-14  6:06                       ` Mark Brown
2012-02-14  7:34                       ` Richard Zhao
2012-02-14  7:34                         ` Richard Zhao
2012-02-14 17:23                         ` Mark Brown
2012-02-14 17:23                           ` Mark Brown
2012-02-03 13:27           ` Shawn Guo
2012-02-03 13:27             ` Shawn Guo
2012-02-02 12:09   ` Mark Brown
2012-02-02 12:09     ` Mark Brown
2012-02-02 13:17     ` Shawn Guo
2012-02-02 13:17       ` Shawn Guo
2012-02-02 13:26       ` Mark Brown
2012-02-02 13:26         ` Mark Brown
2012-02-02 14:11         ` Shawn Guo
2012-02-02 14:11           ` Shawn Guo
2012-02-02 14:16           ` Mark Brown
2012-02-02 14:16             ` Mark Brown
2012-02-02  2:12 ` [PATCH v2 7/9] ARM: mxc: move audmux-v2 to sound/soc/imx Richard Zhao
2012-02-02  2:12   ` Richard Zhao
2012-02-02  9:02   ` Shawn Guo
2012-02-02  9:02     ` Shawn Guo
2012-02-02  9:42     ` Richard Zhao
2012-02-02  9:42       ` Richard Zhao
2012-02-02  2:12 ` [PATCH v2 8/9] ASoC: imx: add dt support for audmux-v2 Richard Zhao
2012-02-02  2:12   ` Richard Zhao
2012-02-02 12:10   ` Mark Brown
2012-02-02 12:10     ` Mark Brown
2012-02-02 14:02     ` Richard Zhao
2012-02-02 14:02       ` Richard Zhao
2012-02-02  2:12 ` [PATCH v2 9/9] ARM: imx6q-sabrelite: add audmux support Richard Zhao
2012-02-02  2:12   ` Richard Zhao
2012-02-02  8:30   ` Shawn Guo
2012-02-02  8:30     ` Shawn Guo
2012-02-02  8:22     ` Richard Zhao
2012-02-02  8:22       ` Richard Zhao
2012-02-02  8:32   ` Shawn Guo
2012-02-02  8:32     ` Shawn Guo
2012-02-27  7:59 ` [PATCH v2 0/9] imx patches when I enable imx6q sabrelite audio Shawn Guo
2012-02-27  7:59   ` Shawn Guo
2012-02-28 12:07   ` Richard Zhao
2012-02-28 12:07     ` Richard Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120202130901.GE9773@S2101-09.ap.freescale.net \
    --to=shawn.guo@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=eric.miao@linaro.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=richard.zhao@freescale.com \
    --cc=richard.zhao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.