All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: anisse@astier.eu
Cc: xemul@parallels.com, netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH] net: Default UDP and UNIX diag to 'n'.
Date: Tue, 07 Feb 2012 12:29:00 -0500 (EST)	[thread overview]
Message-ID: <20120207.122900.1158401078057884372.davem@davemloft.net> (raw)
In-Reply-To: <20120207145120.26905922@destiny.ordissimo>

From: Anisse Astier <anisse@astier.eu>
Date: Tue, 7 Feb 2012 14:51:20 +0100

> On Tue, 07 Feb 2012 17:37:51 +0400, Pavel Emelyanov <xemul@parallels.com> wrote :
> 
>> >> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
>> >> index 1a8f93b..43e1439 100644
>> >> --- a/net/ipv4/Kconfig
>> >> +++ b/net/ipv4/Kconfig
>> >> @@ -410,8 +410,12 @@ config INET_TCP_DIAG
>> >>  	def_tristate INET_DIAG
>> >>  
>> >>  config INET_UDP_DIAG
>> >> +	tristate "UDP: socket monitoring interface"
>> >>  	depends on INET_DIAG
>> >> -	def_tristate INET_DIAG && IPV6
>> > This broke earlier patch 
>> > b872a2371ffd13e6d83423ef621a707df4c158ac "udp_diag: Make it module when ipv6 is a module",
>> > which brings back the compilation error when compiling linus master (v3.3-rc2+):
>> > 
>> > net/built-in.o: In function `udp_dump_one':
>> > udp_diag.c:(.text+0x59852): undefined reference to `__udp6_lib_lookup'
>> > 
>> > 
>> >> +	default n
>> >> +	---help---
>> >> +	  Support for UDP socket monitoring interface used by the ss tool.
>> >> +	  If unsure, say Y.
>> >>  
>> 
>> I assume you have CONFIG_IPV6=m and CONFIG_INET_UDP_DIAG=y, right?
> 
> That's correct.
> 
>> This one should fix the issue, you'll not be able to set it to Y when
>> IPV6 is M.
> 
> Indeed, it fixes the issue, but it also prevents using UDP_DIAG without
> IPv6 (just like the previous patch I guess.). Not a problem for me.

I don't think the previous code prevented udp_diag w/o ipv6, and requiring
ipv6 for udp_diag is not acceptable so this patch needs to be updated to
allow that.

  reply	other threads:[~2012-02-07 17:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07 20:13 [PATCH] net: Default UDP and UNIX diag to 'n' David Miller
2012-02-07 11:12 ` Anisse Astier
2012-02-07 13:37   ` Pavel Emelyanov
2012-02-07 13:51     ` Anisse Astier
2012-02-07 17:29       ` David Miller [this message]
2012-02-07 17:29     ` David Miller
2012-02-07 17:39       ` Anisse Astier
2012-02-07 18:36         ` David Miller
2012-02-07 21:01           ` Anisse Astier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120207.122900.1158401078057884372.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=anisse@astier.eu \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.